2001-03-12 00:04:52 +00:00
|
|
|
/*
|
|
|
|
* IBM Accurate Mathematical Library
|
2024-01-01 18:12:26 +00:00
|
|
|
* Copyright (C) 2001-2024 Free Software Foundation, Inc.
|
2001-03-12 00:04:52 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU Lesser General Public License as published by
|
2002-08-26 22:40:48 +00:00
|
|
|
* the Free Software Foundation; either version 2.1 of the License, or
|
2001-03-12 00:04:52 +00:00
|
|
|
* (at your option) any later version.
|
2002-08-20 21:51:55 +00:00
|
|
|
*
|
2001-03-12 00:04:52 +00:00
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2002-08-20 21:51:55 +00:00
|
|
|
* GNU Lesser General Public License for more details.
|
2001-03-12 00:04:52 +00:00
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public License
|
Prefer https to http for gnu.org and fsf.org URLs
Also, change sources.redhat.com to sourceware.org.
This patch was automatically generated by running the following shell
script, which uses GNU sed, and which avoids modifying files imported
from upstream:
sed -ri '
s,(http|ftp)(://(.*\.)?(gnu|fsf|sourceware)\.org($|[^.]|\.[^a-z])),https\2,g
s,(http|ftp)(://(.*\.)?)sources\.redhat\.com($|[^.]|\.[^a-z]),https\2sourceware.org\4,g
' \
$(find $(git ls-files) -prune -type f \
! -name '*.po' \
! -name 'ChangeLog*' \
! -path COPYING ! -path COPYING.LIB \
! -path manual/fdl-1.3.texi ! -path manual/lgpl-2.1.texi \
! -path manual/texinfo.tex ! -path scripts/config.guess \
! -path scripts/config.sub ! -path scripts/install-sh \
! -path scripts/mkinstalldirs ! -path scripts/move-if-change \
! -path INSTALL ! -path locale/programs/charmap-kw.h \
! -path po/libc.pot ! -path sysdeps/gnu/errlist.c \
! '(' -name configure \
-execdir test -f configure.ac -o -f configure.in ';' ')' \
! '(' -name preconfigure \
-execdir test -f preconfigure.ac ';' ')' \
-print)
and then by running 'make dist-prepare' to regenerate files built
from the altered files, and then executing the following to cleanup:
chmod a+x sysdeps/unix/sysv/linux/riscv/configure
# Omit irrelevant whitespace and comment-only changes,
# perhaps from a slightly-different Autoconf version.
git checkout -f \
sysdeps/csky/configure \
sysdeps/hppa/configure \
sysdeps/riscv/configure \
sysdeps/unix/sysv/linux/csky/configure
# Omit changes that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/powerpc/powerpc64/ppc-mcount.S: trailing lines
git checkout -f \
sysdeps/powerpc/powerpc64/ppc-mcount.S \
sysdeps/unix/sysv/linux/s390/s390-64/syscall.S
# Omit change that caused a pre-commit check to fail like this:
# remote: *** error: sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: last line does not end in newline
git checkout -f sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S
2019-09-07 05:40:42 +00:00
|
|
|
* along with this program; if not, see <https://www.gnu.org/licenses/>.
|
2001-03-12 00:04:52 +00:00
|
|
|
*/
|
2002-08-20 21:51:55 +00:00
|
|
|
|
2015-05-15 10:53:55 +00:00
|
|
|
#include <math.h>
|
|
|
|
|
2001-03-12 00:04:52 +00:00
|
|
|
/***********************************************************************/
|
|
|
|
/*MODULE_NAME: dla.h */
|
|
|
|
/* */
|
|
|
|
/* This file holds C language macros for 'Double Length Floating Point */
|
|
|
|
/* Arithmetic'. The macros are based on the paper: */
|
|
|
|
/* T.J.Dekker, "A floating-point Technique for extending the */
|
|
|
|
/* Available Precision", Number. Math. 18, 224-242 (1971). */
|
|
|
|
/* A Double-Length number is defined by a pair (r,s), of IEEE double */
|
|
|
|
/* precision floating point numbers that satisfy, */
|
|
|
|
/* */
|
|
|
|
/* abs(s) <= abs(r+s)*2**(-53)/(1+2**(-53)). */
|
|
|
|
/* */
|
|
|
|
/* The computer arithmetic assumed is IEEE double precision in */
|
|
|
|
/* round to nearest mode. All variables in the macros must be of type */
|
|
|
|
/* IEEE double. */
|
|
|
|
/***********************************************************************/
|
|
|
|
|
2012-12-29 01:26:04 +00:00
|
|
|
/* CN = 1+2**27 = '41a0000002000000' IEEE double format. Use it to split a
|
|
|
|
double for better accuracy. */
|
2001-03-12 00:04:52 +00:00
|
|
|
#define CN 134217729.0
|
|
|
|
|
|
|
|
|
|
|
|
/* Exact addition of two single-length floating point numbers, Dekker. */
|
|
|
|
/* The macro produces a double-length number (z,zz) that satisfies */
|
|
|
|
/* z+zz = x+y exactly. */
|
|
|
|
|
|
|
|
#define EADD(x,y,z,zz) \
|
2015-05-15 10:53:55 +00:00
|
|
|
z=(x)+(y); zz=(fabs(x)>fabs(y)) ? (((x)-(z))+(y)) : (((y)-(z))+(x));
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Exact subtraction of two single-length floating point numbers, Dekker. */
|
|
|
|
/* The macro produces a double-length number (z,zz) that satisfies */
|
|
|
|
/* z+zz = x-y exactly. */
|
|
|
|
|
|
|
|
#define ESUB(x,y,z,zz) \
|
2015-05-15 10:53:55 +00:00
|
|
|
z=(x)-(y); zz=(fabs(x)>fabs(y)) ? (((x)-(z))-(y)) : ((x)-((y)+(z)));
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
Use __builtin_fma more in dbl-64 code.
sysdeps/ieee754/dbl-64/dla.h can use a macro DLA_FMS for more
efficient double-width operations when fused multiply-subtract is
supported. However, this macro is only defined for x86_64,
conditional on architecture-specific __FMA4__. This patch makes the
code use __builtin_fma conditional on __FP_FAST_FMA, as used elsewhere
in glibc.
Tested for x86_64, x86 and powerpc. On powerpc (where this is causing
fused operations to be used where they weren't previously) I see an
increase from 1ulp to 2ulp in the imaginary part of clog10:
testing double (without inline functions)
Failure: Test: Imaginary part of: clog10 (0x1.7a858p+0 - 0x6.d940dp-4 i)
Result:
is: -1.2237865208199886e-01 -0x1.f5435146bb61ap-4
should be: -1.2237865208199888e-01 -0x1.f5435146bb61cp-4
difference: 2.7755575615628914e-17 0x1.0000000000000p-55
ulp : 2.0000
max.ulp : 1.0000
Maximal error of real part of: clog10
is : 3 ulp
accepted: 3 ulp
Maximal error of imaginary part of: clog10
is : 2 ulp
accepted: 1 ulp
This is actually resulting from atan2 becoming *more* accurate (atan2
(-0x6.d940dp-4, 0x1.7a858p+0) should ideally be -0x1.208cd6e841554p-2
but was -0x1.208cd6e841555p-2 from a powerpc libm built before this
change, and is -0x1.208cd6e841554p-2 from a powerpc libm built after
this change). Since these functions are not expected to be correctly
rounding by glibc's accuracy goals, neither result is a problem, but
this does imply that some of this code, although designed to be
correctly rounding, is not in fact correctly rounding (possibly
because of GCC creating fused operations where the code does not
expect it, something we've only disabled for specific functions where
it was found to cause large errors). (Of course as previously
discussed I think we should remove the slow cases where an error
analysis shows this wouldn't increase the errors much above 0.5ulp;
it's only functions such as cratan2 that are expected to be correctly
rounding, not atan2.)
* sysdeps/ieee754/dbl-64/dla.h [__FP_FAST_FMA] (DLA_FMS): Define
macro to use __builtin_fma.
* sysdeps/x86_64/fpu/dla.h: Remove file.
2016-09-30 15:49:51 +00:00
|
|
|
#ifdef __FP_FAST_FMA
|
|
|
|
# define DLA_FMS(x, y, z) __builtin_fma (x, y, -(z))
|
|
|
|
#endif
|
|
|
|
|
2001-03-12 00:04:52 +00:00
|
|
|
/* Exact multiplication of two single-length floating point numbers, */
|
|
|
|
/* Veltkamp. The macro produces a double-length number (z,zz) that */
|
|
|
|
/* satisfies z+zz = x*y exactly. p,hx,tx,hy,ty are temporary */
|
|
|
|
/* storage variables of type double. */
|
|
|
|
|
2011-10-23 17:31:01 +00:00
|
|
|
#ifdef DLA_FMS
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
# define EMULV(x, y, z, zz) \
|
2013-10-17 14:03:24 +00:00
|
|
|
z = x * y; zz = DLA_FMS (x, y, z);
|
2011-10-22 23:02:20 +00:00
|
|
|
#else
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
# define EMULV(x, y, z, zz) \
|
|
|
|
({ __typeof__ (x) __p, hx, tx, hy, ty; \
|
|
|
|
__p = CN * (x); hx = ((x) - __p) + __p; tx = (x) - hx; \
|
|
|
|
__p = CN * (y); hy = ((y) - __p) + __p; ty = (y) - hy; \
|
|
|
|
z = (x) * (y); zz = (((hx * hy - z) + hx * ty) + tx * hy) + tx * ty; \
|
|
|
|
})
|
2011-10-22 23:02:20 +00:00
|
|
|
#endif
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Exact multiplication of two single-length floating point numbers, Dekker. */
|
|
|
|
/* The macro produces a nearly double-length number (z,zz) (see Dekker) */
|
|
|
|
/* that satisfies z+zz = x*y exactly. p,hx,tx,hy,ty,q are temporary */
|
|
|
|
/* storage variables of type double. */
|
|
|
|
|
2011-10-23 17:31:01 +00:00
|
|
|
#ifdef DLA_FMS
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
# define MUL12(x, y, z, zz) \
|
|
|
|
EMULV(x, y, z, zz)
|
2011-10-22 23:02:20 +00:00
|
|
|
#else
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
# define MUL12(x, y, z, zz) \
|
|
|
|
({ __typeof__ (x) __p, hx, tx, hy, ty, __q; \
|
|
|
|
__p=CN*(x); hx=((x)-__p)+__p; tx=(x)-hx; \
|
|
|
|
__p=CN*(y); hy=((y)-__p)+__p; ty=(y)-hy; \
|
|
|
|
__p=hx*hy; __q=hx*ty+tx*hy; z=__p+__q; zz=((__p-z)+__q)+tx*ty; \
|
|
|
|
})
|
2011-10-22 23:02:20 +00:00
|
|
|
#endif
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length addition, Dekker. The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = x+xx + y+yy. */
|
|
|
|
/* An error bound: (abs(x+xx)+abs(y+yy))*4.94e-32. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. r,s are temporary */
|
|
|
|
/* storage variables of type double. */
|
|
|
|
|
2013-10-17 14:03:24 +00:00
|
|
|
#define ADD2(x, xx, y, yy, z, zz, r, s) \
|
2015-05-15 10:53:55 +00:00
|
|
|
r = (x) + (y); s = (fabs (x) > fabs (y)) ? \
|
2013-10-17 14:03:24 +00:00
|
|
|
(((((x) - r) + (y)) + (yy)) + (xx)) : \
|
|
|
|
(((((y) - r) + (x)) + (xx)) + (yy)); \
|
|
|
|
z = r + s; zz = (r - z) + s;
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length subtraction, Dekker. The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = x+xx - (y+yy). */
|
|
|
|
/* An error bound: (abs(x+xx)+abs(y+yy))*4.94e-32. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. r,s are temporary */
|
|
|
|
/* storage variables of type double. */
|
|
|
|
|
2013-10-17 14:03:24 +00:00
|
|
|
#define SUB2(x, xx, y, yy, z, zz, r, s) \
|
2015-05-15 10:53:55 +00:00
|
|
|
r = (x) - (y); s = (fabs (x) > fabs (y)) ? \
|
2013-10-17 14:03:24 +00:00
|
|
|
(((((x) - r) - (y)) - (yy)) + (xx)) : \
|
|
|
|
((((x) - ((y) + r)) + (xx)) - (yy)); \
|
|
|
|
z = r + s; zz = (r - z) + s;
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length multiplication, Dekker. The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = (x+xx)*(y+yy). */
|
|
|
|
/* An error bound: abs((x+xx)*(y+yy))*1.24e-31. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. p,hx,tx,hy,ty,q,c,cc are */
|
|
|
|
/* temporary storage variables of type double. */
|
|
|
|
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
#define MUL2(x, xx, y, yy, z, zz, c, cc) \
|
|
|
|
MUL12 (x, y, c, cc); \
|
2013-10-17 14:03:24 +00:00
|
|
|
cc = ((x) * (yy) + (xx) * (y)) + cc; z = c + cc; zz = (c - z) + cc;
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length division, Dekker. The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = (x+xx)/(y+yy). */
|
|
|
|
/* An error bound: abs((x+xx)/(y+yy))*1.50e-31. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. p,hx,tx,hy,ty,q,c,cc,u,uu */
|
|
|
|
/* are temporary storage variables of type double. */
|
|
|
|
|
ieee754/dbl-64: Reduce the scope of temporary storage variables
This came to light when adding hard-flaot support to ARC glibc port
without hardware sqrt support causing glibc build to fail:
| ../sysdeps/ieee754/dbl-64/e_sqrt.c: In function '__ieee754_sqrt':
| ../sysdeps/ieee754/dbl-64/e_sqrt.c:58:54: error: unused variable 'ty' [-Werror=unused-variable]
| double y, t, del, res, res1, hy, z, zz, p, hx, tx, ty, s;
The reason being EMULV() macro uses the hardware provided
__builtin_fma() variant, leaving temporary variables 'p, hx, tx, hy, ty'
unused hence compiler warning and ensuing error.
The intent of the patch was to fix that error, but EMULV is pervasive
and used fair bit indirectly via othe rmacros, hence this patch.
Functionally it should not result in code gen changes and if at all
those would be better since the scope of those temporaries is greatly
reduced now
Built tested with aarch64-linux-gnu arm-linux-gnueabi arm-linux-gnueabihf hppa-linux-gnu x86_64-linux-gnu arm-linux-gnueabihf riscv64-linux-gnu-rv64imac-lp64 riscv64-linux-gnu-rv64imafdc-lp64 powerpc-linux-gnu microblaze-linux-gnu nios2-linux-gnu hppa-linux-gnu
Also as suggested by Joseph [1] used --strip and compared the libs with
and w/o patch and they are byte-for-byte unchanged (with gcc 9).
| for i in `find . -name libm-2.31.9000.so`;
| do
| echo $i; diff $i /SCRATCH/vgupta/gnu2/install/glibcs/$i ; echo $?;
| done
| ./aarch64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabi/lib/libm-2.31.9000.so
| 0
| ./x86_64-linux-gnu/lib64/libm-2.31.9000.so
| 0
| ./arm-linux-gnueabihf/lib/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imac-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./riscv64-linux-gnu-rv64imafdc-lp64/lib64/lp64/libm-2.31.9000.so
| 0
| ./powerpc-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./microblaze-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./nios2-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./hppa-linux-gnu/lib/libm-2.31.9000.so
| 0
| ./s390x-linux-gnu/lib64/libm-2.31.9000.so
[1] https://sourceware.org/pipermail/libc-alpha/2019-November/108267.html
2019-11-08 19:32:00 +00:00
|
|
|
#define DIV2(x, xx, y, yy, z, zz, c, cc, u, uu) \
|
|
|
|
c=(x)/(y); MUL12(c,y,u,uu); \
|
2011-10-22 23:02:20 +00:00
|
|
|
cc=(((((x)-u)-uu)+(xx))-c*(yy))/(y); z=c+cc; zz=(c-z)+cc;
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length addition, slower but more accurate than ADD2. */
|
|
|
|
/* The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = (x+xx)+(y+yy). */
|
|
|
|
/* An error bound: abs(x+xx + y+yy)*1.50e-31. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. r,rr,s,ss,u,uu,w */
|
|
|
|
/* are temporary storage variables of type double. */
|
|
|
|
|
2013-10-17 14:03:24 +00:00
|
|
|
#define ADD2A(x, xx, y, yy, z, zz, r, rr, s, ss, u, uu, w) \
|
|
|
|
r = (x) + (y); \
|
2015-05-15 10:53:55 +00:00
|
|
|
if (fabs (x) > fabs (y)) { rr = ((x) - r) + (y); s = (rr + (yy)) + (xx); } \
|
2013-10-17 14:03:24 +00:00
|
|
|
else { rr = ((y) - r) + (x); s = (rr + (xx)) + (yy); } \
|
|
|
|
if (rr != 0.0) { \
|
|
|
|
z = r + s; zz = (r - z) + s; } \
|
|
|
|
else { \
|
2015-05-15 10:53:55 +00:00
|
|
|
ss = (fabs (xx) > fabs (yy)) ? (((xx) - s) + (yy)) : (((yy) - s) + (xx));\
|
2013-10-17 14:03:24 +00:00
|
|
|
u = r + s; \
|
2015-05-15 10:53:55 +00:00
|
|
|
uu = (fabs (r) > fabs (s)) ? ((r - u) + s) : ((s - u) + r); \
|
2013-10-17 14:03:24 +00:00
|
|
|
w = uu + ss; z = u + w; \
|
2015-05-15 10:53:55 +00:00
|
|
|
zz = (fabs (u) > fabs (w)) ? ((u - z) + w) : ((w - z) + u); }
|
2001-03-12 00:04:52 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* Double-length subtraction, slower but more accurate than SUB2. */
|
|
|
|
/* The macro produces a double-length */
|
|
|
|
/* number (z,zz) which satisfies approximately z+zz = (x+xx)-(y+yy). */
|
|
|
|
/* An error bound: abs(x+xx - (y+yy))*1.50e-31. (x,xx), (y,yy) */
|
|
|
|
/* are assumed to be double-length numbers. r,rr,s,ss,u,uu,w */
|
|
|
|
/* are temporary storage variables of type double. */
|
|
|
|
|
2013-10-17 14:03:24 +00:00
|
|
|
#define SUB2A(x, xx, y, yy, z, zz, r, rr, s, ss, u, uu, w) \
|
|
|
|
r = (x) - (y); \
|
2015-05-15 10:53:55 +00:00
|
|
|
if (fabs (x) > fabs (y)) { rr = ((x) - r) - (y); s = (rr - (yy)) + (xx); } \
|
2013-10-17 14:03:24 +00:00
|
|
|
else { rr = (x) - ((y) + r); s = (rr + (xx)) - (yy); } \
|
|
|
|
if (rr != 0.0) { \
|
|
|
|
z = r + s; zz = (r - z) + s; } \
|
|
|
|
else { \
|
2015-05-15 10:53:55 +00:00
|
|
|
ss = (fabs (xx) > fabs (yy)) ? (((xx) - s) - (yy)) : ((xx) - ((yy) + s)); \
|
2013-10-17 14:03:24 +00:00
|
|
|
u = r + s; \
|
2015-05-15 10:53:55 +00:00
|
|
|
uu = (fabs (r) > fabs (s)) ? ((r - u) + s) : ((s - u) + r); \
|
2013-10-17 14:03:24 +00:00
|
|
|
w = uu + ss; z = u + w; \
|
2015-05-15 10:53:55 +00:00
|
|
|
zz = (fabs (u) > fabs (w)) ? ((u - z) + w) : ((w - z) + u); }
|