AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-04 19:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
5c46e6b666
glibc/stdlib/tst-stdc_count_ones.c

89 lines
2.7 KiB
C
Raw Normal View History

Implement C23 <stdbit.h> C23 adds a header <stdbit.h> with various functions and type-generic macros for bit-manipulation of unsigned integers (plus macro defines related to endianness). Implement this header for glibc. The functions have both inline definitions in the header (referenced by macros defined in the header) and copies with external linkage in the library (which are implemented in terms of those macros to avoid duplication). They are documented in the glibc manual. Tests, as well as verifying results for various inputs (of both the macros and the out-of-line functions), verify the types of those results (which showed up a bug in an earlier version with the type-generic macro stdc_has_single_bit wrongly returning a promoted type), that the macros can be used at top level in a source file (so don't use ({})), that they evaluate their arguments exactly once, and that the macros for the type-specific functions have the expected implicit conversions to the relevant argument type. Jakub previously referred to -Wconversion warnings in type-generic macros, so I've included a test with -Wconversion (but the only warnings I saw and fixed from that test were actually in inline functions in the <stdbit.h> header - not anything coming from use of the type-generic macros themselves). This implementation of the type-generic macros does not handle unsigned __int128, or unsigned _BitInt types with a width other than that of a standard integer type (and C23 doesn't require the header to handle such types either). Support for those types, using the new type-generic built-in functions Jakub's added for GCC 14, can reasonably be added in a followup (along of course with associated tests). This implementation doesn't do anything special to handle C++, or have any tests of functionality in C++ beyond the existing tests that all headers can be compiled in C++ code; it's not clear exactly what form this header should take in C++, but probably not one using macros. DIS ballot comment AT-107 asks for the word "count" to be added to the names of the stdc_leading_zeros, stdc_leading_ones, stdc_trailing_zeros and stdc_trailing_ones functions and macros. I don't think it's likely to be accepted (accepting any technical comments would mean having an FDIS ballot), but if it is accepted at the WG14 meeting (22-26 January in Strasbourg, starting with DIS ballot comment handling) then there would still be time to update glibc for the renaming before the 2.39 release. The new functions and header are placed in the stdlib/ directory in glibc, rather than creating a new toplevel stdbit/ or putting them in string/ alongside ffs. Tested for x86_64 and x86.
2024-01-03 12:07:14 +00:00
/* Test stdc_count_ones functions and macros.
Copyright (C) 2024 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <tst-stdbit.h>
static const struct stdbit_test inputs[] =
{
{ 0ULL, 0, 0, 0, 0 },
{ 0x1ULL, 1, 1, 1, 1 },
{ 0x2ULL, 1, 1, 1, 1 },
{ 0x3ULL, 2, 2, 2, 2 },
{ 0x4ULL, 1, 1, 1, 1 },
{ 0x5ULL, 2, 2, 2, 2 },
{ 0x6ULL, 2, 2, 2, 2 },
{ 0x7ULL, 3, 3, 3, 3 },
{ 0x8ULL, 1, 1, 1, 1 },
{ 0x9ULL, 2, 2, 2, 2 },
{ 0xaULL, 2, 2, 2, 2 },
{ 0xbULL, 3, 3, 3, 3 },
{ 0xcULL, 2, 2, 2, 2 },
{ 0xdULL, 3, 3, 3, 3 },
{ 0xeULL, 3, 3, 3, 3 },
{ 0xfULL, 4, 4, 4, 4 },
{ 0x10ULL, 1, 1, 1, 1 },
{ 0x11ULL, 2, 2, 2, 2 },
{ 0x12ULL, 2, 2, 2, 2 },
{ 0x1fULL, 5, 5, 5, 5 },
{ 0x20ULL, 1, 1, 1, 1 },
{ 0x7fULL, 7, 7, 7, 7 },
{ 0x80ULL, 1, 1, 1, 1 },
{ 0x81ULL, 2, 2, 2, 2 },
{ 0x9aULL, 4, 4, 4, 4 },
{ 0xf3ULL, 6, 6, 6, 6 },
{ 0xffULL, 8, 8, 8, 8 },
{ 0x100ULL, 0, 1, 1, 1 },
{ 0x101ULL, 1, 2, 2, 2 },
{ 0x102ULL, 1, 2, 2, 2 },
{ 0x1feULL, 7, 8, 8, 8 },
{ 0x1ffULL, 8, 9, 9, 9 },
{ 0x200ULL, 0, 1, 1, 1 },
{ 0x234ULL, 3, 4, 4, 4 },
{ 0x4567ULL, 5, 8, 8, 8 },
{ 0x7fffULL, 8, 15, 15, 15 },
{ 0x8000ULL, 0, 1, 1, 1 },
{ 0x8001ULL, 1, 2, 2, 2 },
{ 0xfffeULL, 7, 15, 15, 15 },
{ 0xffffULL, 8, 16, 16, 16 },
{ 0x10000ULL, 0, 0, 1, 1 },
{ 0x10001ULL, 1, 1, 2, 2 },
{ 0xfedcba98ULL, 3, 8, 20, 20 },
{ 0xfffffefeULL, 7, 14, 30, 30 },
{ 0xffffffffULL, 8, 16, 32, 32 },
{ 0x100000000ULL, 0, 0, 0, 1 },
{ 0x100000001ULL, 1, 1, 1, 2 },
{ 0x123456789ULL, 3, 8, 14, 15 },
{ 0x123456789abcdefULL, 7, 12, 20, 32 },
{ 0x789abcdef0123456ULL, 4, 7, 13, 32 },
{ 0x8000000000000000ULL, 0, 0, 0, 1 },
{ 0x8000000000000001ULL, 1, 1, 1, 2 },
{ 0xfffffffffffffffeULL, 7, 15, 31, 63 },
{ 0xffffffffffffffffULL, 8, 16, 32, 64 },
};
TEST_STDBIT_UI_TOPLEVEL (stdc_count_ones);
static int
do_test (void)
{
TEST_STDBIT_UI (stdc_count_ones, inputs);
return 0;
}
#include <support/test-driver.c>
Reference in New Issue Copy Permalink