2019-01-01 00:11:28 +00:00
|
|
|
/* Copyright (C) 2012-2019 Free Software Foundation, Inc.
|
2012-07-25 17:46:22 +00:00
|
|
|
This file is part of the GNU C Library.
|
|
|
|
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
|
|
modify it under the terms of the GNU Lesser General Public
|
|
|
|
License as published by the Free Software Foundation; either
|
|
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
Lesser General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
|
|
License along with the GNU C Library; if not, see
|
|
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
/* Test that secure_getenv works by invoking the test as a SGID
|
|
|
|
program with a group ID from the supplementary group list. This
|
|
|
|
test can fail spuriously if the user is not a member of a suitable
|
2012-09-04 13:01:18 +00:00
|
|
|
supplementary group. */
|
2012-07-25 17:46:22 +00:00
|
|
|
|
|
|
|
#include <errno.h>
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <sys/stat.h>
|
|
|
|
#include <sys/wait.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
|
2016-12-09 07:18:27 +00:00
|
|
|
#include <support/support.h>
|
|
|
|
#include <support/test-driver.h>
|
|
|
|
|
2012-07-25 17:46:22 +00:00
|
|
|
static char MAGIC_ARGUMENT[] = "run-actual-test";
|
|
|
|
#define MAGIC_STATUS 19
|
|
|
|
|
|
|
|
/* Return a GID which is not our current GID, but is present in the
|
2012-09-04 13:01:18 +00:00
|
|
|
supplementary group list. */
|
2012-07-25 17:46:22 +00:00
|
|
|
static gid_t
|
|
|
|
choose_gid (void)
|
|
|
|
{
|
2019-04-17 09:45:34 +00:00
|
|
|
int count = getgroups (0, NULL);
|
|
|
|
if (count < 0)
|
|
|
|
{
|
|
|
|
printf ("getgroups: %m\n");
|
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
gid_t *groups;
|
|
|
|
groups = xcalloc (count, sizeof (*groups));
|
2012-07-25 17:46:22 +00:00
|
|
|
int ret = getgroups (count, groups);
|
|
|
|
if (ret < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("getgroups: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
gid_t current = getgid ();
|
2019-04-17 09:45:34 +00:00
|
|
|
gid_t not_current = 0;
|
2012-07-25 17:46:22 +00:00
|
|
|
for (int i = 0; i < ret; ++i)
|
|
|
|
{
|
|
|
|
if (groups[i] != current)
|
2019-04-17 09:45:34 +00:00
|
|
|
{
|
|
|
|
not_current = groups[i];
|
|
|
|
break;
|
|
|
|
}
|
2012-07-25 17:46:22 +00:00
|
|
|
}
|
2019-04-17 09:45:34 +00:00
|
|
|
free (groups);
|
|
|
|
return not_current;
|
2012-07-25 17:46:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* Copies the executable into a restricted directory, so that we can
|
|
|
|
safely make it SGID with the TARGET group ID. Then runs the
|
2012-09-04 13:01:18 +00:00
|
|
|
executable. */
|
2012-07-25 17:46:22 +00:00
|
|
|
static int
|
|
|
|
run_executable_sgid (gid_t target)
|
|
|
|
{
|
2016-12-09 07:18:27 +00:00
|
|
|
char *dirname = xasprintf ("%s/secure-getenv.%jd",
|
|
|
|
test_dir, (intmax_t) getpid ());
|
|
|
|
char *execname = xasprintf ("%s/bin", dirname);
|
2012-07-25 17:46:22 +00:00
|
|
|
int infd = -1;
|
|
|
|
int outfd = -1;
|
|
|
|
int ret = -1;
|
|
|
|
if (mkdir (dirname, 0700) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("mkdir: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
infd = open ("/proc/self/exe", O_RDONLY);
|
|
|
|
if (infd < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("open (/proc/self/exe): %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
outfd = open (execname, O_WRONLY | O_CREAT | O_EXCL, 0700);
|
|
|
|
if (outfd < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("open (%s): %m\n", execname);
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
char buf[4096];
|
|
|
|
for (;;)
|
|
|
|
{
|
|
|
|
ssize_t rdcount = read (infd, buf, sizeof (buf));
|
|
|
|
if (rdcount < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("read: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (rdcount == 0)
|
|
|
|
break;
|
|
|
|
char *p = buf;
|
|
|
|
char *end = buf + rdcount;
|
|
|
|
while (p != end)
|
|
|
|
{
|
|
|
|
ssize_t wrcount = write (outfd, buf, end - p);
|
|
|
|
if (wrcount == 0)
|
|
|
|
errno = ENOSPC;
|
|
|
|
if (wrcount <= 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("write: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
p += wrcount;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (fchown (outfd, getuid (), target) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("fchown (%s): %m\n", execname);
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (fchmod (outfd, 02750) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("fchmod (%s): %m\n", execname);
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (close (outfd) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("close (outfd): %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (close (infd) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("close (infd): %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
int kid = fork ();
|
|
|
|
if (kid < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("fork: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (kid == 0)
|
|
|
|
{
|
2012-09-04 13:01:18 +00:00
|
|
|
/* Child process. */
|
2012-07-25 17:46:22 +00:00
|
|
|
char *args[] = { execname, MAGIC_ARGUMENT, NULL };
|
|
|
|
execve (execname, args, environ);
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("execve (%s): %m\n", execname);
|
2012-07-25 17:46:22 +00:00
|
|
|
_exit (1);
|
|
|
|
}
|
|
|
|
int status;
|
|
|
|
if (waitpid (kid, &status, 0) < 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("waitpid: %m\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
if (!WIFEXITED (status) || WEXITSTATUS (status) != MAGIC_STATUS)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("Unexpected exit status %d from child process\n",
|
|
|
|
status);
|
2012-07-25 17:46:22 +00:00
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
err:
|
|
|
|
if (outfd >= 0)
|
|
|
|
close (outfd);
|
|
|
|
if (infd >= 0)
|
|
|
|
close (infd);
|
|
|
|
if (execname)
|
|
|
|
{
|
|
|
|
unlink (execname);
|
|
|
|
free (execname);
|
|
|
|
}
|
|
|
|
if (dirname)
|
|
|
|
{
|
|
|
|
rmdir (dirname);
|
|
|
|
free (dirname);
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
do_test (void)
|
|
|
|
{
|
|
|
|
if (getenv ("PATH") == NULL)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("PATH not set\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
if (secure_getenv ("PATH") == NULL)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("PATH not set according to secure_getenv\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
if (strcmp (getenv ("PATH"), secure_getenv ("PATH")) != 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("PATH mismatch (%s, %s)\n",
|
|
|
|
getenv ("PATH"), secure_getenv ("PATH"));
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (1);
|
|
|
|
}
|
|
|
|
|
|
|
|
gid_t target = choose_gid ();
|
|
|
|
if (target == 0)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
fprintf (stderr,
|
|
|
|
"Could not find a suitable GID for user %jd, skipping test\n",
|
2012-07-25 17:46:22 +00:00
|
|
|
(intmax_t) getuid ());
|
2012-07-31 07:55:38 +00:00
|
|
|
exit (0);
|
2012-07-25 17:46:22 +00:00
|
|
|
}
|
|
|
|
return run_executable_sgid (target);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
alternative_main (int argc, char **argv)
|
|
|
|
{
|
|
|
|
if (argc == 2 && strcmp (argv[1], MAGIC_ARGUMENT) == 0)
|
|
|
|
{
|
|
|
|
if (getgid () == getegid ())
|
|
|
|
{
|
2012-09-04 13:01:18 +00:00
|
|
|
/* This can happen if the file system is mounted nosuid. */
|
2012-09-04 07:25:18 +00:00
|
|
|
fprintf (stderr, "SGID failed: GID and EGID match (%jd)\n",
|
2012-07-31 07:55:38 +00:00
|
|
|
(intmax_t) getgid ());
|
2012-09-04 07:25:18 +00:00
|
|
|
exit (MAGIC_STATUS);
|
2012-07-25 17:46:22 +00:00
|
|
|
}
|
|
|
|
if (getenv ("PATH") == NULL)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("PATH variable not present\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (3);
|
|
|
|
}
|
|
|
|
if (secure_getenv ("PATH") != NULL)
|
|
|
|
{
|
2012-07-31 07:55:38 +00:00
|
|
|
printf ("PATH variable not filtered out\n");
|
2012-07-25 17:46:22 +00:00
|
|
|
exit (4);
|
|
|
|
}
|
|
|
|
exit (MAGIC_STATUS);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-09 07:18:27 +00:00
|
|
|
#define PREPARE alternative_main
|
|
|
|
#include <support/test-driver.c>
|