Reinstate gconv-modules as the default configuration file

Reinstate gconv-modules as the main file so that the configuration
files in gconv-modules.d/ become add-on configuration.  With this, the
effective user visible change is that GCONV_PATH can now have
supplementary configuration in GCONV_PATH/gconv-modules.d/ in addition
to the main GCONV_PATH/gconv-modules file.
This commit is contained in:
Siddhesh Poyarekar 2021-06-14 11:09:56 +05:30
parent ebae2f5a6f
commit 06a1b79407
3 changed files with 23 additions and 21 deletions

View File

@ -137,13 +137,12 @@ charmaps = ../localedata/charmaps
extra-modules-left := $(modules) extra-modules-left := $(modules)
include extra-module.mk include extra-module.mk
gconv-modules = gconv-modules.conf gconv-modules-extra.conf gconv-modules = gconv-modules gconv-modules.d/gconv-modules-extra.conf
modpfx = $(objpfx)gconv-modules.d/ modpfx = $(objpfx)gconv-modules.d/
extra-objs += $(modules.so) extra-objs += $(modules.so)
install-others = $(addprefix $(inst_gconvdir)/, $(modules.so)) \ install-others = $(addprefix $(inst_gconvdir)/, $(modules.so)) \
$(addprefix $(inst_gconvdir)/gconv-modules.d/, \ $(addprefix $(inst_gconvdir)/, $(gconv-modules))
$(gconv-modules))
# We can build the conversion tables for numerous charsets automatically. # We can build the conversion tables for numerous charsets automatically.
@ -185,7 +184,7 @@ generated += $(generated-modules:=.h) $(generated-modules:=.stmp) \
iconv-test.out iconv-rules tst-loading.mtrace \ iconv-test.out iconv-rules tst-loading.mtrace \
mtrace-tst-loading.out tst-tables.out iconv-test.xxx mtrace-tst-loading.out tst-tables.out iconv-test.xxx
ifdef objpfx ifdef objpfx
generated += $(addprefix gconv-modules.d/,$(gconv-modules)) generated += $(gconv-modules)
endif endif
# Rules to generate the headers. # Rules to generate the headers.
@ -253,8 +252,8 @@ headers: $(addprefix $(objpfx), $(generated-modules:=.h))
$(addprefix $(inst_gconvdir)/, $(modules.so)): \ $(addprefix $(inst_gconvdir)/, $(modules.so)): \
$(inst_gconvdir)/%: $(objpfx)% $(+force) $(inst_gconvdir)/%: $(objpfx)% $(+force)
$(do-install-program) $(do-install-program)
$(addprefix $(inst_gconvdir)/gconv-modules.d/, $(gconv-modules)): \ $(addprefix $(inst_gconvdir)/, $(gconv-modules)): \
$(inst_gconvdir)/gconv-modules.d/%: $(modpfx)% $(+force) $(inst_gconvdir)/%: $(objpfx)% $(+force)
$(do-install) $(do-install)
ifeq (no,$(cross-compiling)) ifeq (no,$(cross-compiling))
# Update the $(prefix)/lib/gconv/gconv-modules.cache file. This is necessary # Update the $(prefix)/lib/gconv/gconv-modules.cache file. This is necessary
@ -307,29 +306,29 @@ $(objpfx)mtrace-tst-loading.out: $(objpfx)tst-loading.out
$(common-objpfx)malloc/mtrace $(objpfx)tst-loading.mtrace > $@; \ $(common-objpfx)malloc/mtrace $(objpfx)tst-loading.mtrace > $@; \
$(evaluate-test) $(evaluate-test)
$(objpfx)bug-iconv1.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv1.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv2.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv2.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv3.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv3.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv5.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv5.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)tst-loading.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)tst-loading.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)tst-iconv4.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)tst-iconv4.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)tst-iconv7.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)tst-iconv7.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv10.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv10.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv12.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv12.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)bug-iconv14.out: $(addprefix $(modpfx), $(gconv-modules)) \ $(objpfx)bug-iconv14.out: $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))
$(objpfx)iconv-test.out: run-iconv-test.sh \ $(objpfx)iconv-test.out: run-iconv-test.sh \
$(addprefix $(modpfx), $(gconv-modules)) \ $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) \ $(addprefix $(objpfx),$(modules.so)) \
$(common-objdir)/iconv/iconv_prog TESTS $(common-objdir)/iconv/iconv_prog TESTS
iconv_modules="$(modules)" \ iconv_modules="$(modules)" \
@ -338,7 +337,7 @@ $(objpfx)iconv-test.out: run-iconv-test.sh \
$(evaluate-test) $(evaluate-test)
$(objpfx)tst-tables.out: tst-tables.sh \ $(objpfx)tst-tables.out: tst-tables.sh \
$(addprefix $(modpfx), $(gconv-modules)) \ $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) \ $(addprefix $(objpfx),$(modules.so)) \
$(objpfx)tst-table-from $(objpfx)tst-table-to $(objpfx)tst-table-from $(objpfx)tst-table-to
$(SHELL) $< $(common-objpfx) $(common-objpfx)iconvdata/ \ $(SHELL) $< $(common-objpfx) $(common-objpfx)iconvdata/ \
@ -357,7 +356,10 @@ $(modpfx):
$(modpfx)%: % $(modpfx) $(modpfx)%: % $(modpfx)
cp $< $@ cp $< $@
$(objpfx)gconv-modules: gconv-modules
cp $^ $@
# Test requires BIG5HKSCS. # Test requires BIG5HKSCS.
$(objpfx)tst-iconv-big5-hkscs-to-2ucs4.out: \ $(objpfx)tst-iconv-big5-hkscs-to-2ucs4.out: \
$(addprefix $(modpfx), $(gconv-modules)) \ $(addprefix $(objpfx), $(gconv-modules)) \
$(addprefix $(objpfx),$(modules.so)) $(addprefix $(objpfx),$(modules.so))

View File

@ -183,7 +183,7 @@ install-others := $(addprefix $(inst_i18ndir)/, \
$(locales)) $(locales))
endif endif
tests: $(objdir)/iconvdata/gconv-modules.d/gconv-modules.conf tests: $(objdir)/iconvdata/gconv-modules
tests-static += tst-langinfo-newlocale-static tst-langinfo-setlocale-static tests-static += tst-langinfo-newlocale-static tst-langinfo-setlocale-static
@ -464,5 +464,5 @@ $(objpfx)mtrace-tst-leaks.out: $(objpfx)tst-leaks.out
bug-setlocale1-ENV-only = LOCPATH=$(objpfx) LC_CTYPE=de_DE.UTF-8 bug-setlocale1-ENV-only = LOCPATH=$(objpfx) LC_CTYPE=de_DE.UTF-8
bug-setlocale1-static-ENV-only = $(bug-setlocale1-ENV-only) bug-setlocale1-static-ENV-only = $(bug-setlocale1-ENV-only)
$(objdir)/iconvdata/gconv-modules.d/gconv-modules.conf: $(objdir)/iconvdata/gconv-modules:
$(MAKE) -C ../iconvdata subdir=iconvdata $@ $(MAKE) -C ../iconvdata subdir=iconvdata $@