AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-21 20:40:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

tst-getpw: Rewrite.

Browse Source 
The test is rewritten to look for the testable conditions and
exit once they are all detected. This prevents the test from
iterating over 2000 UIDs and looking up each one. It speeds up
the test and prevents it from failing if the system under test
has an NSS-based passwd that is slower than the test timeout.

See:
https://sourceware.org/ml/libc-alpha/2015-01/msg00394.html
This commit is contained in:
Carlos O'Donell 2015-01-21 10:08:18 -05:00
parent 86bba162b5
commit 0897c551c0
2 changed files with 79 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog
View File

@ -1,5 +1,7 @@
2015-01-21 Carlos O'Donell <carlos@redhat.com> 2015-01-21 Carlos O'Donell <carlos@redhat.com>
* pwd/tst-getpw.c: Rewrite.
[BZ #17702] [BZ #17702]
* dlfcn/Makefile (tests): Add tst-rec-dlopen. * dlfcn/Makefile (tests): Add tst-rec-dlopen.
(modules-names): Add moddummy1 and moddummy2. (modules-names): Add moddummy1 and moddummy2.

83
pwd/tst-getpw.c
View File

@ -15,28 +15,99 @@
License along with the GNU C Library; if not, see License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */ <http://www.gnu.org/licenses/>. */
#include <stdio.h>
#include <pwd.h> #include <pwd.h>
#include <errno.h>
#include <stdbool.h>
/* We want to test getpw by calling it with a uid that does
exist and one that doesn't exist. We track if we've met those
conditions and exit. We also track if we've failed due to lack
of memory. That constitutes all of the standard failure cases. */
bool seen_hit;
bool seen_miss;
bool seen_oom;
/* How many errors we've had while running the test. */
int errors;
static void static void
check (uid_t uid) check (uid_t uid)
{ {
int ret;
char buf[1024]; char buf[1024];
(void) getpw (uid, buf); ret = getpw (uid, buf);
/* Successfully read a password line. */
if (ret == 0 && !seen_hit)
{
printf ("PASS: Read a password line given a uid.\n");
seen_hit = true;
}
/* Failed to read a password line. Why? */
if (ret == -1)
{
/* No entry? Technically the errno could be any number
of values including ESRCH, EBADP or EPERM depending
on the quality of the nss module that implements the
underlying lookup. It should be 0 for getpw.*/
if (errno == 0 && !seen_miss)
{
printf ("PASS: Found an invalid uid.\n");
seen_miss = true;
return;
}
/* Out of memory? */
if (errno == ENOMEM && !seen_oom)
{
printf ("FAIL: Failed with ENOMEM.\n");
seen_oom = true;
errors++;
}
/* We don't expect any other values for errno. */
if (errno != ENOMEM && errno != 0)
errors++;
}
} }
static int static int
do_test (void) do_test (void)
{ {
int ret;
uid_t uid; uid_t uid;
/* Just call it a different number of times the range should be /* Should return -1 and set errnot to EINVAL. */
large enough to find some existing and some non existing uids. */ ret = getpw (0, NULL);
if (ret == -1 && errno == EINVAL)
{
printf ("PASS: NULL buffer returns -1 and sets errno to EINVAL.\n");
}
else
{
printf ("FAIL: NULL buffer did not return -1 or set errno to EINVAL.\n");
errors++;
}
for (uid = 0; uid < 2000; ++uid) /* Look for one matching uid, one non-found uid and then stop.
check (uid); Set an upper limit at the 16-bit UID mark; no need to go farther. */
for (uid = 0; uid < ((uid_t) 65535); ++uid)
{
check (uid);
if (seen_miss && seen_hit)
break;
}
return 0; if (!seen_hit)
printf ("FAIL: Did not read even one password line given a uid.\n");
if (!seen_miss)
printf ("FAIL: Did not find even one invalid uid.\n");
return errors;
} }
#define TEST_FUNCTION do_test () #define TEST_FUNCTION do_test ()