* sysdeps/generic/memmem.c (memmem): Check arguments to avoid
	possibly searching through the whole memory.
	Closes PR libc/1730, reported by Greg Hudson <ghudson@mit.edu>.
This commit is contained in:
Andreas Jaeger 2000-05-18 05:35:38 +00:00
parent cc3f0ddb75
commit 1261b97d10
2 changed files with 10 additions and 1 deletions

View File

@ -21,6 +21,10 @@
* string/strings.h: Add pure and const attributes if possible.
* sysdeps/generic/memmem.c (memmem): Check arguments to avoid
possibly searching through the whole memory.
Closes PR libc/1730, reported by Greg Hudson <ghudson@mit.edu>.
2000-05-17 Jakub Jelinek <jakub@redhat.com>
* sysdeps/generic/dl-cache.h (_DL_CACHE_DEFAULT_ID): Only define if

View File

@ -1,4 +1,4 @@
/* Copyright (C) 1991, 92, 93, 94, 96, 97, 98 Free Software Foundation, Inc.
/* Copyright (C) 1991,92,93,94,96,97,98,2000 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@ -38,6 +38,11 @@ memmem (haystack, haystack_len, needle, needle_len)
the beginning of the string. */
return (void *) haystack;
/* Sanity check, otherwise the loop might search through the whole
memory. */
if (__builtin_expect (haystack_len < needle_len, 0))
return NULL;
for (begin = (const char *) haystack; begin <= last_possible; ++begin)
if (begin[0] == ((const char *) needle)[0] &&
!memcmp ((const void *) &begin[1],