Use <startup.h> in __libc_init_secure

Since __libc_init_secure is called before ARCH_SETUP_TLS, it must use
"int $0x80" for system calls in i386 static PIE.  Add startup_getuid,
startup_geteuid, startup_getgid and startup_getegid to <startup.h>.
Update __libc_init_secure to use them.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
This commit is contained in:
H.J. Lu 2021-01-15 06:46:12 -08:00
parent cabc8a2916
commit 22b79ed7f4
3 changed files with 56 additions and 5 deletions

View File

@ -19,7 +19,7 @@
/* This file is used in the static libc. For the shared library, /* This file is used in the static libc. For the shared library,
dl-sysdep.c defines and initializes __libc_enable_secure. */ dl-sysdep.c defines and initializes __libc_enable_secure. */
#include <unistd.h> #include <startup.h>
#include <libc-internal.h> #include <libc-internal.h>
/* If nonzero __libc_enable_secure is already set. */ /* If nonzero __libc_enable_secure is already set. */
@ -31,6 +31,6 @@ void
__libc_init_secure (void) __libc_init_secure (void)
{ {
if (__libc_enable_secure_decided == 0) if (__libc_enable_secure_decided == 0)
__libc_enable_secure = (__geteuid () != __getuid () __libc_enable_secure = (startup_geteuid () != startup_getuid ()
|| __getegid () != __getgid ()); || startup_getegid () != startup_getgid ());
} }

View File

@ -19,5 +19,31 @@
/* Targets should override this file if the default definitions below /* Targets should override this file if the default definitions below
will not work correctly very early before TLS is initialized. */ will not work correctly very early before TLS is initialized. */
#include <unistd.h>
/* Use macro instead of inline function to avoid including <stdio.h>. */ /* Use macro instead of inline function to avoid including <stdio.h>. */
#define _startup_fatal(message) __libc_fatal ((message)) #define _startup_fatal(message) __libc_fatal ((message))
static inline uid_t
startup_getuid (void)
{
return __getuid ();
}
static inline uid_t
startup_geteuid (void)
{
return __geteuid ();
}
static inline gid_t
startup_getgid (void)
{
return __getgid ();
}
static inline gid_t
startup_getegid (void)
{
return __getegid ();
}

View File

@ -17,11 +17,12 @@
<https://www.gnu.org/licenses/>. */ <https://www.gnu.org/licenses/>. */
#if BUILD_PIE_DEFAULT #if BUILD_PIE_DEFAULT
# include <abort-instr.h>
/* Can't use "call *%gs:SYSINFO_OFFSET" during statup in static PIE. */ /* Can't use "call *%gs:SYSINFO_OFFSET" during statup in static PIE. */
# define I386_USE_SYSENTER 0 # define I386_USE_SYSENTER 0
# include <sysdep.h>
# include <abort-instr.h>
__attribute__ ((__noreturn__)) __attribute__ ((__noreturn__))
static inline void static inline void
_startup_fatal (const char *message __attribute__ ((unused))) _startup_fatal (const char *message __attribute__ ((unused)))
@ -31,6 +32,30 @@ _startup_fatal (const char *message __attribute__ ((unused)))
ABORT_INSTRUCTION; ABORT_INSTRUCTION;
__builtin_unreachable (); __builtin_unreachable ();
} }
static inline uid_t
startup_getuid (void)
{
return (uid_t) INTERNAL_SYSCALL_CALL (getuid32);
}
static inline uid_t
startup_geteuid (void)
{
return (uid_t) INTERNAL_SYSCALL_CALL (geteuid32);
}
static inline gid_t
startup_getgid (void)
{
return (gid_t) INTERNAL_SYSCALL_CALL (getgid32);
}
static inline gid_t
startup_getegid (void)
{
return (gid_t) INTERNAL_SYSCALL_CALL (getegid32);
}
#else #else
# include_next <startup.h> # include_next <startup.h>
#endif #endif