Filter out PTHREAD_MUTEX_NO_ELISION_NP bit in pthread_mutexattr_gettype (BZ #15790)

pthread_mutexattr_settype adds PTHREAD_MUTEX_NO_ELISION_NP to kind,
which is an internal flag that pthread_mutexattr_gettype shouldn't
expose, since pthread_mutexattr_settype wouldn't accept it.
This commit is contained in:
Andreas Schwab 2014-08-11 11:18:26 +02:00
parent ebf27d12e6
commit 2868e0703d
5 changed files with 72 additions and 3 deletions

View File

@ -1,3 +1,11 @@
2015-02-12 Andreas Schwab <schwab@suse.de>
[BZ #15790]
* nptl/pthread_mutexattr_gettype.c (pthread_mutexattr_gettype):
Filter out elision flags from value returned in kind.
* nptl/Makefile (tests): Add tst-pthread-mutexattr.
* nptl/tst-pthread-mutexattr.c: New file.
2015-02-11 Samuel Thibault <samuel.thibault@ens-lyon.org> 2015-02-11 Samuel Thibault <samuel.thibault@ens-lyon.org>
* abi-tags: Revert ae20c9a: rename back gnu into gnu-gnu. * abi-tags: Revert ae20c9a: rename back gnu into gnu-gnu.

2
NEWS
View File

@ -9,7 +9,7 @@ Version 2.22
* The following bugs are resolved with this release: * The following bugs are resolved with this release:
4719, 15467, 17912, 17932, 17944, 17949. 4719, 15467, 15790, 17912, 17932, 17944, 17949.
Version 2.21 Version 2.21

View File

@ -256,7 +256,7 @@ tests = tst-typesizes \
tst-exit1 tst-exit2 tst-exit3 \ tst-exit1 tst-exit2 tst-exit3 \
tst-stdio1 tst-stdio2 \ tst-stdio1 tst-stdio2 \
tst-stack1 tst-stack2 tst-stack3 tst-stack4 tst-pthread-getattr \ tst-stack1 tst-stack2 tst-stack3 tst-stack4 tst-pthread-getattr \
tst-pthread-attr-affinity \ tst-pthread-attr-affinity tst-pthread-mutexattr \
tst-unload \ tst-unload \
tst-dlsym1 \ tst-dlsym1 \
tst-sysconf \ tst-sysconf \

View File

@ -28,7 +28,8 @@ pthread_mutexattr_gettype (attr, kind)
iattr = (const struct pthread_mutexattr *) attr; iattr = (const struct pthread_mutexattr *) attr;
*kind = iattr->mutexkind & ~PTHREAD_MUTEXATTR_FLAG_BITS; *kind = (iattr->mutexkind & ~PTHREAD_MUTEXATTR_FLAG_BITS
& ~PTHREAD_MUTEX_NO_ELISION_NP);
return 0; return 0;
} }

View File

@ -0,0 +1,60 @@
/* Make sure that pthread_mutexattr_gettype returns a valid kind.
Copyright (C) 2015 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#include <stdio.h>
#include <string.h>
#include <pthread.h>
static int
do_test (void)
{
pthread_mutexattr_t attr;
int kind;
int error;
error = pthread_mutexattr_init (&attr);
if (error)
{
printf ("pthread_mutexattr_init: %s\n", strerror (error));
return 1;
}
error = pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_DEFAULT);
if (error)
{
printf ("pthread_mutexattr_settype (1): %s\n", strerror (error));
return 1;
}
error = pthread_mutexattr_gettype (&attr, &kind);
if (error)
{
printf ("pthread_mutexattr_gettype: %s\n", strerror (error));
return 1;
}
error = pthread_mutexattr_settype (&attr, kind);
if (error)
{
printf ("pthread_mutexattr_settype (2): %s\n", strerror (error));
return 1;
}
return 0;
}
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"