From 2a6c922f09e7a1c206e0cbdb4424f1cf101a5bda Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Thu, 20 Jun 2024 14:13:01 +0200 Subject: [PATCH] mtrace: make shell commands robust against meta characters Use the list form of the open function to avoid interpreting meta characters in the arguments. --- malloc/mtrace.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/malloc/mtrace.pl b/malloc/mtrace.pl index 0a631a07bc..32b4da935f 100644 --- a/malloc/mtrace.pl +++ b/malloc/mtrace.pl @@ -87,7 +87,7 @@ if ($#ARGV == 0) { } # Set the environment variable LD_TRACE_LOADED_OBJECTS to 2 so the # executable is also printed. - if (open (locs, "env LD_TRACE_LOADED_OBJECTS=2 $prog |")) { + if (open (locs, "-|", "env", "LD_TRACE_LOADED_OBJECTS=2", $prog)) { while () { chop; if (/^.*=> (.*) .(0x[0123456789abcdef]*).$/) { @@ -104,7 +104,7 @@ if ($#ARGV == 0) { sub addr2line { my $addr = pop(@_); my $prog = pop(@_); - if (open (ADDR, "addr2line -e $prog $addr|")) { + if (open (ADDR, "-|", "addr2line", "-e", $prog, $addr)) { my $line = ; chomp $line; close (ADDR);