mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-24 14:00:30 +00:00
elf: Move __rtld_malloc_init_stubs call into _dl_start_final
Calling an extern function in a different translation unit before self-relocation is brittle. The compiler may load the address at an earlier point in _dl_start, before self-relocation. In _dl_start_final, the call is behind a compiler barrier, so this cannot happen.
This commit is contained in:
parent
9802c0f2fe
commit
2abfa19072
@ -452,6 +452,8 @@ _dl_start_final (void *arg, struct dl_start_final_info *info)
|
||||
{
|
||||
ElfW(Addr) start_addr;
|
||||
|
||||
__rtld_malloc_init_stubs ();
|
||||
|
||||
/* Do not use an initializer for these members because it would
|
||||
interfere with __rtld_static_init. */
|
||||
GLRO (dl_find_object) = &_dl_find_object;
|
||||
@ -574,8 +576,6 @@ _dl_start (void *arg)
|
||||
function, that way the compiler cannot put accesses to the GOT
|
||||
before ELF_DYNAMIC_RELOCATE. */
|
||||
|
||||
__rtld_malloc_init_stubs ();
|
||||
|
||||
#ifdef DONT_USE_BOOTSTRAP_MAP
|
||||
return _dl_start_final (arg);
|
||||
#else
|
||||
|
Loading…
Reference in New Issue
Block a user