AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-29 08:11:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use uint32_t sign in single precision math error handling functions

Browse Source 
Ideally sign should be bool, but sometimes (e.g. in powf) it's more
efficient to pass a non-zero value than 1 to indicate that the sign
should be set.  The fixed size int is less ambigous than unsigned
long.

	* sysdeps/ieee754/flt-32/e_powf.c (__powf): Use uint32_t.
	(exp2f_inline): Likewise.
	* sysdeps/ieee754/flt-32/math_config.h (__math_oflowf): Likewise.
	(__math_uflowf): Likewise.
	(__math_may_uflowf): Likewise.
	(__math_divzerof): Likewise.
	(__math_invalidf): Likewise.
	* sysdeps/ieee754/flt-32/math_errf.c (xflowf): Likewise.
	(__math_oflowf): Likewise.
	(__math_uflowf): Likewise.
	(__math_may_uflowf): Likewise.
	(__math_divzerof): Likewise.
	(__math_invalidf): Likewise.
This commit is contained in:
Szabolcs Nagy 2018-06-13 15:07:21 +01:00
parent 2827ab990a
commit 2b445206a1
4 changed files with 27 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ChangeLog
View File

@ -1,3 +1,19 @@
2018-07-02 Szabolcs Nagy <szabolcs.nagy@arm.com>
* sysdeps/ieee754/flt-32/e_powf.c (__powf): Use uint32_t.
(exp2f_inline): Likewise.
* sysdeps/ieee754/flt-32/math_config.h (__math_oflowf): Likewise.
(__math_uflowf): Likewise.
(__math_may_uflowf): Likewise.
(__math_divzerof): Likewise.
(__math_invalidf): Likewise.
* sysdeps/ieee754/flt-32/math_errf.c (xflowf): Likewise.
(__math_oflowf): Likewise.
(__math_uflowf): Likewise.
(__math_may_uflowf): Likewise.
(__math_divzerof): Likewise.
(__math_invalidf): Likewise.
2018-06-29 DJ Delorie <dj@redhat.com> 2018-06-29 DJ Delorie <dj@redhat.com>
Carlos O'Donell <carlos@redhat.com> Carlos O'Donell <carlos@redhat.com>

4
sysdeps/ieee754/flt-32/e_powf.c
View File

@ -84,7 +84,7 @@ log2_inline (uint32_t ix)
(in case of fast toint intrinsics) or not. The unscaled xd must be (in case of fast toint intrinsics) or not. The unscaled xd must be
in [-1021,1023], sign_bias sets the sign of the result. */ in [-1021,1023], sign_bias sets the sign of the result. */
static inline double_t static inline double_t
exp2_inline (double_t xd, unsigned long sign_bias) exp2_inline (double_t xd, uint32_t sign_bias)
{ {
uint64_t ki, ski, t; uint64_t ki, ski, t;
/* double_t for better performance on targets with FLT_EVAL_METHOD==2. */ /* double_t for better performance on targets with FLT_EVAL_METHOD==2. */
@ -143,7 +143,7 @@ zeroinfnan (uint32_t ix)
float float
__powf (float x, float y) __powf (float x, float y)
{ {
unsigned long sign_bias = 0; uint32_t sign_bias = 0;
uint32_t ix, iy; uint32_t ix, iy;
ix = asuint (x); ix = asuint (x);

8
sysdeps/ieee754/flt-32/math_config.h
View File

@ -102,10 +102,10 @@ issignalingf_inline (float x)
#define NOINLINE __attribute__ ((noinline)) #define NOINLINE __attribute__ ((noinline))
attribute_hidden float __math_oflowf (unsigned long); attribute_hidden float __math_oflowf (uint32_t);
attribute_hidden float __math_uflowf (unsigned long); attribute_hidden float __math_uflowf (uint32_t);
attribute_hidden float __math_may_uflowf (unsigned long); attribute_hidden float __math_may_uflowf (uint32_t);
attribute_hidden float __math_divzerof (unsigned long); attribute_hidden float __math_divzerof (uint32_t);
attribute_hidden float __math_invalidf (float); attribute_hidden float __math_invalidf (float);
/* Shared between expf, exp2f and powf. */ /* Shared between expf, exp2f and powf. */

10
sysdeps/ieee754/flt-32/math_errf.c
View File

@ -33,14 +33,14 @@ with_errnof (float y, int e)
/* NOINLINE prevents fenv semantics breaking optimizations. */ /* NOINLINE prevents fenv semantics breaking optimizations. */
NOINLINE static float NOINLINE static float
xflowf (unsigned long sign, float y) xflowf (uint32_t sign, float y)
{ {
y = (sign ? -y : y) * y; y = (sign ? -y : y) * y;
return with_errnof (y, ERANGE); return with_errnof (y, ERANGE);
} }
attribute_hidden float attribute_hidden float
__math_uflowf (unsigned long sign) __math_uflowf (uint32_t sign)
{ {
return xflowf (sign, 0x1p-95f); return xflowf (sign, 0x1p-95f);
} }
@ -49,20 +49,20 @@ __math_uflowf (unsigned long sign)
/* Underflows to zero in some non-nearest rounding mode, setting errno /* Underflows to zero in some non-nearest rounding mode, setting errno
is valid even if the result is non-zero, but in the subnormal range. */ is valid even if the result is non-zero, but in the subnormal range. */
attribute_hidden float attribute_hidden float
__math_may_uflowf (unsigned long sign) __math_may_uflowf (uint32_t sign)
{ {
return xflowf (sign, 0x1.4p-75f); return xflowf (sign, 0x1.4p-75f);
} }
#endif #endif
attribute_hidden float attribute_hidden float
__math_oflowf (unsigned long sign) __math_oflowf (uint32_t sign)
{ {
return xflowf (sign, 0x1p97f); return xflowf (sign, 0x1p97f);
} }
attribute_hidden float attribute_hidden float
__math_divzerof (unsigned long sign) __math_divzerof (uint32_t sign)
{ {
float y = 0; float y = 0;
return with_errnof ((sign ? -1 : 1) / y, ERANGE); return with_errnof ((sign ? -1 : 1) / y, ERANGE);