2001-11-28  Ulrich Drepper  <drepper@redhat.com>

	* nss/nss_files/files-XXX.c (internal_getent): Correct input
	overflow test for platforms with signed char.
	Reported by Andrew Haley <aph@cambridge.redhat.com>.
This commit is contained in:
Ulrich Drepper 2001-11-28 20:12:17 +00:00
parent cd0392d880
commit 3fd13f9e1b
2 changed files with 9 additions and 3 deletions

View File

@ -1,3 +1,9 @@
2001-11-28 Ulrich Drepper <drepper@redhat.com>
* nss/nss_files/files-XXX.c (internal_getent): Correct input
overflow test for platforms with signed char.
Reported by Andrew Haley <aph@cambridge.redhat.com>.
2001-11-28 Bruno Haible <bruno@clisp.org> 2001-11-28 Bruno Haible <bruno@clisp.org>
* locale/programs/simple-hash.c (lookup_2): Remove function. * locale/programs/simple-hash.c (lookup_2): Remove function.

View File

@ -1,5 +1,5 @@
/* Common code for file-based databases in nss_files module. /* Common code for file-based databases in nss_files module.
Copyright (C) 1996, 1997, 1998, 1999 Free Software Foundation, Inc. Copyright (C) 1996, 1997, 1998, 1999, 2001 Free Software Foundation, Inc.
This file is part of the GNU C Library. This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or The GNU C Library is free software; you can redistribute it and/or
@ -185,7 +185,7 @@ internal_getent (struct STRUCTURE *result,
do do
{ {
/* Terminate the line so that we can test for overflow. */ /* Terminate the line so that we can test for overflow. */
data->linebuffer[linebuflen - 1] = '\xff'; ((unsigned char *) data->linebuffer)[linebuflen - 1] = '\xff';
p = fgets_unlocked (data->linebuffer, linebuflen, stream); p = fgets_unlocked (data->linebuffer, linebuflen, stream);
if (p == NULL) if (p == NULL)
@ -195,7 +195,7 @@ internal_getent (struct STRUCTURE *result,
H_ERRNO_SET (HOST_NOT_FOUND); H_ERRNO_SET (HOST_NOT_FOUND);
return NSS_STATUS_NOTFOUND; return NSS_STATUS_NOTFOUND;
} }
else if (data->linebuffer[linebuflen - 1] != '\xff') else if (((unsigned char *) data->linebuffer)[linebuflen - 1] != 0xff)
{ {
/* The line is too long. Give the user the opportunity to /* The line is too long. Give the user the opportunity to
enlarge the buffer. */ enlarge the buffer. */