AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-21 12:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

io: Add error tests for fchmod

Browse Source 
On Linux most descriptors that do not correspond to file system
entities (such as anonymous pipes and sockets) have file permissions
that can be changed.  While it is possible to create a custom file
system that returns (say) EINVAL for an fchmod attempt, testing this
does not appear to be useful.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
This commit is contained in:
Florian Weimer 2024-08-30 20:37:18 +02:00
parent 29f0db6a2e
commit 424d97be50
2 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
io/Makefile
View File

@ -188,6 +188,7 @@ tests := \
tst-closefrom \
tst-copy_file_range \
tst-faccessat \
tst-fchmod-errors \
tst-fchmodat \
tst-fchownat \
tst-fcntl \

56
io/tst-fchmod-errors.c Normal file
View File

@ -0,0 +1,56 @@
/* Test various fchmod error cases.
Copyright (C) 2024 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <errno.h>
#include <fcntl.h>
#include <support/check.h>
#include <support/xunistd.h>
static int
do_test (void)
{
{
/* Permissions on /dev/null (the opened descriptor) cannot be changed. */
int fd = xopen ("/dev/null", O_RDWR, 0);
errno = 0;
TEST_COMPARE (fchmod (fd, 0), -1);
TEST_COMPARE (errno, EPERM);
xclose (fd);
/* Now testing an invalid file descriptor. */
errno = 0;
TEST_COMPARE (fchmod (fd, 0600), -1);
TEST_COMPARE (errno, EBADF);
}
errno = 0;
TEST_COMPARE (fchmod (-1, 0600), -1);
TEST_COMPARE (errno, EBADF);
errno = 0;
TEST_COMPARE (fchmod (AT_FDCWD, 0600), -1);
TEST_COMPARE (errno, EBADF);
/* Linux supports fchmod on pretty much all file descriptors, so
there is no check for failure on specific types of descriptors
here. */
return 0;
}
#include <support/test-driver.c>