AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-23 13:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

hurd: Stop relying on VM_MAX_ADDRESS

Browse Source 
We'd like to avoid committing to a specific size of virtual address
space (i.e. the value of VM_AARCH64_T0SZ) on AArch64.  While the current
version of GNU Mach still exports VM_MAX_ADDRESS for compatibility, we
should try to avoid relying on it when we can.  This piece of logic in
_hurdsig_getenv () doesn't actually care about the size of user-
accessible virtual address space, it just wants to preempt faults on any
addresses starting from the value of the P pointer and above.  So, use
(unsigned long int) -1 instead of VM_MAX_ADDRESS.

While at it, change the casts to (unsigned long int) and not just
(long int), since the type of struct hurd_signal_preemptor.{first,last}
is unsigned long int.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-ID: <20240323173301.151066-3-bugaevc@gmail.com>
This commit is contained in:
Sergey Bugaev 2024-03-23 20:32:43 +03:00 committed by Samuel Thibault
parent 7f02511e5b
commit 4648bfbbde
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hurd/hurdsig.c
View File

@ -1658,8 +1658,8 @@ _hurdsig_getenv (const char *variable)
while (*ep) while (*ep)
{ {
const char *p = *ep; const char *p = *ep;
_hurdsig_fault_preemptor.first = (long int) p; _hurdsig_fault_preemptor.first = (unsigned long int) p;
_hurdsig_fault_preemptor.last = VM_MAX_ADDRESS; _hurdsig_fault_preemptor.last = (unsigned long int) -1;
if (! strncmp (p, variable, len) && p[len] == '=') if (! strncmp (p, variable, len) && p[len] == '=')
{ {
size_t valuelen; size_t valuelen;
@ -1671,8 +1671,8 @@ _hurdsig_getenv (const char *variable)
memcpy (value, p, valuelen); memcpy (value, p, valuelen);
break; break;
} }
_hurdsig_fault_preemptor.first = (long int) ++ep; _hurdsig_fault_preemptor.first = (unsigned long int) ++ep;
_hurdsig_fault_preemptor.last = (long int) (ep + 1); _hurdsig_fault_preemptor.last = (unsigned long int) (ep + 1);
} }
_hurdsig_end_catch_fault (); _hurdsig_end_catch_fault ();
return value; return value;