mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-21 12:30:06 +00:00
syslog: Improve fortify with clang
It improve fortify checks for syslog and vsyslog. The compile and runtime hecks have similar coverage as with GCC. The syslog fortify wrapper calls the va_arg version, since clang does not support __va_arg_pack. Checked on aarch64, armhf, x86_64, and i686. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
This commit is contained in:
parent
4289b00d43
commit
471c3c7a47
@ -36,6 +36,15 @@ syslog (int __pri, const char *__fmt, ...)
|
|||||||
{
|
{
|
||||||
__syslog_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __va_arg_pack ());
|
__syslog_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __va_arg_pack ());
|
||||||
}
|
}
|
||||||
|
#elif __fortify_use_clang && defined __USE_MISC
|
||||||
|
__fortify_function_error_function __attribute_overloadable__ void
|
||||||
|
syslog (int __pri, __fortify_clang_overload_arg (const char *, , __fmt), ...)
|
||||||
|
{
|
||||||
|
__gnuc_va_list __fortify_ap;
|
||||||
|
__builtin_va_start (__fortify_ap, __fmt);
|
||||||
|
__vsyslog_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __fortify_ap);
|
||||||
|
__builtin_va_end (__fortify_ap);
|
||||||
|
}
|
||||||
#elif !defined __cplusplus
|
#elif !defined __cplusplus
|
||||||
# define syslog(pri, ...) \
|
# define syslog(pri, ...) \
|
||||||
__syslog_chk (pri, __USE_FORTIFY_LEVEL - 1, __VA_ARGS__)
|
__syslog_chk (pri, __USE_FORTIFY_LEVEL - 1, __VA_ARGS__)
|
||||||
@ -43,8 +52,9 @@ syslog (int __pri, const char *__fmt, ...)
|
|||||||
|
|
||||||
|
|
||||||
#ifdef __USE_MISC
|
#ifdef __USE_MISC
|
||||||
__fortify_function void
|
__fortify_function __attribute_overloadable__ void
|
||||||
vsyslog (int __pri, const char *__fmt, __gnuc_va_list __ap)
|
vsyslog (int __pri, __fortify_clang_overload_arg (const char *, ,__fmt),
|
||||||
|
__gnuc_va_list __ap)
|
||||||
{
|
{
|
||||||
__vsyslog_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __ap);
|
__vsyslog_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __ap);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user