Compile with -Wundef.

This commit is contained in:
Roland McGrath 2014-03-14 10:44:34 -07:00
parent c7de502503
commit 498a22333b
21 changed files with 104 additions and 13 deletions

View File

@ -1,3 +1,26 @@
2014-03-14 Roland McGrath <roland@hack.frob.com>
* Makeconfig (+gccwarn): Add -Wundef.
* include/errno.h [IS_IN_rtld] [!RTLD_PRIVATE_ERRNO]: #error to catch
a dl-sysdep.h breaking its contract.
[!IS_IN_rtld] (RTLD_PRIVATE_ERRNO): Define it to 0.
* include/stackinfo.h: New file.
* nptl/sysdeps/i386/tls.h (TLS_DTV_AT_TP): New macro.
* nptl/sysdeps/powerpc/tls.h (TLS_TCB_AT_TP): New macro.
* nptl/sysdeps/s390/tls.h (TLS_DTV_AT_TP): New macro.
* nptl/sysdeps/sh/tls.h (TLS_TCB_AT_TP): New macro.
* nptl/sysdeps/sparc/tls.h (TLS_DTV_AT_TP): New macro.
* nptl/sysdeps/x86_64/tls.h (TLS_DTV_AT_TP): New macro.
* sysdeps/aarch64/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/alpha/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/arm/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/ia64/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/m68k/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/mach/hurd/i386/tls.h (TLS_DTV_AT_TP): New macro.
* sysdeps/microblaze/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/mips/nptl/tls.h (TLS_TCB_AT_TP): New macro.
* sysdeps/tile/nptl/tls.h (TLS_TCB_AT_TP): New macro.
2014-03-14 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
[BZ #16707]

View File

@ -685,6 +685,7 @@ ifeq ($(all-warnings),yes)
else
+gccwarn := -Wall -Wwrite-strings -Winline
endif
+gccwarn += -Wundef
+gccwarn-c = -Wstrict-prototypes
# We do not depend on the address of constants in different files to be

View File

@ -6,6 +6,11 @@
# ifdef IS_IN_rtld
# include <dl-sysdep.h>
# ifndef RTLD_PRIVATE_ERRNO
# error "dl-sysdep.h must define RTLD_PRIVATE_ERRNO!"
# endif
# else
# define RTLD_PRIVATE_ERRNO 0
# endif
# if RTLD_PRIVATE_ERRNO

42
include/stackinfo.h Normal file
View File

@ -0,0 +1,42 @@
/* Details about the machine's stack: wrapper header.
Copyright (C) 2014 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
#ifndef _INCLUDE_STACKINFO_H
#define _INCLUDE_STACKINFO_H 1
/* A sysdeps/.../stackinfo.h file defines details for the CPU.
It is obliged to define either _STACK_GROWS_DOWN or _STACK_GROWS_UP. */
#include_next <stackinfo.h>
#if defined _STACK_GROWS_DOWN && _STACK_GROWS_DOWN
# ifdef _STACK_GROWS_UP
# error "stackinfo.h should not define both!"
# else
# define _STACK_GROWS_UP 0
# endif
#elif defined _STACK_GROWS_UP && _STACK_GROWS_UP
# ifdef _STACK_GROWS_DOWN
# error "stackinfo.h should not define both!"
# else
# define _STACK_GROWS_DOWN 0
# endif
#else
# error "stackinfo.h must define _STACK_GROWS_UP or _STACK_GROWS_DOWN!"
#endif
#endif /* include/stackinfo.h */

View File

@ -104,9 +104,6 @@ union user_desc_init
};
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* This is the size of the initial TCB. Can't be just sizeof (tcbhead_t),
because NPTL getpid, __libc_alloca_cutoff etc. need (almost) the whole
struct pthread even when not linked with -lpthread. */
@ -124,6 +121,10 @@ union user_desc_init
/* The TCB can have any size and the memory following the address the
thread pointer points to is unspecified. Allocate the TCB there. */
# define TLS_TCB_AT_TP 1
# define TLS_DTV_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* Install the dtv pointer. The pointer passed is to the element with

View File

@ -49,6 +49,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* We use the multiple_threads field in the pthread struct */
#define TLS_MULTIPLE_THREADS_IN_TCB 1
@ -56,6 +57,7 @@ typedef union dtv
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* The stack_guard is accessed directly by GCC -fstack-protector code,
so it is a part of public ABI. The dtv and pointer_guard fields
are private. */

View File

@ -73,9 +73,6 @@ typedef struct
/* Get system call information. */
# include <sysdep.h>
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* This is the size of the initial TCB. Can't be just sizeof (tcbhead_t),
because NPTL getpid, __libc_alloca_cutoff etc. need (almost) the whole
struct pthread even when not linked with -lpthread. */
@ -93,6 +90,10 @@ typedef struct
/* The TCB can have any size and the memory following the address the
thread pointer points to is unspecified. Allocate the TCB there. */
# define TLS_TCB_AT_TP 1
# define TLS_DTV_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* Install the dtv pointer. The pointer passed is to the element with

View File

@ -76,6 +76,7 @@ typedef struct
/* The TLS blocks start right after the TCB. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -69,9 +69,6 @@ typedef struct
/* Get system call information. */
# include <sysdep.h>
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
register struct pthread *__thread_self __asm__("%g7");
/* This is the size of the initial TCB. Can't be just sizeof (tcbhead_t),
@ -91,6 +88,10 @@ register struct pthread *__thread_self __asm__("%g7");
/* The TCB can have any size and the memory following the address the
thread pointer points to is unspecified. Allocate the TCB there. */
# define TLS_TCB_AT_TP 1
# define TLS_DTV_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* Install the dtv pointer. The pointer passed is to the element with
index -1 which contain the length. */

View File

@ -92,10 +92,6 @@ typedef struct
/* Get system call information. */
# include <sysdep.h>
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
#ifndef LOCK_PREFIX
# ifdef UP
# define LOCK_PREFIX /* nothing */
@ -121,6 +117,10 @@ typedef struct
/* The TCB can have any size and the memory following the address the
thread pointer points to is unspecified. Allocate the TCB there. */
# define TLS_TCB_AT_TP 1
# define TLS_DTV_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>
/* Install the dtv pointer. The pointer passed is to the element with

View File

@ -1,3 +1,7 @@
2014-02-28 Roland McGrath <roland@hack.frob.com>
* sysdeps/hppa/nptl/tls.h (TLS_TCB_AT_TP): New macro.
2014-03-05 Joseph Myers <joseph@codesourcery.com>
* sysdeps/hppa/fpu/libm-test-ulps: Remove individual test ulps.

View File

@ -51,6 +51,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -48,6 +48,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -42,6 +42,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -49,6 +49,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -87,6 +87,7 @@ register struct pthread *__thread_self __asm__("r13");
/* The DTV is allocated at the TP; the TCB is placed elsewhere. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -49,6 +49,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -26,6 +26,7 @@
/* The TCB can have any size and the memory following the address the
thread pointer points to is unspecified. Allocate the TCB there. */
#define TLS_TCB_AT_TP 1
#define TLS_DTV_AT_TP 0
#ifndef __ASSEMBLER__

View File

@ -48,6 +48,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -67,6 +67,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* Get the thread descriptor definition. */
# include <nptl/descr.h>

View File

@ -49,6 +49,7 @@ typedef union dtv
/* The TP points to the start of the thread blocks. */
# define TLS_DTV_AT_TP 1
# define TLS_TCB_AT_TP 0
/* We use the multiple_threads field in the pthread struct */
#define TLS_MULTIPLE_THREADS_IN_TCB 1