AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-09 23:00:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify generic fdim implementations.

Browse Source 
The generic fdim implementations have unnecessarily complicated code,
using fpclassify to determine whether the arguments are NaNs,
subtracting NaNs if so and otherwise subtracting the non-NaN arguments
if not (x <= y), then using fpclassify on the result to see if it is
infinite.

This patch simplifies the code.  Instead of handling NaNs separately,
it suffices to use an unordered comparison with islessequal (x, y) to
determine whether to return zero, and otherwise NaNs can go through
the same subtraction as non-NaN arguments; no explicit tests for NaN
are needed at all.  Then, isinf instead of fpclassify can be used to
determine whether to set errno (in the normal non-overflow case, only
one classification will need to occur, unlike the three in the
previous code, of which two occurred even if returning zero, because
the result will not be infinite in the normal case).

The resulting logic is essentially the same as that in the powerpc
version, except that the powerpc version is missing errno setting and
uses <= not islessequal, so relying on
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684>, the GCC bug that
unordered comparison instructions are wrongly used on powerpc for
ordered comparisons.

The compiled code for fdim and fdimf on x86_64 is less than half the
size of the previous code.

Tested for x86_64.

	* math/s_fdim.c (__fdim): Use islessequal and isinf instead of
	fpclassify.
	* math/s_fdimf.c (__fdimf): Likewise.
	* math/s_fdiml.c (__fdiml): Likewise.
This commit is contained in:
Joseph Myers 2016-06-14 14:56:42 +00:00
parent c8376f3e07
commit 4fea2cda61
4 changed files with 13 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
2016-06-14 Joseph Myers <joseph@codesourcery.com>
* math/s_fdim.c (__fdim): Use islessequal and isinf instead of
fpclassify.
* math/s_fdimf.c (__fdimf): Likewise.
* math/s_fdiml.c (__fdiml): Likewise.
2016-06-14 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
* sysdeps/powerpc/powerpc64/multiarch/Makefile:

12
math/s_fdim.c
View File

@ -23,19 +23,11 @@
double
__fdim (double x, double y)
{
int clsx = fpclassify (x);
int clsy = fpclassify (y);
if (clsx == FP_NAN || clsy == FP_NAN)
/* Raise invalid flag for signaling but not quiet NaN. */
return x - y;
if (x <= y)
if (islessequal (x, y))
return 0.0;
double r = x - y;
if (fpclassify (r) == FP_INFINITE
&& clsx != FP_INFINITE && clsy != FP_INFINITE)
if (isinf (r) && !isinf (x) && !isinf (y))
__set_errno (ERANGE);
return r;

12
math/s_fdimf.c
View File

@ -23,19 +23,11 @@
float
__fdimf (float x, float y)
{
int clsx = fpclassify (x);
int clsy = fpclassify (y);
if (clsx == FP_NAN || clsy == FP_NAN)
/* Raise invalid flag for signaling but not quiet NaN. */
return x - y;
if (x <= y)
if (islessequal (x, y))
return 0.0f;
float r = x - y;
if (fpclassify (r) == FP_INFINITE
&& clsx != FP_INFINITE && clsy != FP_INFINITE)
if (isinf (r) && !isinf (x) && !isinf (y))
__set_errno (ERANGE);
return r;

12
math/s_fdiml.c
View File

@ -23,19 +23,11 @@
long double
__fdiml (long double x, long double y)
{
int clsx = fpclassify (x);
int clsy = fpclassify (y);
if (clsx == FP_NAN || clsy == FP_NAN)
/* Raise invalid flag for signaling but not quiet NaN. */
return x - y;
if (x <= y)
if (islessequal (x, y))
return 0.0f;
long double r = x - y;
if (fpclassify (r) == FP_INFINITE
&& clsx != FP_INFINITE && clsy != FP_INFINITE)
if (isinf (r) && !isinf (x) && !isinf (y))
__set_errno (ERANGE);
return r;