AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2025-01-10 19:30:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix truncation warnings in posix/tst-glob_symlinks.c.

Browse Source 
The test posix/tst-glob_symlinks.c fails to build with GCC mainline:

tst-glob_symlinks.c: In function 'do_test':
tst-glob_symlinks.c:124:30: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
   snprintf (buf, sizeof buf, "%s?", dangling_link);
                              ^~~~~
tst-glob_symlinks.c:124:3: note: 'snprintf' output between 2 and 4097 bytes into a destination of size 4096
   snprintf (buf, sizeof buf, "%s?", dangling_link);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tst-glob_symlinks.c:128:30: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
   snprintf (buf, sizeof buf, "%s*", dangling_link);
                              ^~~~~
tst-glob_symlinks.c:128:3: note: 'snprintf' output between 2 and 4097 bytes into a destination of size 4096
   snprintf (buf, sizeof buf, "%s*", dangling_link);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This patch fixes the test to avoid such truncation warnings by
increasing the buffer in question by one byte, to ensure it can hold
any possible result of %s? or %s* formats where %s comes from a buffer
of size PATH_MAX.

Tested compilation with build-many-glibcs.py for aarch64-linux-gnu.

	* posix/tst-glob_symlinks.c (do_test): Increase size of buf.
This commit is contained in:
Joseph Myers 2017-12-18 22:54:01 +00:00
parent 1421f39b7e
commit 5983df320a
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ChangeLog
View File

@ -1,5 +1,7 @@
2017-12-18 Joseph Myers <joseph@codesourcery.com> 2017-12-18 Joseph Myers <joseph@codesourcery.com>
* posix/tst-glob_symlinks.c (do_test): Increase size of buf.
* string/tester.c (test_strncat): Also disable -Warray-bounds * string/tester.c (test_strncat): Also disable -Warray-bounds
warnings for two tests. warnings for two tests.

2
posix/tst-glob_symlinks.c
View File

@ -94,7 +94,7 @@ do_prepare (int argc, char *argv[])
static int static int
do_test (void) do_test (void)
{ {
char buf[PATH_MAX]; char buf[PATH_MAX + 1];
glob_t gl; glob_t gl;
TEST_VERIFY_EXIT (glob (valid_link, 0, NULL, &gl) == 0); TEST_VERIFY_EXIT (glob (valid_link, 0, NULL, &gl) == 0);