AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-24 14:00:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle tests-unsupported if run-built-tests = no.

Browse Source 
The tests-unsupported variable lists tests that should neither be
compiled nor run, because some support needed to compile them is
missing.

The implementation of this feature involves having a rule to create
.out files for these tests that takes precedence over the default
rule.  This does not work in the run-built-tests = no case (cross
compiling without use of a wrapper to run the tests on a separate
system, in which cases most tests are compiled only) because in that
case the tests target depends on $(tests) to ensure all tests get
compiled.  This patch changes that dependency to filter out
$(tests-unsupported).

Tested with cross-compilation to ARM with GCC 5, where libstdc++ is
missing some C++11 support because of the bug I fixed in
<https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01040.html> and so
tests-unsupported is nonempty and the tests in question fail to
compile.  (When I originally observed the bug, it was with a native
build / test simply using an x86_64 compiler that had been configured
as a cross compiler to isolate it from the system headers / libraries,
so the configuration issue applied to the compiler but run-built-tests
was yes, so I don't observe the issue with tests-unsupported with that
compiler.)

	* Rules [$(run-built-tests) = no] (tests): Do not depend on
	$(tests-unsupported).
This commit is contained in:
Joseph Myers 2016-11-04 21:28:03 +00:00
parent 6d1774146f
commit 5e37a69a04
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2016-11-04 Joseph Myers <joseph@codesourcery.com>
* Rules [$(run-built-tests) = no] (tests): Do not depend on
$(tests-unsupported).
2016-11-04 Adhemerval Zanella <adhemerval.zanella@linaro.org> 2016-11-04 Adhemerval Zanella <adhemerval.zanella@linaro.org>
* sysdeps/unix/sysv/linux/sparc/bits/wordsize.h * sysdeps/unix/sysv/linux/sparc/bits/wordsize.h

3
Rules
View File

@ -114,7 +114,8 @@ else
others: $(addprefix $(objpfx),$(extra-objs)) others: $(addprefix $(objpfx),$(extra-objs))
endif endif
ifeq ($(run-built-tests),no) ifeq ($(run-built-tests),no)
tests: $(addprefix $(objpfx),$(tests) $(test-srcs)) $(tests-special) tests: $(addprefix $(objpfx),$(filter-out $(tests-unsupported),$(tests)) \
$(test-srcs)) $(tests-special)
xtests: tests $(xtests-special) xtests: tests $(xtests-special)
else else
tests: $(tests:%=$(objpfx)%.out) $(tests-special) tests: $(tests:%=$(objpfx)%.out) $(tests-special)