AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-12 16:20:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

hurd: Do not declare local variables volatile

Browse Source 
These are just regular local variables that are not accessed in any
funny ways, not even though a pointer. There's absolutely no reason to
declare them volatile. It only ends up hurting the quality of the
generated machine code.

If anything, it would make sense to decalre sigsp as *pointing* to
volatile memory (volatile void *sigsp), but evidently that's not needed
either.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230403115621.258636-2-bugaevc@gmail.com>
This commit is contained in:
Sergey Bugaev 2023-04-03 14:56:20 +03:00 committed by Samuel Thibault
parent 892f702827
commit 645da826bb
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hurd/trampoline.c
View File

@ -29,7 +29,7 @@ struct sigcontext *
_hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action, _hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action,
__sighandler_t handler, __sighandler_t handler,
int signo, struct hurd_signal_detail *detail, int signo, struct hurd_signal_detail *detail,
volatile int rpc_wait, int rpc_wait,
struct machine_thread_all_state *state) struct machine_thread_all_state *state)
{ {
#error "Need to write sysdeps/mach/hurd/MACHINE/trampoline.c" #error "Need to write sysdeps/mach/hurd/MACHINE/trampoline.c"

4
sysdeps/mach/hurd/i386/trampoline.c
View File

@ -83,13 +83,13 @@ struct sigcontext *
_hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action, _hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action,
__sighandler_t handler, __sighandler_t handler,
int signo, struct hurd_signal_detail *detail, int signo, struct hurd_signal_detail *detail,
volatile int rpc_wait, int rpc_wait,
struct machine_thread_all_state *state) struct machine_thread_all_state *state)
{ {
void trampoline (void); void trampoline (void);
void rpc_wait_trampoline (void); void rpc_wait_trampoline (void);
void firewall (void); void firewall (void);
void *volatile sigsp; void *sigsp;
struct sigcontext *scp; struct sigcontext *scp;
struct struct
{ {