From 6948ee4edf0c57c556f8d5f394d9191216d05780 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Sat, 28 Sep 2024 21:06:11 +0200 Subject: [PATCH] stdio-common: Fix memory leak in tst-freopen4* tests on UNSUPPORTED The temp_dir allocation leaks if support_can_chroot returns false. --- stdio-common/tst-freopen4-main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/stdio-common/tst-freopen4-main.c b/stdio-common/tst-freopen4-main.c index e169442cf4..7284677a97 100644 --- a/stdio-common/tst-freopen4-main.c +++ b/stdio-common/tst-freopen4-main.c @@ -33,7 +33,7 @@ int do_test (void) { mtrace (); - char *temp_dir = support_create_temp_directory ("tst-freopen4"); + char *temp_dir; FILE *fp; int ret; @@ -45,6 +45,8 @@ do_test (void) support_become_root (); if (!support_can_chroot ()) return EXIT_UNSUPPORTED; + + temp_dir = support_create_temp_directory ("tst-freopen4"); xchroot (temp_dir); /* Test freopen with NULL, renamed file. This verifies that