AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-25 12:11:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

posix: fix system when a child cannot be created [BZ #32450]

Browse Source 
POSIX states that "if a child process cannot be created, or if the
termination status for the command language interpreter cannot be
obtained, system() shall return -1 and set errno to indicate the error."

In the glibc implementation it could happen when posix_spawn fails,
which happens when the underlying fork, vfork, or clone call fails. They
could fail with EAGAIN and ENOMEM.

Resolves: BZ #32450
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
This commit is contained in:
Aurelien Jarno 2024-12-19 23:55:15 +01:00
parent 034cd67528
commit 6fd215d6ae
2 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
stdlib/tst-system.c
View File

@ -20,6 +20,7 @@
#include <string.h> #include <string.h>
#include <signal.h> #include <signal.h>
#include <paths.h> #include <paths.h>
#include <sys/resource.h>
#include <support/capture_subprocess.h> #include <support/capture_subprocess.h>
#include <support/check.h> #include <support/check.h>
@ -194,6 +195,26 @@ do_test (void)
xpthread_join (long_sleep_thread); xpthread_join (long_sleep_thread);
} }
{
struct rlimit rlimit_orig, rlimit_new;
if (getrlimit (RLIMIT_NPROC, &rlimit_orig) != 0)
FAIL_EXIT1 ("getrlimit (RLIMIT_NPROC) failed: %m");
/* Force failure for the system call */
rlimit_new.rlim_cur = 0;
rlimit_new.rlim_max = rlimit_orig.rlim_max;
if (setrlimit (RLIMIT_NPROC, &rlimit_new) != 0)
FAIL_EXIT1 ("setrlimit (RLIMIT_NPROC) failed: %m");
TEST_COMPARE (system (""), -1);
/* Restore NPROC limit */
if (setrlimit (RLIMIT_NPROC, &rlimit_orig) != 0)
FAIL_EXIT1 ("setrlimit (RLIMIT_NPROC) failed: %m");
}
TEST_COMPARE (system (""), 0); TEST_COMPARE (system (""), 0);
return 0; return 0;

10
sysdeps/posix/system.c
View File

@ -175,10 +175,14 @@ do_system (const char *line)
__libc_cleanup_region_end (0); __libc_cleanup_region_end (0);
#endif #endif
} }
else if (ret == EAGAIN || ret == ENOMEM)
/* POSIX states that failure to create a child process should
return -1. */
status = -1;
else else
/* POSIX states that failure to execute the shell should return /* POSIX states that failure to execute the shell should return
as if the shell had terminated using _exit(127). */ as if the shell had terminated using _exit(127). */
status = W_EXITCODE (127, 0); status = W_EXITCODE (127, 0);
/* sigaction can not fail with SIGINT/SIGQUIT used with old /* sigaction can not fail with SIGINT/SIGQUIT used with old
disposition. Same applies for sigprocmask. */ disposition. Same applies for sigprocmask. */