CVE-2022-23219: Buffer overflow in sunrpc clnt_create for "unix" (bug 22542)

Processing an overlong pathname in the sunrpc clnt_create function
results in a stack-based buffer overflow.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
(cherry picked from commit 226b46770c)
This commit is contained in:
Florian Weimer 2022-01-17 10:21:34 +01:00
parent 5575daae50
commit 7b5d433fd0
2 changed files with 14 additions and 3 deletions

7
NEWS
View File

@ -7,10 +7,17 @@ using `glibc' in the "product" field.
Version 2.34.1 Version 2.34.1
Security related changes:
CVE-2022-23219: Passing an overlong file name to the clnt_create
legacy function could result in a stack-based buffer overflow when
using the "unix" protocol. Reported by Martin Sebor.
The following bugs are resolved with this release: The following bugs are resolved with this release:
[12889] nptl: Fix race between pthread_kill and thread exit [12889] nptl: Fix race between pthread_kill and thread exit
[19193] nptl: pthread_kill, pthread_cancel should not fail after exit [19193] nptl: pthread_kill, pthread_cancel should not fail after exit
[22542] CVE-2022-23219: Buffer overflow in sunrpc clnt_create for "unix"
[28036] Incorrect types for pthread_mutexattr_set/getrobust_np [28036] Incorrect types for pthread_mutexattr_set/getrobust_np
[28182] _TIME_BITS=64 in C++ has issues with fcntl, ioctl, prctl [28182] _TIME_BITS=64 in C++ has issues with fcntl, ioctl, prctl
[28223] mips: clone does not align stack [28223] mips: clone does not align stack

View File

@ -57,9 +57,13 @@ clnt_create (const char *hostname, u_long prog, u_long vers,
if (strcmp (proto, "unix") == 0) if (strcmp (proto, "unix") == 0)
{ {
memset ((char *)&sun, 0, sizeof (sun)); if (__sockaddr_un_set (&sun, hostname) < 0)
sun.sun_family = AF_UNIX; {
strcpy (sun.sun_path, hostname); struct rpc_createerr *ce = &get_rpc_createerr ();
ce->cf_stat = RPC_SYSTEMERROR;
ce->cf_error.re_errno = errno;
return NULL;
}
sock = RPC_ANYSOCK; sock = RPC_ANYSOCK;
client = clntunix_create (&sun, prog, vers, &sock, 0, 0); client = clntunix_create (&sun, prog, vers, &sock, 0, 0);
if (client == NULL) if (client == NULL)