AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-09 23:00:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: syslog: Use CLOC_EXEC with _PATH_CONSOLE (BZ #17145)

Browse Source 
The syslog open the '/dev/console' for LOG_CONS without O_CLOEXEC,
which might leak in multithread programs that call fork.

Checked on x86_64-linux-gnu.
This commit is contained in:
Adhemerval Zanella 2021-04-10 23:29:40 -03:00
parent ded3cef361
commit 7f3ab33f20
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
misc/syslog.c
View File

@ -284,7 +284,8 @@ __vsyslog_internal(int pri, const char *fmt, va_list ap,
* syslogd failure. * syslogd failure.
*/ */
if (LogStat & LOG_CONS && if (LogStat & LOG_CONS &&
(fd = __open(_PATH_CONSOLE, O_WRONLY|O_NOCTTY, 0)) >= 0) (fd = __open(_PATH_CONSOLE, O_WRONLY|O_NOCTTY|O_CLOEXEC,
0)) >= 0)
{ {
__dprintf (fd, "%s\r\n", buf + msgoff); __dprintf (fd, "%s\r\n", buf + msgoff);
(void)__close(fd); (void)__close(fd);