From 7fe1e1d60a0f7b5eaf9f423c1fea7d0660690088 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Fri, 11 Nov 2016 09:02:46 -0200 Subject: [PATCH] Consolidate rename Linux implementation This patch consolidates the Linux rename implementation on sysdeps/unix/sysv/linux/rename.c. Current code try to use __NR_rename if is defined and apply the same strategy for __NR_renameat and __NR_renameat2. Check on x86_64 and aarch64. * sysdeps/unix/sysv/linux/rename.c: New file. * sysdeps/unix/sysv/linux/generic/rename.c: Remove file. --- ChangeLog | 5 +++++ sysdeps/unix/sysv/linux/{generic => }/rename.c | 14 ++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) rename sysdeps/unix/sysv/linux/{generic => }/rename.c (69%) diff --git a/ChangeLog b/ChangeLog index 90dad72833..a9e69a3364 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-12-14 Adhemerval Zanella + + * sysdeps/unix/sysv/linux/rename.c: New file. + * sysdeps/unix/sysv/linux/generic/rename.c: Remove file. + 2015-12-14 Wilco Dijkstra * benchtests/bench-strtok.c (oldstrtok): Add old implementation. diff --git a/sysdeps/unix/sysv/linux/generic/rename.c b/sysdeps/unix/sysv/linux/rename.c similarity index 69% rename from sysdeps/unix/sysv/linux/generic/rename.c rename to sysdeps/unix/sysv/linux/rename.c index 174c147eb4..73f0ae43bd 100644 --- a/sysdeps/unix/sysv/linux/generic/rename.c +++ b/sysdeps/unix/sysv/linux/rename.c @@ -1,6 +1,6 @@ -/* Copyright (C) 2011-2016 Free Software Foundation, Inc. +/* Linux implementation for rename function. + Copyright (C) 2016 Free Software Foundation, Inc. This file is part of the GNU C Library. - Contributed by Chris Metcalf , 2011. The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public @@ -17,13 +17,19 @@ . */ #include -#include #include #include +#include /* Rename the file OLD to NEW. */ int rename (const char *old, const char *new) { - return INLINE_SYSCALL (renameat, 4, AT_FDCWD, old, AT_FDCWD, new); +#if defined (__NR_rename) + return INLINE_SYSCALL_CALL (rename, old, new); +#elif defined (__NR_renameat) + return INLINE_SYSCALL_CALL (renameat, AT_FDCWD, old, AT_FDCWD, new); +#else + return INLINE_SYSCALL_CALL (renameat2, AT_FDCWD, old, AT_FDCWD, new, 0); +#endif }