From 8888eb5e6d0ca664671c312a1409166114699519 Mon Sep 17 00:00:00 2001 From: Zack Weinberg Date: Mon, 14 Nov 2016 14:25:11 -0500 Subject: [PATCH] Fix build-and-build-again bug in sunrpc tests. rpcgen will error out if the file it's asked to create already exists. Several other rules in sunrpc/Makefile take care to delete rpcgen- generated files before creating them, but rpcgen-tests doesn't, which can lead to spurious test failures in an incremental rebuild. * sunrpc/Makefile (rpcgen-tests): Delete the .out file before creating or re-creating it. --- sunrpc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/sunrpc/Makefile b/sunrpc/Makefile index 99e5c3ccf8..9e805fbb00 100644 --- a/sunrpc/Makefile +++ b/sunrpc/Makefile @@ -233,6 +233,7 @@ $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so $(shared-thread-library) ifeq ($(run-built-tests),yes) $(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen + -rm -f $@ $(built-program-cmd) -c $< -o $@; \ $(evaluate-test) endif