AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-09 23:00:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-skeleton.c: Do not set RLIMIT_DATA [BZ #19648]

Browse Source 
With older kernels, it is mostly ineffective because it causes malloc
to switch from sbrk to mmap (potentially invalidating malloc testing
compared to what real appliations do).  With newer kernels which
have switched to enforcing RLIMIT_DATA for mmap as well, some test
cases will fail in an unintended fashion because the limit which was
set previously does not include room for all mmap mappings.
This commit is contained in:
Florian Weimer 2016-03-07 13:48:47 +01:00
parent 9ff72da471
commit 900056024b
2 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2016-03-07 Florian Weimer <fweimer@redhat.com>
[BZ #19648]
* test-skeleton.c (main): Do not set RLIMIT_DATA.
2016-03-07 Adhemerval Zanella <adhemerval.zanella@linaro.org> 2016-03-07 Adhemerval Zanella <adhemerval.zanella@linaro.org>
[BZ #14750] [BZ #14750]

17
test-skeleton.c
View File

@ -429,23 +429,6 @@ main (int argc, char *argv[])
setrlimit (RLIMIT_CORE, &core_limit); setrlimit (RLIMIT_CORE, &core_limit);
#endif #endif
#ifdef RLIMIT_DATA
/* Try to avoid eating all memory if a test leaks. */
struct rlimit data_limit;
if (getrlimit (RLIMIT_DATA, &data_limit) == 0)
{
if (TEST_DATA_LIMIT == RLIM_INFINITY)
data_limit.rlim_cur = data_limit.rlim_max;
else if (data_limit.rlim_cur > (rlim_t) TEST_DATA_LIMIT)
data_limit.rlim_cur = MIN ((rlim_t) TEST_DATA_LIMIT,
data_limit.rlim_max);
if (setrlimit (RLIMIT_DATA, &data_limit) < 0)
printf ("setrlimit: RLIMIT_DATA: %m\n");
}
else
printf ("getrlimit: RLIMIT_DATA: %m\n");
#endif
/* We put the test process in its own pgrp so that if it bogusly /* We put the test process in its own pgrp so that if it bogusly
generates any job control signals, they won't hit the whole build. */ generates any job control signals, they won't hit the whole build. */
if (setpgid (0, 0) != 0) if (setpgid (0, 0) != 0)