AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-08 14:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

elf: Eliminate alloca in open_verify

Browse Source 
With the two-stage approach for exception handling, the name can
be freed after it has been copied into the exception, but before
it is raised.
This commit is contained in:
Florian Weimer 2024-09-24 13:23:10 +02:00
parent bdaf500353
commit 9802c0f2fe
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
elf/dl-load.c
View File

@ -1592,15 +1592,13 @@ open_verify (const char *name, int fd,
errval = errno; errval = errno;
errstring = (errval == 0 errstring = (errval == 0
? N_("file too short") : N_("cannot read file data")); ? N_("file too short") : N_("cannot read file data"));
lose: lose:;
struct dl_exception exception;
_dl_exception_create (&exception, name, errstring);
if (free_name) if (free_name)
{ free ((char *) name);
char *realname = (char *) name;
name = strdupa (realname);
free (realname);
}
__close_nocancel (fd); __close_nocancel (fd);
_dl_signal_error (errval, name, NULL, errstring); _dl_signal_exception (errval, &exception, NULL);
} }
/* See whether the ELF header is what we expect. */ /* See whether the ELF header is what we expect. */