AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-22 13:00:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 'array subscript is above array bounds' warning in res_send.c

Browse Source 
I see this warning in my build on F21 x86_64, which seems to be due to
a weak check for array bounds.  Fixed by making the bounds check
stronger.

This is not an actual bug since nscount is never set to anything
greater than MAXNS.  The compiler however does not know this, so we
need the stronger bounds check to quieten the compiler.
This commit is contained in:
Siddhesh Poyarekar 2014-12-16 16:53:05 +05:30
parent 8b460906cd
commit a0d424ef9d
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2014-12-16 Siddhesh Poyarekar <siddhesh@redhat.com>
* resolv/res_send.c (__libc_res_nsend): Fix check for nsmap
bounds.
2014-12-16 Arjun Shankar <arjun.is@lostca.se>
* libio/tst-fopenloc.c: Use test-skeleton.c.

2
resolv/res_send.c
View File

@ -429,7 +429,7 @@ __libc_res_nsend(res_state statp, const u_char *buf, int buflen,
while (ns < MAXNS
&& EXT(statp).nsmap[ns] != MAXNS)
ns++;
if (ns == MAXNS)
if (ns >= MAXNS)
break;
EXT(statp).nsmap[ns] = n;
map[n] = ns++;