AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-22 21:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

login: Remove double-assignment of fl.l_whence in try_file_lock

Browse Source 
Since l_whence is the second member of struct flock, it is written
twice.  The double-assignment is technically undefined behavior due to
the lack of a sequence point.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Change-Id: I2baf9e70690e723c61051b25ccbd510aec15976c
This commit is contained in:
Florian Weimer 2019-11-07 09:53:41 +01:00
parent a673c07af3
commit b0a83ae71b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
login/utmp_file.c
View File

@ -79,7 +79,7 @@ try_file_lock (int fd, int type)
struct flock64 fl = struct flock64 fl =
{ {
.l_type = type, .l_type = type,
fl.l_whence = SEEK_SET, .l_whence = SEEK_SET,
}; };
bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0; bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0;