2008-01-09  Ulrich Drepper  <drepper@redhat.com>
	[BZ #5553]
	* malloc/malloc.c (public_mALLOc): Set ar_ptr when trying main_arena.
	(public_mEMALIGn): Likewise.
	Patch mostly by Daniel Jacobowitz.
This commit is contained in:
Ulrich Drepper 2008-01-09 20:35:03 +00:00
parent 4b1b449d1d
commit b34437015b
2 changed files with 18 additions and 8 deletions

View File

@ -1,3 +1,10 @@
2008-01-09 Ulrich Drepper <drepper@redhat.com>
[BZ #5553]
* malloc/malloc.c (public_mALLOc): Set ar_ptr when trying main_arena.
(public_mEMALIGn): Likewise.
Patch mostly by Daniel Jacobowitz.
2008-01-09 Jakub Jelinek <jakub@redhat.com> 2008-01-09 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/i386/makecontext.S (__makecontext): Avoid * sysdeps/unix/sysv/linux/i386/makecontext.S (__makecontext): Avoid

View File

@ -1,5 +1,5 @@
/* Malloc implementation for multiple threads without lock contention. /* Malloc implementation for multiple threads without lock contention.
Copyright (C) 1996-2006, 2007 Free Software Foundation, Inc. Copyright (C) 1996-2006, 2007, 2008 Free Software Foundation, Inc.
This file is part of the GNU C Library. This file is part of the GNU C Library.
Contributed by Wolfram Gloger <wg@malloc.de> Contributed by Wolfram Gloger <wg@malloc.de>
and Doug Lea <dl@cs.oswego.edu>, 2001. and Doug Lea <dl@cs.oswego.edu>, 2001.
@ -3553,9 +3553,10 @@ public_mALLOc(size_t bytes)
/* Maybe the failure is due to running out of mmapped areas. */ /* Maybe the failure is due to running out of mmapped areas. */
if(ar_ptr != &main_arena) { if(ar_ptr != &main_arena) {
(void)mutex_unlock(&ar_ptr->mutex); (void)mutex_unlock(&ar_ptr->mutex);
(void)mutex_lock(&main_arena.mutex); ar_ptr = &main_arena;
victim = _int_malloc(&main_arena, bytes); (void)mutex_lock(&ar_ptr->mutex);
(void)mutex_unlock(&main_arena.mutex); victim = _int_malloc(ar_ptr, bytes);
(void)mutex_unlock(&ar_ptr->mutex);
} else { } else {
#if USE_ARENAS #if USE_ARENAS
/* ... or sbrk() has failed and there is still a chance to mmap() */ /* ... or sbrk() has failed and there is still a chance to mmap() */
@ -3760,17 +3761,19 @@ public_mEMALIGn(size_t alignment, size_t bytes)
if(!ar_ptr) if(!ar_ptr)
return 0; return 0;
p = _int_memalign(ar_ptr, alignment, bytes); p = _int_memalign(ar_ptr, alignment, bytes);
(void)mutex_unlock(&ar_ptr->mutex);
if(!p) { if(!p) {
/* Maybe the failure is due to running out of mmapped areas. */ /* Maybe the failure is due to running out of mmapped areas. */
if(ar_ptr != &main_arena) { if(ar_ptr != &main_arena) {
(void)mutex_lock(&main_arena.mutex); (void)mutex_unlock(&ar_ptr->mutex);
p = _int_memalign(&main_arena, alignment, bytes); ar_ptr = &main_arena;
(void)mutex_unlock(&main_arena.mutex); (void)mutex_lock(&ar_ptr->mutex);
p = _int_memalign(ar_ptr, alignment, bytes);
(void)mutex_unlock(&ar_ptr->mutex);
} else { } else {
#if USE_ARENAS #if USE_ARENAS
/* ... or sbrk() has failed and there is still a chance to mmap() */ /* ... or sbrk() has failed and there is still a chance to mmap() */
ar_ptr = arena_get2(ar_ptr->next ? ar_ptr : 0, bytes); ar_ptr = arena_get2(ar_ptr->next ? ar_ptr : 0, bytes);
(void)mutex_unlock(&ar_ptr->mutex);
if(ar_ptr) { if(ar_ptr) {
p = _int_memalign(ar_ptr, alignment, bytes); p = _int_memalign(ar_ptr, alignment, bytes);
(void)mutex_unlock(&ar_ptr->mutex); (void)mutex_unlock(&ar_ptr->mutex);