mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-21 12:30:06 +00:00
linux: Add posix_spawnattr_{get, set}cgroup_np (BZ 26371)
These functions allow to posix_spawn and posix_spawnp to use CLONE_INTO_CGROUP with clone3, allowing the child process to be created in a different cgroup version 2. These are GNU extensions that are available only for Linux, and also only for the architectures that implement clone3 wrapper (HAVE_CLONE3_WRAPPER). To create a process on a different cgroupv2, one can use the: posix_spawnattr_t attr; posix_spawnattr_init (&attr); posix_spawnattr_setflags (&attr, POSIX_SPAWN_SETCGROUP); posix_spawnattr_setcgroup_np (&attr, cgroup); posix_spawn (...) Similar to other posix_spawn flags, POSIX_SPAWN_SETCGROUP control whether the cgroup file descriptor will be used or not with clone3. There is no fallback if either clone3 does not support the flag or if the architecture does not provide the clone3 wrapper, in this case posix_spawn returns EOPNOTSUPP. Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer <fweimer@redhat.com>
This commit is contained in:
parent
ad77b1bcca
commit
ce2bfb8569
6
NEWS
6
NEWS
@ -14,6 +14,12 @@ Major new features:
|
||||
and under Linux a spare has been allocated: it was always zero
|
||||
in previous versions of glibc, and zero is not a valid result.
|
||||
|
||||
* On Linux, the functions posix_spawnattr_getcgroup_np and
|
||||
posix_spawnattr_setcgroup_np have been added, along with the
|
||||
POSIX_SPAWN_SETCGROUP flag. They allow posix_spawn and posix_spawnp
|
||||
to set the cgroupv2 in the new process in a race-free manner. These
|
||||
functions are GNU extensions and require a kernel with clone3 support.
|
||||
|
||||
Deprecated and removed features, and other changes affecting compatibility:
|
||||
|
||||
[Add deprecations, removals and changes affecting compatibility here]
|
||||
|
21
bits/spawn_ext.h
Normal file
21
bits/spawn_ext.h
Normal file
@ -0,0 +1,21 @@
|
||||
/* POSIX spawn extensions. Generic version.
|
||||
Copyright (C) 2023 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<https://www.gnu.org/licenses/>. */
|
||||
|
||||
#ifndef _SPAWN_H
|
||||
# error "Never include <bits/spawn-ext.h> directly; use <spawn.h> instead."
|
||||
#endif
|
@ -37,6 +37,7 @@ headers := \
|
||||
bits/pthreadtypes-arch.h \
|
||||
bits/pthreadtypes.h \
|
||||
bits/sched.h \
|
||||
bits/spawn_ext.h \
|
||||
bits/thread-shared-types.h \
|
||||
bits/types.h \
|
||||
bits/types/idtype_t.h \
|
||||
|
@ -34,7 +34,8 @@ typedef struct
|
||||
sigset_t __ss;
|
||||
struct sched_param __sp;
|
||||
int __policy;
|
||||
int __pad[16];
|
||||
int __cgroup;
|
||||
int __pad[15];
|
||||
} posix_spawnattr_t;
|
||||
|
||||
|
||||
@ -59,6 +60,7 @@ typedef struct
|
||||
#ifdef __USE_GNU
|
||||
# define POSIX_SPAWN_USEVFORK 0x40
|
||||
# define POSIX_SPAWN_SETSID 0x80
|
||||
# define POSIX_SPAWN_SETCGROUP 0x100
|
||||
#endif
|
||||
|
||||
|
||||
@ -231,4 +233,6 @@ posix_spawn_file_actions_addtcsetpgrp_np (posix_spawn_file_actions_t *,
|
||||
|
||||
__END_DECLS
|
||||
|
||||
#include <bits/spawn_ext.h>
|
||||
|
||||
#endif /* spawn.h */
|
||||
|
@ -26,7 +26,8 @@
|
||||
| POSIX_SPAWN_SETSCHEDPARAM \
|
||||
| POSIX_SPAWN_SETSCHEDULER \
|
||||
| POSIX_SPAWN_SETSID \
|
||||
| POSIX_SPAWN_USEVFORK)
|
||||
| POSIX_SPAWN_USEVFORK \
|
||||
| POSIX_SPAWN_SETCGROUP)
|
||||
|
||||
/* Store flags in the attribute structure. */
|
||||
int
|
||||
|
@ -493,11 +493,14 @@ sysdep_routines += \
|
||||
getcpu \
|
||||
oldglob \
|
||||
sched_getcpu \
|
||||
spawnattr_getcgroup_np \
|
||||
spawnattr_setcgroup_np \
|
||||
# sysdep_routines
|
||||
|
||||
tests += \
|
||||
tst-affinity \
|
||||
tst-affinity-pid \
|
||||
tst-spawn-cgroup \
|
||||
# tests
|
||||
|
||||
tests-static += \
|
||||
@ -511,6 +514,8 @@ tests += \
|
||||
CFLAGS-fork.c = $(libio-mtsafe)
|
||||
CFLAGS-getpid.o = -fomit-frame-pointer
|
||||
CFLAGS-getpid.os = -fomit-frame-pointer
|
||||
|
||||
tst-spawn-cgroup-ARGS = -- $(host-test-program-cmd)
|
||||
endif
|
||||
|
||||
ifeq ($(subdir),inet)
|
||||
|
@ -321,6 +321,10 @@ libc {
|
||||
__ppoll64_chk;
|
||||
%endif
|
||||
}
|
||||
GLIBC_2.39 {
|
||||
posix_spawnattr_getcgroup_np;
|
||||
posix_spawnattr_setcgroup_np;
|
||||
}
|
||||
GLIBC_PRIVATE {
|
||||
# functions used in other libraries
|
||||
__syscall_rt_sigqueueinfo;
|
||||
|
@ -2673,3 +2673,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2782,6 +2782,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2434,3 +2434,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -554,6 +554,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _Exit F
|
||||
GLIBC_2.4 _IO_2_1_stderr_ D 0xa0
|
||||
GLIBC_2.4 _IO_2_1_stdin_ D 0xa0
|
||||
|
@ -551,6 +551,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _Exit F
|
||||
GLIBC_2.4 _IO_2_1_stderr_ D 0xa0
|
||||
GLIBC_2.4 _IO_2_1_stdin_ D 0xa0
|
||||
|
40
sysdeps/unix/sysv/linux/bits/spawn_ext.h
Normal file
40
sysdeps/unix/sysv/linux/bits/spawn_ext.h
Normal file
@ -0,0 +1,40 @@
|
||||
/* POSIX spawn extensions. Linux version.
|
||||
Copyright (C) 2023 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<https://www.gnu.org/licenses/>. */
|
||||
|
||||
#ifndef _SPAWN_H
|
||||
# error "Never include <bits/spawn-ext.h> directly; use <spawn.h> instead."
|
||||
#endif
|
||||
|
||||
__BEGIN_DECLS
|
||||
|
||||
#ifdef __USE_MISC
|
||||
|
||||
/* Get the cgroupsv2 the attribute structure. */
|
||||
extern int posix_spawnattr_getcgroup_np (const posix_spawnattr_t *
|
||||
__restrict __attr,
|
||||
int *__restrict __cgroup)
|
||||
__THROW __nonnull ((1, 2));
|
||||
|
||||
/* Sore the cgroupsv2 the attribute structure. */
|
||||
extern int posix_spawnattr_setcgroup_np (posix_spawnattr_t *__attr,
|
||||
int __cgroup)
|
||||
__THROW __nonnull ((1));
|
||||
|
||||
#endif /* __USE_MISC */
|
||||
|
||||
__END_DECLS
|
@ -2710,3 +2710,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2659,6 +2659,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2843,6 +2843,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2608,6 +2608,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2194,3 +2194,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -555,6 +555,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _Exit F
|
||||
GLIBC_2.4 _IO_2_1_stderr_ D 0x98
|
||||
GLIBC_2.4 _IO_2_1_stdin_ D 0x98
|
||||
|
@ -2786,6 +2786,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2759,3 +2759,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2756,3 +2756,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2751,6 +2751,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2749,6 +2749,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2757,6 +2757,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2659,6 +2659,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2798,3 +2798,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2180,3 +2180,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2825,6 +2825,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2858,6 +2858,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2579,6 +2579,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2893,3 +2893,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2436,3 +2436,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2636,3 +2636,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
@ -2823,6 +2823,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2616,6 +2616,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2666,6 +2666,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2663,6 +2663,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2818,6 +2818,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 _IO_fprintf F
|
||||
GLIBC_2.4 _IO_printf F
|
||||
GLIBC_2.4 _IO_sprintf F
|
||||
|
@ -2631,6 +2631,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
28
sysdeps/unix/sysv/linux/spawnattr_getcgroup_np.c
Normal file
28
sysdeps/unix/sysv/linux/spawnattr_getcgroup_np.c
Normal file
@ -0,0 +1,28 @@
|
||||
/* Copyright (C) 2000-2023 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<https://www.gnu.org/licenses/>. */
|
||||
|
||||
#include <spawn.h>
|
||||
|
||||
/* Get scheduling policy from the attribute structure. */
|
||||
int
|
||||
posix_spawnattr_getcgroup_np (const posix_spawnattr_t *attr,
|
||||
int *cgroup)
|
||||
{
|
||||
*cgroup = attr->__cgroup;
|
||||
|
||||
return 0;
|
||||
}
|
27
sysdeps/unix/sysv/linux/spawnattr_setcgroup_np.c
Normal file
27
sysdeps/unix/sysv/linux/spawnattr_setcgroup_np.c
Normal file
@ -0,0 +1,27 @@
|
||||
/* Copyright (C) 2000-2023 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<https://www.gnu.org/licenses/>. */
|
||||
|
||||
#include <spawn.h>
|
||||
|
||||
/* Store scheduling policy in the attribute structure. */
|
||||
int
|
||||
posix_spawnattr_setcgroup_np (posix_spawnattr_t *attr, int cgroup)
|
||||
{
|
||||
attr->__cgroup = cgroup;
|
||||
|
||||
return 0;
|
||||
}
|
@ -380,14 +380,19 @@ __spawnix (pid_t * pid, const char *file,
|
||||
need for CLONE_SETTLS. Although parent and child share the same TLS
|
||||
namespace, there will be no concurrent access for TLS variables (errno
|
||||
for instance). */
|
||||
bool set_cgroup = attrp ? (attrp->__flags & POSIX_SPAWN_SETCGROUP) : false;
|
||||
struct clone_args clone_args =
|
||||
{
|
||||
/* Unsupported flags like CLONE_CLEAR_SIGHAND will be cleared up by
|
||||
__clone_internal_fallback. */
|
||||
.flags = CLONE_CLEAR_SIGHAND | CLONE_VM | CLONE_VFORK,
|
||||
.flags = (set_cgroup ? CLONE_INTO_CGROUP : 0)
|
||||
| CLONE_CLEAR_SIGHAND
|
||||
| CLONE_VM
|
||||
| CLONE_VFORK,
|
||||
.exit_signal = SIGCHLD,
|
||||
.stack = (uintptr_t) stack,
|
||||
.stack_size = stack_size,
|
||||
.cgroup = (set_cgroup ? attrp->__cgroup : 0)
|
||||
};
|
||||
#ifdef HAVE_CLONE3_WRAPPER
|
||||
args.use_clone3 = true;
|
||||
@ -398,8 +403,19 @@ __spawnix (pid_t * pid, const char *file,
|
||||
#endif
|
||||
{
|
||||
args.use_clone3 = false;
|
||||
new_pid = __clone_internal_fallback (&clone_args, __spawni_child,
|
||||
&args);
|
||||
if (!set_cgroup)
|
||||
new_pid = __clone_internal_fallback (&clone_args, __spawni_child,
|
||||
&args);
|
||||
else
|
||||
{
|
||||
/* No fallback for POSIX_SPAWN_SETCGROUP if clone3 is not
|
||||
supported. */
|
||||
new_pid = -1;
|
||||
#ifdef HAVE_CLONE3_WRAPPER
|
||||
if (errno == ENOSYS)
|
||||
#endif
|
||||
errno = ENOTSUP;
|
||||
}
|
||||
}
|
||||
|
||||
/* It needs to collect the case where the auxiliary process was created
|
||||
|
223
sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
Normal file
223
sysdeps/unix/sysv/linux/tst-spawn-cgroup.c
Normal file
@ -0,0 +1,223 @@
|
||||
/* Tests for posix_spawn cgroup extension.
|
||||
Copyright (C) 2023 Free Software Foundation, Inc.
|
||||
This file is part of the GNU C Library.
|
||||
|
||||
The GNU C Library is free software; you can redistribute it and/or
|
||||
modify it under the terms of the GNU Lesser General Public
|
||||
License as published by the Free Software Foundation; either
|
||||
version 2.1 of the License, or (at your option) any later version.
|
||||
|
||||
The GNU C Library is distributed in the hope that it will be useful,
|
||||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
Lesser General Public License for more details.
|
||||
|
||||
You should have received a copy of the GNU Lesser General Public
|
||||
License along with the GNU C Library; if not, see
|
||||
<https://www.gnu.org/licenses/>. */
|
||||
|
||||
#include <assert.h>
|
||||
#include <errno.h>
|
||||
#include <fcntl.h>
|
||||
#include <getopt.h>
|
||||
#include <spawn.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <support/check.h>
|
||||
#include <support/support.h>
|
||||
#include <support/xstdio.h>
|
||||
#include <support/xunistd.h>
|
||||
#include <support/temp_file.h>
|
||||
#include <sys/vfs.h>
|
||||
#include <sys/wait.h>
|
||||
#include <unistd.h>
|
||||
|
||||
#define CGROUPFS "/sys/fs/cgroup/"
|
||||
#ifndef CGROUP2_SUPER_MAGIC
|
||||
# define CGROUP2_SUPER_MAGIC 0x63677270
|
||||
#endif
|
||||
|
||||
#define F_TYPE_EQUAL(a, b) (a == (typeof (a)) b)
|
||||
|
||||
#define CGROUP_TEST "test-spawn-cgroup"
|
||||
|
||||
/* Nonzero if the program gets called via `exec'. */
|
||||
#define CMDLINE_OPTIONS \
|
||||
{ "restart", no_argument, &restart, 1 },
|
||||
static int restart;
|
||||
|
||||
/* Hold the four initial argument used to respawn the process, plus the extra
|
||||
'--direct', '--restart', the check type ('SIG_IGN' or 'SIG_DFL'), and a
|
||||
final NULL. */
|
||||
static char *spargs[8];
|
||||
|
||||
static inline char *
|
||||
startswith (const char *s, const char *prefix)
|
||||
{
|
||||
size_t l = strlen (prefix);
|
||||
if (strncmp (s, prefix, l) == 0)
|
||||
return (char *) s + l;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static char *
|
||||
get_cgroup (void)
|
||||
{
|
||||
FILE *f = fopen ("/proc/self/cgroup", "re");
|
||||
if (f == NULL)
|
||||
FAIL_UNSUPPORTED ("no cgroup defined for the process: %m");
|
||||
|
||||
char *cgroup = NULL;
|
||||
|
||||
char *line = NULL;
|
||||
size_t linesiz = 0;
|
||||
while (xgetline (&line, &linesiz, f) > 0)
|
||||
{
|
||||
char *entry = startswith (line, "0:");
|
||||
if (entry == NULL)
|
||||
continue;
|
||||
|
||||
entry = strchr (entry, ':');
|
||||
if (entry == NULL)
|
||||
continue;
|
||||
|
||||
cgroup = entry + 1;
|
||||
size_t l = strlen (cgroup);
|
||||
if (cgroup[l - 1] == '\n')
|
||||
cgroup[l - 1] = '\0';
|
||||
|
||||
cgroup = xstrdup (entry + 1);
|
||||
break;
|
||||
}
|
||||
|
||||
xfclose (f);
|
||||
free (line);
|
||||
|
||||
return cgroup;
|
||||
}
|
||||
|
||||
|
||||
/* Called on process re-execution. */
|
||||
static void
|
||||
handle_restart (int argc, char *argv[])
|
||||
{
|
||||
assert (argc == 1);
|
||||
char *newcgroup = argv[0];
|
||||
|
||||
char *current_cgroup = get_cgroup ();
|
||||
TEST_VERIFY_EXIT (current_cgroup != NULL);
|
||||
TEST_COMPARE_STRING (newcgroup, current_cgroup);
|
||||
}
|
||||
|
||||
static int
|
||||
do_test_cgroup_failure (pid_t *pid, int cgroup)
|
||||
{
|
||||
posix_spawnattr_t attr;
|
||||
TEST_COMPARE (posix_spawnattr_init (&attr), 0);
|
||||
TEST_COMPARE (posix_spawnattr_setflags (&attr, POSIX_SPAWN_SETCGROUP), 0);
|
||||
TEST_COMPARE (posix_spawnattr_setcgroup_np (&attr, cgroup), 0);
|
||||
|
||||
int cgetgroup;
|
||||
TEST_COMPARE (posix_spawnattr_getcgroup_np (&attr, &cgetgroup), 0);
|
||||
TEST_COMPARE (cgroup, cgetgroup);
|
||||
|
||||
return posix_spawn (pid, spargs[0], NULL, &attr, spargs, environ);
|
||||
}
|
||||
|
||||
static int
|
||||
create_new_cgroup (char **newcgroup)
|
||||
{
|
||||
struct statfs fs;
|
||||
if (statfs (CGROUPFS, &fs) < 0)
|
||||
{
|
||||
if (errno == ENOENT)
|
||||
FAIL_UNSUPPORTED ("no cgroupv2 mount found");
|
||||
FAIL_EXIT1 ("statfs (%s): %m\n", CGROUPFS);
|
||||
}
|
||||
|
||||
if (!F_TYPE_EQUAL (fs.f_type, CGROUP2_SUPER_MAGIC))
|
||||
FAIL_UNSUPPORTED ("%s is not a cgroupv2 (expected %jx, got %jd)",
|
||||
CGROUPFS, (intmax_t) fs.f_type,
|
||||
(intmax_t) CGROUP2_SUPER_MAGIC);
|
||||
|
||||
char *cgroup = get_cgroup ();
|
||||
TEST_VERIFY_EXIT (cgroup != NULL);
|
||||
*newcgroup = xasprintf ("%s/%s", cgroup, CGROUP_TEST);
|
||||
char *cgpath = xasprintf ("%s%s/%s", CGROUPFS, cgroup, CGROUP_TEST);
|
||||
free (cgroup);
|
||||
|
||||
if (mkdir (cgpath, 0755) == -1 && errno != EEXIST)
|
||||
{
|
||||
if (errno == EACCES || errno == EPERM || errno == EROFS)
|
||||
FAIL_UNSUPPORTED ("can not create a new cgroupv2 group");
|
||||
FAIL_EXIT1 ("mkdir (%s): %m", cgpath);
|
||||
}
|
||||
add_temp_file (cgpath);
|
||||
|
||||
return xopen (cgpath, O_DIRECTORY | O_RDONLY | O_CLOEXEC, 0666);
|
||||
}
|
||||
|
||||
static int
|
||||
do_test (int argc, char *argv[])
|
||||
{
|
||||
/* We must have either:
|
||||
|
||||
- one or four parameters if called initially:
|
||||
+ argv[1]: path for ld.so optional
|
||||
+ argv[2]: "--library-path" optional
|
||||
+ argv[3]: the library path optional
|
||||
+ argv[4]: the application name
|
||||
|
||||
- six parameters left if called through re-execution:
|
||||
+ argv[4/1]: the application name
|
||||
+ argv[5/2]: the created cgroup
|
||||
|
||||
* When built with --enable-hardcoded-path-in-tests or issued without
|
||||
using the loader directly. */
|
||||
|
||||
if (restart)
|
||||
{
|
||||
handle_restart (argc - 1, &argv[1]);
|
||||
return 0;
|
||||
}
|
||||
|
||||
TEST_VERIFY_EXIT (argc == 2 || argc == 5);
|
||||
|
||||
char *newcgroup;
|
||||
int cgroup = create_new_cgroup (&newcgroup);
|
||||
|
||||
int i;
|
||||
for (i = 0; i < argc - 1; i++)
|
||||
spargs[i] = argv[i + 1];
|
||||
spargs[i++] = (char *) "--direct";
|
||||
spargs[i++] = (char *) "--restart";
|
||||
spargs[i++] = (char *) newcgroup;
|
||||
spargs[i] = NULL;
|
||||
|
||||
/* Check if invalid cgroups returns an error. */
|
||||
{
|
||||
int r = do_test_cgroup_failure (NULL, -1);
|
||||
if (r == EOPNOTSUPP)
|
||||
FAIL_UNSUPPORTED ("posix_spawn POSIX_SPAWN_SETCGROUP is not supported");
|
||||
TEST_COMPARE (r, EINVAL);
|
||||
}
|
||||
|
||||
{
|
||||
pid_t pid;
|
||||
TEST_COMPARE (do_test_cgroup_failure (&pid, cgroup), 0);
|
||||
|
||||
siginfo_t sinfo;
|
||||
TEST_COMPARE (waitid (P_PID, pid, &sinfo, WEXITED), 0);
|
||||
TEST_COMPARE (sinfo.si_signo, SIGCHLD);
|
||||
TEST_COMPARE (sinfo.si_code, CLD_EXITED);
|
||||
TEST_COMPARE (sinfo.si_status, 0);
|
||||
}
|
||||
|
||||
xclose (cgroup);
|
||||
free (newcgroup);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#define TEST_FUNCTION_ARGV do_test
|
||||
#include <support/test-driver.c>
|
@ -2582,6 +2582,8 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
GLIBC_2.4 __confstr_chk F
|
||||
GLIBC_2.4 __fgets_chk F
|
||||
GLIBC_2.4 __fgets_unlocked_chk F
|
||||
|
@ -2688,3 +2688,5 @@ GLIBC_2.38 strlcat F
|
||||
GLIBC_2.38 strlcpy F
|
||||
GLIBC_2.38 wcslcat F
|
||||
GLIBC_2.38 wcslcpy F
|
||||
GLIBC_2.39 posix_spawnattr_getcgroup_np F
|
||||
GLIBC_2.39 posix_spawnattr_setcgroup_np F
|
||||
|
Loading…
Reference in New Issue
Block a user