From d942e95cd7e493efbbff58b78e63013c79e634cd Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Wed, 21 Sep 2016 20:52:02 +0000 Subject: [PATCH] Add issubnormal. TS 18661-1 adds an issubnormal classification macro to . This patch implements it for glibc. There are no new underlying functions in libm because the implementation uses fpclassify; any optimizations for this macro should be done through adding __builtin_subnormal in GCC and using it in the header for suitable GCC versions, not through adding other optimized inline or out-of-line versions to glibc. The intended structure of the NEWS entry for features from TS 18661-1 is like: * New features are added from TS 18661-1:2014: - Nearest integer functions: roundeven, roundevenf, roundevenl. - Comparison macros: iseqsig. - Classification macros: iscanonical, issubnormal, iszero. (that is, following the grouping of interfaces in TS 18661-1:2014, with any group where any interfaces are new in glibc 2.25 being listed like that). Tested for x86_64 and x86. * math/math.h [__GLIBC_USE (IEC_60559_BFP_EXT)] (issubnormal): New macro. * math/libm-test.inc (issubnormal_test_data): New array. (issubnormal_test): New function. * manual/arith.texi (Floating Point Classes): Document issubnormal. * manual/libm-err-tab.pl: Update comment on interfaces without ulps tabulated. --- ChangeLog | 9 +++++++++ NEWS | 4 ++++ manual/arith.texi | 8 ++++++++ manual/libm-err-tab.pl | 6 +++--- math/libm-test.inc | 28 +++++++++++++++++++++++++++- math/math.h | 3 +++ 6 files changed, 54 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index fbc38bd073..00162c332a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2016-09-21 Joseph Myers + * math/math.h [__GLIBC_USE (IEC_60559_BFP_EXT)] (issubnormal): New + macro. + * math/libm-test.inc (issubnormal_test_data): New array. + (issubnormal_test): New function. + * manual/arith.texi (Floating Point Classes): Document + issubnormal. + * manual/libm-err-tab.pl: Update comment on interfaces without + ulps tabulated. + * sysdeps/generic/stdint.h: Define __GLIBC_INTERNAL_STARTING_HEADER_IMPLEMENTATION and include instead of including . diff --git a/NEWS b/NEWS index f59a27dee9..23ca5abdbe 100644 --- a/NEWS +++ b/NEWS @@ -49,6 +49,10 @@ Version 2.25 UINTMAX_WIDTH, PTRDIFF_WIDTH, SIG_ATOMIC_WIDTH, SIZE_WIDTH, WCHAR_WIDTH, WINT_WIDTH. +* New features are added from TS 18661-1:2014: + + - Classification macros: issubnormal. + * The header now includes the header. Support for the Linux quota interface which predates kernel version 2.4.22 has been removed. diff --git a/manual/arith.texi b/manual/arith.texi index dc3c367d49..bfa236a50e 100644 --- a/manual/arith.texi +++ b/manual/arith.texi @@ -406,6 +406,14 @@ This macro returns a nonzero value if @var{x} is a signaling NaN (sNaN). It is from TS 18661-1:2014. @end deftypefn +@comment math.h +@comment ISO +@deftypefn {Macro} int issubnormal (@emph{float-type} @var{x}) +@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}} +This macro returns a nonzero value if @var{x} is subnormal. It is +from TS 18661-1:2014. +@end deftypefn + Another set of floating-point classification functions was provided by BSD. @Theglibc{} also supports these functions; however, we recommend that you use the ISO C99 macros in new code. Those are standard diff --git a/manual/libm-err-tab.pl b/manual/libm-err-tab.pl index c2792c50d8..adeadb8f55 100755 --- a/manual/libm-err-tab.pl +++ b/manual/libm-err-tab.pl @@ -77,9 +77,9 @@ use vars qw (%results @all_floats %suffices @all_functions); "nextup", "pow", "remainder", "remquo", "rint", "round", "scalb", "scalbn", "sin", "sincos", "sinh", "sqrt", "tan", "tanh", "tgamma", "trunc", "y0", "y1", "yn" ); -# fpclassify, isnormal, isfinite, isinf, isnan, issignaling, signbit, -# isgreater, isgreaterequal, isless, islessequal, islessgreater, isunordered -# are not tabulated. +# fpclassify, isnormal, isfinite, isinf, isnan, issignaling, +# issubnormal, signbit, isgreater, isgreaterequal, isless, +# islessequal, islessgreater, isunordered are not tabulated. if ($#ARGV == 0) { $sources = $ARGV[0]; diff --git a/math/libm-test.inc b/math/libm-test.inc index e4fcb5a198..385ec5c053 100644 --- a/math/libm-test.inc +++ b/math/libm-test.inc @@ -46,7 +46,7 @@ cbrt, ceil, copysign, cos, cosh, drem, erf, erfc, exp, exp10, exp2, expm1, fabs, fdim, finite, floor, fma, fmax, fmin, fmod, fpclassify, frexp, gamma, hypot, - ilogb, isfinite, isinf, isnan, isnormal, issignaling, + ilogb, isfinite, isinf, isnan, isnormal, issignaling, issubnormal, isless, islessequal, isgreater, isgreaterequal, islessgreater, isunordered, j0, j1, jn, ldexp, lgamma, log, log10, log1p, log2, logb, @@ -8587,6 +8587,31 @@ issignaling_test (void) ALL_RM_TEST (issignaling, 1, issignaling_test_data, RUN_TEST_LOOP_f_b_tg, END); } +static const struct test_f_i_data issubnormal_test_data[] = + { + TEST_f_b (issubnormal, 0, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, minus_zero, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, 10, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, min_subnorm_value, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, -min_subnorm_value, 1, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, min_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, -min_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, max_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, -max_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, plus_infty, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, minus_infty, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, qnan_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, -qnan_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, snan_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + TEST_f_b (issubnormal, -snan_value, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), + }; + +static void +issubnormal_test (void) +{ + ALL_RM_TEST (issubnormal, 1, issubnormal_test_data, RUN_TEST_LOOP_f_b_tg, END); +} + static const struct test_ff_i_data isunordered_test_data[] = { TEST_ff_i (isunordered, minus_zero, minus_zero, 0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED), @@ -12668,6 +12693,7 @@ main (int argc, char **argv) isnan_test (); isnormal_test (); issignaling_test (); + issubnormal_test (); signbit_test (); /* Trigonometric functions: */ diff --git a/math/math.h b/math/math.h index 2f77deec87..064cc56e1b 100644 --- a/math/math.h +++ b/math/math.h @@ -328,6 +328,9 @@ enum : sizeof (x) == sizeof (double) \ ? __issignaling (x) : __issignalingl (x)) # endif + +/* Return nonzero value if X is subnormal. */ +# define issubnormal(x) (fpclassify (x) == FP_SUBNORMAL) #endif /* Use IEC_60559_BFP_EXT. */ #ifdef __USE_MISC