Define __mig_strlen to support dynamically sized strings in hurd RPCs

We make lib{mach,hurd}user.so only call __mig_strlen which can be
relocated before libc.so is relocated, similar to what is done with
__mig_memcpy.
Message-Id: <ZE8DTRDpY2hpPZlJ@jupiter.tail36e24.ts.net>
This commit is contained in:
Flavio Cruz 2023-04-30 20:09:49 -04:00 committed by Samuel Thibault
parent 6eb3edeed2
commit eb14819c14
5 changed files with 31 additions and 2 deletions

View File

@ -25,7 +25,7 @@ headers = mach_init.h mach.h mach_error.h mach-shortcuts.h mach/mach_traps.h \
lock = spin-solid spin-lock mutex-init mutex-solid
lock-headers = lock-intern.h spin-lock.h
routines = $(mach-syscalls) $(mach-shortcuts) \
mach_init mig_strncpy mig_memcpy msg \
mach_init mig_strncpy mig_strlen mig_memcpy msg \
mig-alloc mig-dealloc mig-reply \
msg-destroy msgserver \
mach_error errstring error_compat errsystems \

View File

@ -71,5 +71,6 @@ libc {
GLIBC_PRIVATE {
# functions used by RPC stubs
__mig_memcpy;
__mig_strlen;
}
}

View File

@ -55,5 +55,6 @@ extern vm_size_t mig_strncpy (char *__dst, const char *__src, vm_size_t __len);
extern vm_size_t __mig_strncpy (char *__dst, const char *__src, vm_size_t);
extern void *__mig_memcpy (void *__dst, const void *__src, vm_size_t __len);
extern vm_size_t __mig_strlen (const char *__src);
#endif /* mach/mig_support.h */

26
mach/mig_strlen.c Normal file
View File

@ -0,0 +1,26 @@
/* strlen stub for mig stubs in libmachuser and libhurduser.
Copyright (C) 2023 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <mach.h>
#include <string.h>
vm_size_t
__mig_strlen (const char *src)
{
return strlen (src);
}

View File

@ -9,10 +9,11 @@ libc_hidden_proto (__mig_init)
# include <libc-symbols.h>
# if defined USE_MULTIARCH && (IS_IN (libmachuser) || IS_IN (libhurduser))
/* Avoid directly calling ifunc-enabled memcpy or strpcpy,
/* Avoid directly calling ifunc-enabled memcpy or strlen,
because they would introduce a relocation loop between lib*user and
libc.so. */
# define memcpy(dest, src, n) __mig_memcpy(dest, src, n)
# define strlen(src) __mig_strlen(src)
# endif
#endif