AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-23 11:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not build with -Winline

Browse Source 
-Winline causes architecture- and optimization-dependent build failures
due to -Werror.  -Winline warns about inlining decisions based on
branch hints, in effect preventing the use of inline functions in
header files (because they might be called on unlikely branches, leading
to a decision not to inline).

The option was apparently added to the glibc build at a time when GCC
did not support the always_inline attribute.  With current GCC versions,
inlining failure for functions declared always_inline will receive a
warning under -Wattributes, which is enabled by default, so -Winline
appears unnecessary.
This commit is contained in:
Florian Weimer 2015-04-24 11:10:24 +02:00
parent 8666ab5c42
commit ed159672eb
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
2015-04-24 Florian Weimer <fweimer@redhat.com>
* Makeconfig (+gccwarn): Remove -Winline.
2015-04-24 Stefan Liebler <stli@linux.vnet.ibm.com> 2015-04-24 Stefan Liebler <stli@linux.vnet.ibm.com>
* sysdeps/s390/fpu/libm-test-upls: Regenerate. * sysdeps/s390/fpu/libm-test-upls: Regenerate.

4
Makeconfig
View File

@ -739,9 +739,9 @@ endif
# Extra flags to pass to GCC. # Extra flags to pass to GCC.
ifeq ($(all-warnings),yes) ifeq ($(all-warnings),yes)
+gccwarn := -Wall -Wwrite-strings -Winline -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar +gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar
else else
+gccwarn := -Wall -Wwrite-strings -Winline +gccwarn := -Wall -Wwrite-strings
endif endif
+gccwarn += -Wundef +gccwarn += -Wundef
ifeq ($(enable-werror),yes) ifeq ($(enable-werror),yes)