Recent GCC -Wformat-overflow= changes result in some printf tests
failing to build, because those tests are deliberately testing the
handling of formats writing more than INT_MAX characters and the
handling of NULL arguments to the %s format, which GCC now warns
about. This patch duly disables -Wformat-overflow= for the relevant
calls to printf functions.
Tested with build-many-glibcs.py with GCC mainline for
aarch64-linux-gnu.
* stdio-common/bug22.c: Include <libc-diag.h>.
(do_test): Disable -Wformat-overflow= warnings around fprintf
calls outputting more than INT_MAX characters.
* stdio-common/tst-printf.c: Disable -Wformat-overflow= warnings
around printf call with NULL %s argument.
Fix the ifdef clause that was being used in the opposite way, setting
a wrong value of the carry bit.
This is also correcting 2 memory accesses that were mistakenly referring
to r0 while they were supposed to mean the immediate value 0.
[BZ #22142]
* stdio-common/tst-printf.c (fp_test): Add tests for DBL_MAX and
-DBL_MAX.
(do_test): Likewise.
* stdio-common/tst-printf.sh: Likewise.
* sysdeps/powerpc/powerpc64/power7/add_n.S: Invert the initial
ifdef clause in order to set the carry bit right. Replace r0 by
0 without changing the behavior.
Quite a few tests include libc-internal.h just for the DIAG_* macros.
Split those macros to their own file, which can be included safely in
_ISOMAC mode. I also moved ignore_value, since it seems logically
related, even though I didn't notice any tests needing it.
Also add -Wnonnull suppressions to two tests that _should_ have them,
but the error is masked when compiling against internal headers.
* include/libc-diag.h: New file. Define ignore_value,
DIAG_PUSH_NEEDS_COMMENT, DIAG_POP_NEEDS_COMMENT,
DIAG_IGNORE_NEEDS_COMMENT, and DIAG_IGNORE_Os_NEEDS_COMMENT here.
* include/libc-internal.h: Definitions of above macros moved from
here. Include libc-diag.h. Add copyright notice.
* malloc/tst-malloc.c, malloc/tst-memcheck.c, malloc/tst-realloc.c
* misc/tst-error1.c, posix/tst-dir.c, stdio-common/bug21.c
* stdio-common/scanf14.c, stdio-common/scanf4.c, stdio-common/scanf7.c
* stdio-common/test-vfprintf.c, stdio-common/tst-printf.c
* stdio-common/tst-printfsz.c, stdio-common/tst-sprintf.c
* stdio-common/tst-unlockedio.c, stdio-common/tstdiomisc.c
* stdlib/bug-getcontext.c, string/tester.c, string/tst-endian.c
* time/tst-strptime2.c, wcsmbs/tst-wcstof.c:
Include libc-diag.h instead of libc-internal.h.
* stdlib/tst-environ.c: Include libc-diag.h. Suppress -Wnonnull for
call to unsetenv (NULL).
* nptl/tst-mutex1.c: Include libc-diag.h. Suppress -Wnonnull for
call to pthread_mutexattr_destroy (NULL).
This patch fixes the glibc testsuite build for GCC 7
-Wformat-truncation, newly moved out of -Wformat-length and with some
further warnings that didn't previously appear. Two tests that
previously disabled -Wformat-length are changed to disable
-Wformat-truncation instead; two others are made to disable that
option as well.
Tested (compilation only) with build-many-glibcs.py for aarch64 with
GCC mainline.
* stdio-common/tst-printf.c [__GNUC_PREREQ (7, 0)]: Ignore
-Wformat-truncation instead of -Wformat-length.
* time/tst-strptime2.c (mkbuf) [__GNUC_PREREQ (7, 0)]: Likewise.
* stdio-common/tstdiomisc.c (F): Ignore -Wformat-truncation for
GCC 7.
* wcsmbs/tst-wcstof.c: Include <libc-internal.h>.
(do_test): Ignore -Wformat-truncation for GCC 7.
These tests were skipped by the use-test-skeleton conversion done in
commit 29955b5d because they did not have an `int main (void)'
declaration. Instead their `main' functions were declared with arguments
(i.e. argc, argv) even though they didn't use them.
Remove these arguments and include the test skeleton in these tests.
* stdio-common/vfprintf.c (process_arg): Fix reading of signed
short and byte values from parameter list.
* stdio-common/tst-printf.c (main): Add more tests.
* stdio-common/tst-printf.sh: Adjust for tst-printf.c change.
* stdio-common/tst-printf.c (main): Comment out one test which
checked the compiler's ability to fold floating-point constants
but not really printf.
(rfg3): Make s const.
* stdio-common/tst-printf.sh: Adjust for removed test.
2002-03-13 Wolfram Gloger <wg@malloc.de>
* malloc/malloc.c (sYSMALLOc): Don't change brk if mmap failed.
2002-03-02 Andreas Schwab <schwab@suse.de>
* stdio-common/vfprintf.c (process_arg): Fix decimal format with
'h' flag and positional arg.
* stdio-common/tst-printf.c (rfg3): New function to test
positional arguments.
(main): Fix some warnings.
2002-03-13 Jakub Jelinek <jakub@redhat.com>
* elf/dl-minimal.c (_itoa): Use _itoa_lower_digits_internal if SHARED.
* elf/dl-reloc.c (_dl_reloc_bad_type): Likewise.
2001-07-06 Paul Eggert <eggert@twinsun.com>
* manual/argp.texi: Remove ignored LGPL copyright notice; it's
not appropriate for documentation anyway.
* manual/libc-texinfo.sh: "Library General Public License" ->
"Lesser General Public License".
2001-07-06 Andreas Jaeger <aj@suse.de>
* All files under GPL/LGPL version 2: Place under LGPL version
2.1.
2000-09-24 Ulrich Drepper <drepper@redhat.com>
* stdio-common/vfprintf.c (process_arg): Handle %hhn.
Add missing case in va_arg handling for numbers.
* stdio-common/tst-printf.c (main): Add tests for %hhu and %hhn
handling. Reported by Joseph S. Myers <jsm28@cam.ac.uk>.
2000-07-07 Ulrich Drepper <drepper@redhat.com>
* stdio-common/Makefile (tests): Remove tst-printf here...
(tests-srcs): ...and add it here.
(distribute): Add tst-unbputc.sh and tst-printf.sh.
Add rules to run tst-printf.sh.
* stdio-common/tst-printf.c: Move code around so that there is really
no further output where it's stated.
* stdio-common/tst-printf.sh: New file.
1999-09-24 Andreas Jaeger <aj@suse.de>
* stdio-common/tst-printf.c (main): Add a testcase for large
precision. Reported by Tymm Twillman <tymm@coe.missouri.edu>.
1999-09-24 Andreas Schwab <schwab@suse.de>
* math/bits/mathcalls.h: Fix last change. Also declare __finite.
1999-09-24 Andreas Jaeger <aj@suse.de>
* intl/finddomain.c (_nl_find_domain): Fix memory leak: Free
normalized_codeset. Reported by Belicky Zsolt <zsolt@prolan.hu>.
1999-09-23 Mark Kettenis <kettenis@gnu.org>
* sysdeps/unix/sysv/linux/Makefile [malloc] (CFLAGS-malloc.c): New
variable. Define MORECORE_CLEARS to 2.
* malloc/malloc.c (cALLOc): Correctly handle systems where sbrk
doesn't clear the contents of memory that is reallocated after
decrementing the break value first. Update comment about
MORECORE_CLEARS, explaining the meaning of the values it can be
set to.
Fri Oct 11 19:13:34 1996 Ulrich Drepper <drepper@cygnus.com>
* locale/Makefile (CPPFLAGS): Set CHARMAP_PATH to
"$(i18ndir)/charmaps".
Fri Oct 11 22:12:41 1996 NIIBE Yutaka <gniibe@mri.co.jp>
* sysdeps/unix/sysv/linux/sys/procfs.h: Include <asm/user.h>
to get definition of FPU description struct.
* sysdeps/unix/sysv/linux/Makefile [$(subdir)=socket] (subdir_headers):
Add net/if.h, net/if_ppp.h, net/ppp-comp.h, net/ppp_defs.h,
net/if_arp.h, and net/route.h.
* sysdeps/unix/sysv/linux/net/if_arp.h: New file.
* sysdeps/unix/sysv/linux/net/route.h: New file.
Fri Oct 11 14:49:13 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/stub/readdir_r.c: New file. We need a stub version.
* sysdeps/stub/e_acosl.c: Likewise.
* sysdeps/stub/e_asinl.c: Likewise.
* sysdeps/stub/e_atan2l.c: Likewise.
* sysdeps/stub/e_expl.c: Likewise.
* sysdeps/stub/e_fmodl.c: Likewise.
* sysdeps/stub/e_log10l.c: Likewise.
* sysdeps/stub/e_logl.c: Likewise.
* sysdeps/stub/e_sqrtl.c: Likewise.
* sysdeps/stub/s_atanl.c: Likewise.
* sysdeps/stub/s_log1pl.c: Likewise.
* Makefile (distribute): Add nsswitch.h and netgroup.h.
* nss/Makefile (generated): db-netgrp.c is not generated.
* sysdeps/alpha/Dist: Add stxcpy.S and stxncpy.S.
* Make-dist (+out): Add $(dont_distribute).
Fri Oct 11 00:27:18 1996 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
* stdio-common/Makefile (routines): Add tmpnam_r.
Fri Oct 11 05:32:51 1996 Ulrich Drepper <drepper@cygnus.com>
* version.h: Bump version to 1.96.
Fri Oct 11 18:13:47 1996 Andreas Jaeger <aj@arthur.pfalz.de>
* stdio-common/tst-printf.c: Some more cleanups.
Fri Oct 11 02:48:02 1996 Ulrich Drepper <drepper@cygnus.com>
* resolv/arpa/nameser.h: Update from bind-4.9.5-T6B.
* resolv/resolv.h: Likewise.
* resolv/gethnamaddr.c: Likewise.
* resolv/res_comp.c: Likewise.
* resolv/res_debug.c: Likewise.
* resolv/res_init.c: Likewise.
* resolv/res_send.c: Likewise.
* resolv/Banner: Update version number.
* nss/nss_dns/dns-host.c: Update according to change in
resolv/gethnamaddr.c.
Fri Oct 10 20:52:28 1996 Ralph Loader <loader@maths.ox.ac.uk>
* crypt/md5.c (md5_stream): When reading the block in several
pieces append to instead of replace previously read data.
Thu Oct 10 15:53:17 1996 Richard Henderson <rth@tamu.edu>
* sysdeps/alpha/stxcpy.S ($unaligned): In single word copy, correct
last-byte-written bit for source word misalignment.
* sysdeps/alpha/strchr.c: Removed. There is now an assembler
version.
Thu Oct 10 17:17:23 1996 Ulrich Drepper <drepper@cygnus.com>
* sunrpc/Makefile (rpcsvc): Remove yp.x. The corrected version
comes with glibc-nis.
* sunrpc/rpcsvc/yp.x: Removed.
* nss/nss_files/files-netgr.c (_nss_netgroup_parseline): Test
for *CURSOR to be NULL and dump a core if yes.
Thu Oct 9 20:09:53 1996 Matthew Jacob <mjacob@feral.com>
* sysdeps/unix/sysv/linux/alpha/brk.S: Define _ERRNO_H before
including <errnos.h> to get error numbers.
Thu Oct 10 14:00:01 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/unix/sysv/linux/i386/sigcontext.h: Moved file...
* sysdeps/unix/sysv/linux/sigcontext.h: ...to here. So the
Alpha people find a correct file.
* sysdeps/libm-ieee754/w_cabs.c: We cannot make __cabsl simply
an alias of __cabs since the structures have different names.
* sysdeps/libm-ieee754/w_log10.c: Fix typo in weak_alias.
Reported by Matthew Jacob <mjacob@feral.com>.
simply a wrapper around the <linux/elfcore.h> file since the
Wed Oct 9 00:30:33 1996 Ulrich Drepper <drepper@cygnus.com>
* inet/getnetgrent_r.c: Correct netgroup implementation. A
specification of a netgroup can also name another netgroup.
* nss/nss_files/files-netgrp.c: Likewise.
* inet/netgroup.h: Add fields to hold additional information.
Tue Oct 8 21:51:14 1996 Arnold D. Robbins <arnold@skeeve.atl.ga.us>
* posix/getopt.c: Implement POSIX -W option handling. When the
option string contains "W;" -W foo is handled like --foo.
Tue Oct 8 12:27:26 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/unix/sysv/linux/i386/clone.S: Define _ERRNO_H before
inclusing <errnos.h> so we really get error symbols defined.
* sysdeps/unix/sysv/linux/m68k/clone.S: Likewise.
* sysdeps/unix/sysv/linux/alpha/clone.S: Likewise.
* sunrpc/auth_unix.c (authunix_create_default): Don't use fixed
size array for getgroups call. Instead get maximal number via
sysconf. But discard list to NGRPS elements before calling XDR
function since Sun's code cannot handle longer lists.
Based on a patch by Thorsten Kukuk <kukuk@weber.uni-paderborn.de>.
* sysdeps/stub/e_j0l.c: Define y0l as well.
* sysdeps/stub/e_j1l.c: Define y1l as well.
* sysdeps/stub/e_jnl.c: Define ynl as well.
* posix/unistd.h: Correct prototype for execlp.
* sysdeps/unix/sysv/linux/posix_opt.h: Define _POSIX_NO_TRUNC.
Mon Oct 7 22:18:03 1996 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
* Makeconfig (sysdep-library-path): New variable.
(built-program-cmd): Use it here to properly build a colon
separated library path.
Mon Oct 7 22:11:55 1996 Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>
* crypt/md5-crypt.c (md5_crypt_r): Add missing parens around &
within comparison. Fix comments.
(md5_crypt): Fix comment.
Tue Oct 8 05:10:49 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/unix/sysv/linux/errnos.h: Only include <linux/errnos.h>
when _ERRNO_H is defined.
[!_ERRNO_H && __need_Emath]: Define value for EDOM and ERANGE.
Should there ever be a Linux port where the numeric values are
not 33 and 34 this file must change.
Mon Oct 7 13:54:04 1996 Ulrich Drepper <drepper@cygnus.com>
* libio/iofgets.c (_IO_fgets): Use _IO_flockfile instead of
__flockfile.
Mon Oct 7 11:01:45 1996 Andreas Jaeger <aj@arthur.pfalz.de>
* string/tst-strlen.c (main): Provide prototype.
* malloc/mallocbug.c: Likewise.
* io/test-utime.c: Likewise.
* sysdeps/generic/crypt-entry.c: Correct typo.
Mon Oct 7 13:42:20 1996 Ulrich Drepper <drepper@cygnus.com>
* elf/dl-open.c (_dl_open): Check against _dl_sysdep_start to
test for libc.a. Checking _DYNAMIC is of no worth here.
Suggested by Andreas Schwab <schwab@issan.informatik.uni-dortmund.de>.
* nss/nss_files/files-parse.c: Define LOOKUP_NAME even if
EXTERN_PARSER is defined.
Sat Oct 5 17:05:36 1996 Andreas Jaeger <aj@arthur.pfalz.de>
* Rules (dep-dummy-lib): Correct prototype for __dummy__.
* crypt/md5-crypt.c: Fix typos in comments.
* gmon/gmon.c: Provide prototypes.
* db/makedb.c: Likewise.
* locale/programs/xmalloc.c: Likewise.
* stdio-common/bug11.c (main): Likewise.
* stdio-common/bug7.c (main): Likewise.
* stdio-common/bug8.c (main): Likewise.
* stdio-common/bug9.c (main): Likewise.
* stdio-common/scanf1.c (main): Likewise.
* stdio-common/scanf2.c (main): Likewise.
* stdio-common/scanf5.c (main): Likewise.
* stdio-common/scanf6.c (main): Likewise.
* stdio-common/scanf7.c (main): Likewise.
* stdio-common/scanf8.c (main): Likewise.
* stdio-common/temptest.c (main): Likewise.
* stdio-common/test-fwrite.c (main): Likewise.
* stdio-common/tst-printf.c: Likewise.
* stdio-common/tstdiomisc.c: Likewise.
* stdio-common/tstgetln.c (main): Likewise.
* stdlib/testmb.c (main): Likewise.
* stdio-common/scanf4.c (main): Correct prototype, remove unused
variable n.
* stdio-common/scanf3.c (main): Correct prototype, change
declaration of s to reduce warnings.
* stdio-common/bug10.c (main): Likewise.
* stdio-common/tfformat.c: Provide prototype, remove unused
reference to dump_stats, add braces in sprint_doubles.
* stdio-common/tiformat.c: Likewise.
* stdio-common/test_rdwr.c (main): Parameter `where' is long in
printf call.
Mon Oct 7 14:04:26 1996 NIIBE Yutaka <gniibe@mri.co.jp>
* sysdeps/unix/sysv/linux/sys/soundcard.h: Fix typo.
* shadow/putspent.c: Don't write colon after flag field.
* sysdeps/unix/sysv/linux/net/if_ppp.h: New file. Wrapper around
kernel header.
* sysdeps/unix/sysv/linux/net/ppp-comp.h: Likewise.
* sysdeps/unix/sysv/linux/net/ppp_defs.h: Likewise.
* sysdeps/unix/sysv/linux/Dist: Mention new files.
Mon Oct 7 00:58:19 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/i386/i586/strchr.S: Correct handling of first bytes to
get pointer aligned. Reported by Matthias Urlichs <smurf@noris.de>.
* sysdeps/posix/euidaccess.c [_LIBC]: Avoid calling get?id functions
by using __libc_enable_secure variable.
* sysdeps/libm-i387/s_copysignl.S: Correct loading of return value.
* posix/glob.c (glob_pattern_p): Avoid scanning past eos if
the pattern ends with a backslash and quoting is enabled.
* posix/fnmatch.c (fnmatch): Likewise; return FNM_NOMATCH for such
patterns.
* configure.in: Grok arg --enable-libio.
($stdio = libio): Define USE_IN_LIBIO.
* config.h.in (USE_IN_LIBIO): Add #undef.
* config.make.in (stdio): New variable, set by configure.
* Makeconfig (stdio): New variable.
* stdio.h [USE_IN_LIBIO]: Include libio/stdio.h instead of
stdio/stdio.h.
* stdio-common/Makefile: New file.
* stdio/Makefile: Half the contents moved to stdio-common/Makefile.
* stdio/_itoa.c: Moved to stdio-common.
* stdio/_itoa.h: Moved to stdio-common.
* stdio/asprintf.c: Moved to stdio-common.
* stdio/bug1.c: Moved to stdio-common.
* stdio/bug1.input: Moved to stdio-common.
* stdio/bug2.c: Moved to stdio-common.
* stdio/bug3.c: Moved to stdio-common.
* stdio/bug4.c: Moved to stdio-common.
* stdio/bug5.c: Moved to stdio-common.
* stdio/bug6.c: Moved to stdio-common.
* stdio/bug6.input: Moved to stdio-common.
* stdio/bug7.c: Moved to stdio-common.
* stdio/dprintf.c: Moved to stdio-common.
* stdio/errnobug.c: Moved to stdio-common.
* stdio/getline.c: Moved to stdio-common.
* stdio/getw.c: Moved to stdio-common.
* stdio/perror.c: Moved to stdio-common.
* stdio/printf-parse.h: Moved to stdio-common.
* stdio/printf-prs.c: Moved to stdio-common.
* stdio/printf.c: Moved to stdio-common.
* stdio/printf.h: Moved to stdio-common.
* stdio/printf_fp.c: Moved to stdio-common.
* stdio/psignal.c: Moved to stdio-common.
* stdio/putw.c: Moved to stdio-common.
* stdio/reg-printf.c: Moved to stdio-common.
* stdio/scanf.c: Moved to stdio-common.
* stdio/snprintf.c: Moved to stdio-common.
* stdio/sprintf.c: Moved to stdio-common.
* stdio/sscanf.c: Moved to stdio-common.
* stdio/tempnam.c: Moved to stdio-common.
* stdio/temptest.c: Moved to stdio-common.
* stdio/test-fseek.c: Moved to stdio-common.
* stdio/test-fwrite.c: Moved to stdio-common.
* stdio/test-popen.c: Moved to stdio-common.
* stdio/test_rdwr.c: Moved to stdio-common.
* stdio/tmpfile.c: Moved to stdio-common.
* stdio/tmpnam.c: Moved to stdio-common.
* stdio/tst-fileno.c: Moved to stdio-common.
* stdio/tst-printf.c: Moved to stdio-common.
* stdio/tstgetln.c: Moved to stdio-common.
* stdio/tstgetln.input: Moved to stdio-common.
* stdio/tstscanf.c: Moved to stdio-common.
* stdio/tstscanf.input: Moved to stdio-common.
* stdio/vfprintf.c: Moved to stdio-common.
* stdio/vfscanf.c: Moved to stdio-common.
* stdio/vprintf.c: Moved to stdio-common.
* stdio/xbug.c: Moved to stdio-common.
* sysdeps/generic/Makefile (siglist.c rules): Do this in subdir
stdio-common instead of stdio.
* sysdeps/unix/Makefile (errlist.c rules): Likewise.
* stdio-common/asprintf.c [USE_IN_LIBIO]: Call libio primitive
function.
* stdio-common/dprintf.c: Likewise.
* stdio-common/printf.c: Likewise.
* stdio-common/scanf.c: Likewise.
* stdio-common/snprintf.c: Likewise.
* stdio-common/sprintf.c: Likewise.
* stdio-common/sscanf.c: Likewise.
* stdio-common/vprintf.c: Likewise.
* Makerules: Include $(+depfiles) directly instead of generating
depend-$(subdir).
(depend-$(subdir)): Target removed.
(common-clean): Don't remove depend-$(subdir).
