Commit Graph

4 Commits

Author SHA1 Message Date
Joseph Myers
f7a9f785e5 Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Florian Weimer
79e0d340a9 Revert "tst-res_hconf_reorder: Set RESOLV_REORDER environment variable"
This reverts commit 731a713b72.

This change is unnecessary because the Makefile already sets up the
environment for the test.
2015-12-04 19:25:59 +01:00
Florian Weimer
731a713b72 tst-res_hconf_reorder: Set RESOLV_REORDER environment variable
Otherwise, the problematic code does not run.
2015-12-04 19:02:12 +01:00
Dmitry V. Levin
b57525f1a3 Fix potential hanging of gethostbyaddr_r/gethostbyname_r
When "reorder" resolver option is enabled, threads of a multi-threaded process
could hang in gethostbyaddr_r, gethostbyname_r, or gethostbyname2_r.

Due to a trivial bug in _res_hconf_reorder_addrs, simultaneous
invocations of this function in a multi-threaded process could result to
_res_hconf_reorder_addrs returning without releasing the lock it holds,
causing other threads to block indefinitely while waiting for the lock
that is not going to be released.

[BZ #17977]
* resolv/res_hconf.c (_res_hconf_reorder_addrs): Fix unlocking
when initializing interface list, based on the bug analysis
and the patch proposed by Eric Newton.
* resolv/tst-res_hconf_reorder.c: New test.
* resolv/Makefile [$(have-thread-library) = yes] (tests): Add
tst-res_hconf_reorder.
($(objpfx)tst-res_hconf_reorder): Depend on $(libdl)
and $(shared-thread-library).
(tst-res_hconf_reorder-ENV): New variable.
2015-06-23 09:37:28 +00:00