Commit Graph

689 Commits

Author SHA1 Message Date
Eric Biggers
3d110c7c6e Fix fwrite() reading beyond end of buffer in error path
Partially revert commits 2b766585f9 and
de2fd463b1, which were intended to fix BZ#11741
but caused another, likely worse bug, namely that fwrite() and fputs() could,
in an error path, read data beyond the end of the specified buffer, and
potentially even write this data to the file.

Fix BZ#11741 properly by checking the return value from _IO_padn() in
stdio-common/vfprintf.c.
2013-10-11 22:29:38 +05:30
Allan McRae
3932737df1 Fix memory leaks in libio on allocation failure 2013-09-09 22:52:25 +10:00
Joseph Myers
3f2e46a494 Remove --disable-versioning. 2013-09-04 15:25:42 +00:00
Ondřej Bílka
c0c3f78afb Fix typos. 2013-08-21 19:48:48 +02:00
Joseph Myers
60d2f8f3c7 Use (void) in no-arguments function definitions. 2013-06-08 00:22:23 +00:00
Joseph Myers
2e09a79ada Avoid use of "register" as optimization hint. 2013-06-07 22:24:35 +00:00
Ondrej Bilka
350635a59a Fix leading whitespaces. 2013-06-06 20:36:07 +02:00
Joseph Myers
9c84384cc1 Remove trailing whitespace. 2013-06-05 20:44:03 +00:00
Ondrej Bilka
bae143d270 Initialize wide struct info.
Fixes 15381.

Using wide character function is on byte oriented memstream is undefined
behaviour.  This behaviour was masked by not initializing wide struct
info. We now initialize it to cause a predictable crash.
2013-05-24 08:34:10 +02:00
Siddhesh Poyarekar
5cb26d0aed Fix off-by-one bug in tst-fwrite-error
tst-fwrite-error did not allocate enough space for the string 'world'
and its NULL terminator.  Fixed.
2013-04-15 11:35:43 +05:30
Roland McGrath
f1d70dad53 Remove lots of inline keywords. 2013-02-07 14:44:18 -08:00
H.J. Lu
740b3dbee8 Add --enable-hardcoded-path-in-tests configure option 2013-01-11 07:14:18 -08:00
Joseph Myers
568035b787 Update copyright notices with scripts/update-copyrights. 2013-01-02 19:05:09 +00:00
Joseph Myers
f4cf5f2d8b Add script to update copyright notices and reformat some to facilitate its use. 2013-01-01 16:29:10 +00:00
Mike Frysinger
eb6cbd249f [BZ #12724] libio: revert partial POSIX 2008 fclose support
In BZ #12724, partial support for POSIX 2008 fclose behavior was added.
Since it isn't entirely conforming to the spec, some applications are
known to be breaking in this intermediate state.  So revert the partial
support until we can get things fully implemented.

This reverts commit fcabc0f8b1.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2012-12-01 21:37:52 -05:00
Siddhesh Poyarekar
de2fd463b1 Make fwrite return 0 on EOF 2012-11-28 01:00:50 +05:30
Siddhesh Poyarekar
2b766585f9 printf should return negative value on error
[BZ #11741]
Fixed bug where printf and family may return a spurious success when
printing padded formats.
2012-11-16 19:13:11 +05:30
Siddhesh Poyarekar
b1848fdeec Note in a comment that references to C++ bits are obsolete
libio is not used by libstdc++ anymore, but there are references to
streambuf are all over.
2012-11-16 19:12:28 +05:30
Thomas Schwinge
341dd67392 Change type of constant to avoid a warning.
Warning has been introduced in commit 7583a88d1c.
2012-11-01 17:56:48 +01:00
Joseph Myers
03ac099f6b Define and use $(run-built-tests). 2012-10-24 00:08:46 +00:00
Joseph Myers
ced52c719c Remove _G_OPEN64, _G_LSEEK64, _G_MMAP64, _G_FSTAT64 from _G_config.h. 2012-10-18 18:50:43 +00:00
Joseph Myers
472371b9b0 Remove _IO_pos_t. 2012-10-10 16:05:36 +00:00
Joseph Myers
c8450f70fa Remove _G_off64_t and _G_stat64 from _G_config.h. 2012-10-09 15:09:32 +00:00
Siddhesh Poyarekar
adb26faefe Don't flush write buffer for ftell
[BZ #5298]
Use write pointer state along with the file offset and/or the read
pointers to get the current file position.
2012-09-28 18:38:14 +05:30
Siddhesh Poyarekar
4573c6b098 Adjust wide data buffer pointers during fseek and ftell
[BZ #14543]
Set the internal buffer state correctly whenever the external buffer
state is modified by fseek by either computing the current
_IO_read_ptr/end for the internal buffer based on the new _IO_read_ptr
in the external buffer or converting the content read into the
external buffer, up to the extent of the requested fseek offset.
2012-09-28 18:21:39 +05:30
Joseph Myers
203e56032f Remove various _G_*_t type names. 2012-09-25 12:37:37 +00:00
Siddhesh Poyarekar
2b4f00d1a4 Fix minor typos in comments 2012-09-25 09:28:43 +05:30
Dmitry V. Levin
57c69bef13 Set "fail on error" mode directly in testsuite shell scripts 2012-09-25 02:48:31 +00:00
Joseph Myers
431531094f Remove _G_HAVE_SYS_WAIT and _IO_HAVE_SYS_WAIT. 2012-09-21 10:02:03 +00:00
Joseph Myers
8a26625d21 Remove _G_NEED_STDARG_H. 2012-09-20 14:41:02 +00:00
Joseph Myers
b7aaa4d6d2 Remove _G_HAVE_IO_GETLINE_INFO. 2012-09-17 11:43:06 +00:00
Joseph Myers
ad35fc005b Remove _G_HAVE_PRINTF_FP. 2012-09-13 16:13:09 +00:00
Joseph Myers
28361c5ee4 Remove _G_USING_THUNKS. 2012-09-10 22:05:49 +00:00
Joseph Myers
0e886ef96e Remove libio C++ vtable definitions. 2012-09-10 21:22:42 +00:00
H.J. Lu
bcba7aa24d Run tst-fopenloc if $(build-shared) is yes 2012-09-10 11:13:54 -07:00
Siddhesh Poyarekar
1ffb8c9001 Fix typos in comments
* libio/fileops.c: Fix typos in comments.
        * libio/oldfileops.c: Likewise.
        * libio/wfileops.c: Likewise.
2012-09-05 22:04:57 +05:30
Joseph Myers
60160d83a0 Fix iogetdelim.c (latent) integer overflow (bug 9914). 2012-09-04 11:24:43 +00:00
Roland McGrath
b2e1c56272 Make libio compile without _IO_MTSAFE_IO. 2012-08-17 09:35:36 -07:00
Roland McGrath
c75ccd4c3a Clean up definition of _LIBC_REENTRANT and _IO_MTSAFE_IO. 2012-08-17 09:35:15 -07:00
Roland McGrath
03af952060 Clean up lockf64, fseeko64, ftello64, fgetpos64, fsetpos64 for off64_t == off_t. 2012-08-06 16:48:14 -07:00
Roland McGrath
2747bf9adf Clean up fopen64 for O_LARGEFILE==0. 2012-08-01 16:30:47 -07:00
Roland McGrath
bea9b19322 Fix lots of bitrot for stub configurations. 2012-07-30 16:34:33 -07:00
Andreas Schwab
d18ea0c5e6 Remove use of INTDEF/INTUSE in libio 2012-05-24 23:06:20 +02:00
Thomas Schwinge
dc70356cbf Avoid dup3 PLT usage.
Fixes fallout from 5aa3a74a59.
2012-05-12 10:53:04 +08:00
Thomas Schwinge
37233df9d1 Hurd: #include <kernel-features.h> 2012-05-10 15:57:24 -07:00
Joseph Myers
54b71e0283 Fix conditions on checking versions of dprintf (bug 13775). 2012-05-03 18:42:37 +00:00
Marek Polacek
5ac3ea17df Fix attributes for fortify functions. 2012-04-29 15:34:20 +02:00
Roland McGrath
ec98af7d1b Update comment for _io_write_fn
[BZ #2074]
	* libio/libio.h (__io_write_fn): Update comment.
2012-04-12 21:02:00 +02:00
Jim Meyering
288f9098cb Remove __wur from fwrite, fwrite_unlocked
[BZ #11959]
        * libio/stdio.h (fwrite, fwrite_unlocked): Remove __wur.
        It is not necessarily an error to ignore fwrite's return
        value.  One can reliably use ferror to test for errors after
        the fact.
2012-04-11 21:03:57 +02:00
David S. Miller
20fde22738 Remove xsputn small copy optimization.
* libio/fileops.c (_IO_new_file_xsputn): Don't try to optimize
	small copies by hand.
2012-03-29 14:38:27 -07:00