AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-11-22 13:00:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
30,969 Commits 334 Branches 1,646 Tags 276 MiB
a9b0101475
Commit Graph

15 Commits

Author SHA1 Message Date
Joseph Myers
72d839a42f Fix pow (qNaN, 0) result with -lieee (bug 20919), remove dead parts of wrappers. 
The dbl-64 implementation of __ieee754_pow returns a NaN for pow
(qNaN, 0) when it should return 1.  Normally this is covered up by the
wrappers ending up calling __kernel_standard which fixes up the result
for this case, but for -lieee the wrappers are bypassed and the bad
result gets through as a return value.

Now, the wrappers fixing this are dealing with variant error handling
that wants a result of NaN for pow (qNaN, 0), and only ever call
__kernel_standard for this case if NaN resulted from __ieee754_pow.
This leads to a question of whether the dbl-64 code might be
deliberately returning NaN in order to use those code paths.  However,
I can find no sign that this is deliberate.  If it were deliberate one
would expect other implementations to do the same, and would expect
the return of NaN to be very old, but it appears it came in by
accident when the present e_pow.c implementation replaced an fdlibm
implementation in 2001.  So it appears to be unintended that this path
through the pow wrapper could be used at all.

So this patch fixes the implementation to return 1 in this case as
expected.  This is consistent with all the other implementations.  The
relevant path through the wrappers is now unreachable, so is removed
(which is the main motivation of this patch: to avoid that path
becoming accidentally reachable when implementing TS 18661-1 semantics
that pow (sNaN, 0) should return qNaN with "invalid" raised).  Another
path that would require __ieee754_pow (0, 0) to return 0 is also
unreachable (as all implementations return 1, in accordance with C99
semantics), so is removed as well.

Note: we don't have anything set up to test -lieee, which in any case
is obsolescent (at some point we should remove the ability for new
programs to access _LIB_VERSION or define matherr and have it called
by glibc).  So testing will be implicit through sNaN tests added when
making sNaN inputs work correctly for pow functions.

Tested for x86_64 and x86.

	[BZ #20919]
	* sysdeps/ieee754/dbl-64/e_pow.c (__ieee754_pow): Do not return
	NaN first argument when raised to power 0.
	* math/w_pow.c (__pow): Do not check for NaN or zero results from
	raising to power zero.
	* math/w_powf.c (__powf): Likewise.
	* math/w_powl.c (__powl): Likewise.
	* sysdeps/ieee754/k_standard.c (__kernel_standard): Do not handle
	pow (0, 0) or pow (NaN, 0).
 2016-12-02 22:50:46 +00:00
Joseph Myers
f7a9f785e5 Update copyright dates with scripts/update-copyrights. 2016-01-04 16:05:18 +00:00
Wilco Dijkstra
d81f90ccd0 This patch renames all uses of __isinf*, __isnan*, __finite* and __signbit* to use standard C99 macros. This has no effect on generated code. 2015-06-03 15:41:36 +01:00
Joseph Myers
b168057aaa Update copyright dates with scripts/update-copyrights. 2015-01-02 16:29:47 +00:00
Ondřej Bílka
a1ffb40e32 Use glibc_likely instead __builtin_expect. 2014-02-10 15:07:12 +01:00
Allan McRae
d4697bc93d Update copyright notices with scripts/update-copyrights 2014-01-01 22:00:23 +10:00
Joseph Myers
568035b787 Update copyright notices with scripts/update-copyrights. 2013-01-02 19:05:09 +00:00
Paul Eggert
59ba27a63a Replace FSF snail mail address with URLs. 2012-02-09 23:18:22 +00:00
Ulrich Drepper
0ac5ae2335 Optimize libm 
libm is now somewhat integrated with gcc's -ffinite-math-only option
and lots of the wrapper functions have been optimized.
 2011-10-12 11:27:51 -04:00
Ulrich Drepper
9277c06437 Use private math_private.h in files in math/ 2011-10-08 05:16:04 -04:00
Ulrich Drepper
9d13fb2413 Moved to csu/errno-loc.c. 2005-12-14 15:06:39 +00:00
Ulrich Drepper
a334319f65 (CFLAGS-tst-align.c): Add -mpreferred-stack-boundary=4. 2004-12-22 20:10:10 +00:00
Jakub Jelinek
0ecb606cb6 2.5-18.1 2007-07-12 18:26:36 +00:00
Ulrich Drepper
e275093526 Update. 
* math/w_acos.c: Move to ...
	* sysdeps/generic/w_acos.c: ...here.  New file.
	* math/w_acosf.c: Move to ...
	* sysdeps/generic/w_acosf.c: ...here.  New file.
	* math/w_acosh.c: Move to ...
	* sysdeps/generic/w_acosh.c: ...here.  New file.
	* math/w_acoshf.c: Move to ...
	* sysdeps/generic/w_acoshf.c: ...here.  New file.
	* math/w_acoshl.c: Move to ...
	* sysdeps/generic/w_acoshl.c: ...here.  New file.
	* math/w_acosl.c: Move to ...
	* sysdeps/generic/w_acosl.c: ...here.  New file.
	* math/w_asin.c: Move to ...
	* sysdeps/generic/w_asin.c: ...here.  New file.
	* math/w_asinf.c: Move to ...
	* sysdeps/generic/w_asinf.c: ...here.  New file.
	* math/w_asinl.c: Move to ...
	* sysdeps/generic/w_asinl.c: ...here.  New file.
	* math/w_atan2.c: Move to ...
	* sysdeps/generic/w_atan2.c: ...here.  New file.
	* math/w_atan2f.c: Move to ...
	* sysdeps/generic/w_atan2f.c: ...here.  New file.
	* math/w_atan2l.c: Move to ...
	* sysdeps/generic/w_atan2l.c: ...here.  New file.
	* math/w_atanh.c: Move to ...
	* sysdeps/generic/w_atanh.c: ...here.  New file.
	* math/w_atanhf.c: Move to ...
	* sysdeps/generic/w_atanhf.c: ...here.  New file.
	* math/w_atanhl.c: Move to ...
	* sysdeps/generic/w_atanhl.c: ...here.  New file.
	* math/w_cosh.c: Move to ...
	* sysdeps/generic/w_cosh.c: ...here.  New file.
	* math/w_coshf.c: Move to ...
	* sysdeps/generic/w_coshf.c: ...here.  New file.
	* math/w_coshl.c: Move to ...
	* sysdeps/generic/w_coshl.c: ...here.  New file.
	* math/w_drem.c: Move to ...
	* sysdeps/generic/w_drem.c: ...here.  New file.
	* math/w_dremf.c: Move to ...
	* sysdeps/generic/w_dremf.c: ...here.  New file.
	* math/w_dreml.c: Move to ...
	* sysdeps/generic/w_dreml.c: ...here.  New file.
	* math/w_exp10.c: Move to ...
	* sysdeps/generic/w_exp10.c: ...here.  New file.
	* math/w_exp10f.c: Move to ...
	* sysdeps/generic/w_exp10f.c: ...here.  New file.
	* math/w_exp10l.c: Move to ...
	* sysdeps/generic/w_exp10l.c: ...here.  New file.
	* math/w_exp2.c: Move to ...
	* sysdeps/generic/w_exp2.c: ...here.  New file.
	* math/w_exp2f.c: Move to ...
	* sysdeps/generic/w_exp2f.c: ...here.  New file.
	* math/w_exp2l.c: Move to ...
	* sysdeps/generic/w_exp2l.c: ...here.  New file.
	* math/w_fmod.c: Move to ...
	* sysdeps/generic/w_fmod.c: ...here.  New file.
	* math/w_fmodf.c: Move to ...
	* sysdeps/generic/w_fmodf.c: ...here.  New file.
	* math/w_fmodl.c: Move to ...
	* sysdeps/generic/w_fmodl.c: ...here.  New file.
	* math/w_hypot.c: Move to ...
	* sysdeps/generic/w_hypot.c: ...here.  New file.
	* math/w_hypotf.c: Move to ...
	* sysdeps/generic/w_hypotf.c: ...here.  New file.
	* math/w_hypotl.c: Move to ...
	* sysdeps/generic/w_hypotl.c: ...here.  New file.
	* math/w_j0.c: Move to ...
	* sysdeps/generic/w_j0.c: ...here.  New file.
	* math/w_j0f.c: Move to ...
	* sysdeps/generic/w_j0f.c: ...here.  New file.
	* math/w_j0l.c: Move to ...
	* sysdeps/generic/w_j0l.c: ...here.  New file.
	* math/w_j1.c: Move to ...
	* sysdeps/generic/w_j1.c: ...here.  New file.
	* math/w_j1f.c: Move to ...
	* sysdeps/generic/w_j1f.c: ...here.  New file.
	* math/w_j1l.c: Move to ...
	* sysdeps/generic/w_j1l.c: ...here.  New file.
	* math/w_jn.c: Move to ...
	* sysdeps/generic/w_jn.c: ...here.  New file.
	* math/w_jnf.c: Move to ...
	* sysdeps/generic/w_jnf.c: ...here.  New file.
	* math/w_jnl.c: Move to ...
	* sysdeps/generic/w_jnl.c: ...here.  New file.
	* math/w_lgamma.c: Move to ...
	* sysdeps/generic/w_lgamma.c: ...here.  New file.
	* math/w_lgammaf.c: Move to ...
	* sysdeps/generic/w_lgammaf.c: ...here.  New file.
	* math/w_lgammaf_r.c: Move to ...
	* sysdeps/generic/w_lgammaf_r.c: ...here.  New file.
	* math/w_lgammal.c: Move to ...
	* sysdeps/generic/w_lgammal.c: ...here.  New file.
	* math/w_lgammal_r.c: Move to ...
	* sysdeps/generic/w_lgammal_r.c: ...here.  New file.
	* math/w_lgamma_r.c: Move to ...
	* sysdeps/generic/w_lgamma_r.c: ...here.  New file.
	* math/w_log10.c: Move to ...
	* sysdeps/generic/w_log10.c: ...here.  New file.
	* math/w_log10f.c: Move to ...
	* sysdeps/generic/w_log10f.c: ...here.  New file.
	* math/w_log10l.c: Move to ...
	* sysdeps/generic/w_log10l.c: ...here.  New file.
	* math/w_log.c: Move to ...
	* sysdeps/generic/w_log.c: ...here.  New file.
	* math/w_logf.c: Move to ...
	* sysdeps/generic/w_logf.c: ...here.  New file.
	* math/w_logl.c: Move to ...
	* sysdeps/generic/w_logl.c: ...here.  New file.
	* math/w_pow.c: Move to ...
	* sysdeps/generic/w_pow.c: ...here.  New file.
	* math/w_powf.c: Move to ...
	* sysdeps/generic/w_powf.c: ...here.  New file.
	* math/w_powl.c: Move to ...
	* sysdeps/generic/w_powl.c: ...here.  New file.
	* math/w_remainder.c: Move to ...
	* sysdeps/generic/w_remainder.c: ...here.  New file.
	* math/w_remainderf.c: Move to ...
	* sysdeps/generic/w_remainderf.c: ...here.  New file.
	* math/w_remainderl.c: Move to ...
	* sysdeps/generic/w_remainderl.c: ...here.  New file.
	* math/w_scalb.c: Move to ...
	* sysdeps/generic/w_scalb.c: ...here.  New file.
	* math/w_scalbf.c: Move to ...
	* sysdeps/generic/w_scalbf.c: ...here.  New file.
	* math/w_scalbl.c: Move to ...
	* sysdeps/generic/w_scalbl.c: ...here.  New file.
	* math/w_sinh.c: Move to ...
	* sysdeps/generic/w_sinh.c: ...here.  New file.
	* math/w_sinhf.c: Move to ...
	* sysdeps/generic/w_sinhf.c: ...here.  New file.
	* math/w_sinhl.c: Move to ...
	* sysdeps/generic/w_sinhl.c: ...here.  New file.
	* math/w_sqrtl.c: Move to ...
	* sysdeps/generic/w_sqrtl.c: ...here.  New file.
	* math/w_tgamma.c: Move to ...
	* sysdeps/generic/w_tgamma.c: ...here.  New file.
	* math/w_tgammaf.c: Move to ...
	* sysdeps/generic/w_tgammaf.c: ...here.  New file.
	* math/w_tgammal.c: Move to ...
	* sysdeps/generic/w_tgammal.c: ...here.  New file.
 2001-02-17 01:47:54 +00:00
Ulrich Drepper
abfbdde177 Update. 1999-07-14 00:54:57 +00:00