We stopped adding "Contributed by" or similar lines in sources in 2012
in favour of git logs and keeping the Contributors section of the
glibc manual up to date. Removing these lines makes the license
header a bit more consistent across files and also removes the
possibility of error in attribution when license blocks or files are
copied across since the contributed-by lines don't actually reflect
reality in those cases.
Move all "Contributed by" and similar lines (Written by, Test by,
etc.) into a new file CONTRIBUTED-BY to retain record of these
contributions. These contributors are also mentioned in
manual/contrib.texi, so we just maintain this additional record as a
courtesy to the earlier developers.
The following scripts were used to filter a list of files to edit in
place and to clean up the CONTRIBUTED-BY file respectively. These
were not added to the glibc sources because they're not expected to be
of any use in future given that this is a one time task:
https://gist.github.com/siddhesh/b5ecac94eabfd72ed2916d6d8157e7dchttps://gist.github.com/siddhesh/15ea1f5e435ace9774f485030695ee02
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
I used these shell commands:
../glibc/scripts/update-copyrights $PWD/../gnulib/build-aux/update-copyright
(cd ../glibc && git commit -am"[this commit message]")
and then ignored the output, which consisted lines saying "FOO: warning:
copyright statement not found" for each of 6694 files FOO.
I then removed trailing white space from benchtests/bench-pthread-locks.c
and iconvdata/tst-iconv-big5-hkscs-to-2ucs4.c, to work around this
diagnostic from Savannah:
remote: *** pre-commit check failed ...
remote: *** error: lines with trailing whitespace found
remote: error: hook declined to update refs/heads/master
char array resp. pointer.
* iconvdata/iso-2022-kr.c (BODY): Make buf unsigned char instead of
char array.
* iconvdata/cns11643.h (cns11643_to_ucs4): Change first argument
to const unsigned char **.
(ucs4_to_cns11643): Change second argument to unsigned char *.
* iconvdata/euc-tw.c (BODY): Change endp type to
const unsigned char *.
* iconvdata/iso-ir-165.h (ucs4_to_isoir165): Change second argument
to unsigned char *.
* iconvdata/ibm1008_420.c (LOOP_NEED_FLAGS): Don't define.
* iconvdata/iso-2022-cn.c (BODY): Change buf to unsigned char array.
* iconvdata/iso-2022-cn-ext.c (BODY): Change buf, tmpbuf, tmp
types to unsigned char pointers/arrays instead of char.
* iconvdata/jis0201.h (ucs4_to_jisx0201): Change second argument
to unsigned char *.
* iconvdata/jis0208.h (ucs4_to_jisx0208): Likewise.
* iconvdata/jis0212.h: Include assert.h.
(ucs4_to_jisx0212): Change second argument to unsigned char *.
assert that if cp[0] is not '\0', cp[1] is not '\0' either instead
of trying to handle that.
* iconvdata/euc-kr.c (euckr_from_ucs4): Initialize also cp[1] to
shut up a warning.
* iconvdata/euc-jp-ms.c (from_ucs4_lat1, from_ucs4_greek,
from_ucs4_cjk, from_ucs4_cjkcpt, from_ucs4_extra): Change type to
two dimensional const unsigned char arrays.
(BODY): Cast "" to (const unsigned char *) for assignment to cp.
Initialize endp to inptr to shut up a warning.
IBM1008, IBM1008_420, IBM1097, IBM1112, IBM1123, IBM1130, IBM1140,
IBM1141, IBM1142, IBM1143, IBM1144, IBM1145, IBM1146, IBM1147, IBM1148,
IBM1149, IBM1166, IBM1167, IBM4517, IBM4899, IBM4909, IBM4971,
IBM5347, IBM9030, IBM9066, IBM9448, IBM12712, IBM16804.
(distribute): Add ibm803.c, ibm803.h, ibm901.c, ibm901.h, ibm902.c,
ibm902.h, ibm921.c, ibm921.h, ibm1008.c, ibm1008.h, ibm1008_420.c,
ibm1097.c, ibm1097.h, ibm1112.c, ibm1112.h, ibm1123.c, ibm1123.h,
ibm1130.c, ibm1130.h, ibm1140.c, ibm1140.h, ibm1141.c, ibm1141.h,
ibm1142.c, ibm1142.h, ibm1143.c, ibm1143.h, ibm1144.c, ibm1144.h,
ibm1145.c, ibm1145.h, ibm1146.c, ibm1146.h, ibm1147.c, ibm1147.h,
ibm1148.c, ibm1148.h, ibm1149.c, ibm1149.h, ibm1166.c, ibm1166.h,
ibm1167.c, ibm1167.h, ibm4517.c, ibm4517.h, ibm4899.c, ibm4899.h,
ibm4909.c, ibm4909.h, ibm4971.c, ibm4971.h, ibm5347.c, ibm5347.h,
ibm9030.c, ibm9030.h, ibm9066.c, ibm9066.h, ibm9448.c, ibm9448.h,
ibm12712.c, ibm12712.h, ibm16804.c, ibm16804.h.
* iconvdata/TESTS: Add entries for new modules.
* iconvdata/gconv-modules: Likewise.
* iconvdata/ibm803.c: New file.
* iconvdata/ibm803.h: New file.
* iconvdata/ibm901.c: New file.
* iconvdata/ibm901.h: New file.
* iconvdata/ibm902.c: New file.
* iconvdata/ibm902.h: New file.
* iconvdata/ibm921.c: New file.
* iconvdata/ibm921.h: New file.
* iconvdata/ibm1008.c: New file.
* iconvdata/ibm1008.h: New file.
* iconvdata/ibm1008_420.c: New file.
* iconvdata/ibm1097.c: New file.
* iconvdata/ibm1097.h: New file.
* iconvdata/ibm1112.c: New file.
* iconvdata/ibm1112.h: New file.
* iconvdata/ibm1123.c: New file.
* iconvdata/ibm1123.h: New file.
* iconvdata/ibm1130.c: New file.
* iconvdata/ibm1130.h: New file.
* iconvdata/ibm1140.c: New file.
* iconvdata/ibm1140.h: New file.
* iconvdata/ibm1141.c: New file.
* iconvdata/ibm1141.h: New file.
* iconvdata/ibm1142.c: New file.
* iconvdata/ibm1142.h: New file.
* iconvdata/ibm1143.c: New file.
* iconvdata/ibm1143.h: New file.
* iconvdata/ibm1144.c: New file.
* iconvdata/ibm1144.h: New file.
* iconvdata/ibm1145.c: New file.
* iconvdata/ibm1145.h: New file.
* iconvdata/ibm1146.c: New file.
* iconvdata/ibm1146.h: New file.
* iconvdata/ibm1147.c: New file.
* iconvdata/ibm1147.h: New file.
* iconvdata/ibm1148.c: New file.
* iconvdata/ibm1148.h: New file.
* iconvdata/ibm1149.c: New file.
* iconvdata/ibm1149.h: New file.
* iconvdata/ibm1166.c: New file.
* iconvdata/ibm1166.h: New file.
* iconvdata/ibm1167.c: New file.
* iconvdata/ibm1167.h: New file.
* iconvdata/ibm4517.c: New file.
* iconvdata/ibm4517.h: New file.
* iconvdata/ibm4899.c: New file.
* iconvdata/ibm4899.h: New file.
* iconvdata/ibm4909.c: New file.
* iconvdata/ibm4909.h: New file.
* iconvdata/ibm4971.c: New file.
* iconvdata/ibm4971.h: New file.
* iconvdata/ibm5347.c: New file.
* iconvdata/ibm5347.h: New file.
* iconvdata/ibm9030.c: New file.
* iconvdata/ibm9030.h: New file.
* iconvdata/ibm9066.c: New file.
* iconvdata/ibm9066.h: New file.
* iconvdata/ibm9448.c: New file.
* iconvdata/ibm9448.h: New file.
* iconvdata/ibm12712.c: New file.
* iconvdata/ibm12712.h: New file.
* iconvdata/ibm16804.c: New file.
* iconvdata/ibm16804.h: New file.
* iconvdata/testdata/IBM803: New file.
* iconvdata/testdata/IBM803..UTF8: New file.
* iconvdata/testdata/IBM901: New file.
* iconvdata/testdata/IBM901..UTF8: New file.
* iconvdata/testdata/IBM902: New file.
* iconvdata/testdata/IBM902..UTF8: New file.
* iconvdata/testdata/IBM921: New file.
* iconvdata/testdata/IBM921..UTF8: New file.
* iconvdata/testdata/IBM1008: New file.
* iconvdata/testdata/IBM1008..UTF8: New file.
* iconvdata/testdata/IBM1097: New file.
* iconvdata/testdata/IBM1097..UTF8: New file.
* iconvdata/testdata/IBM1112: New file.
* iconvdata/testdata/IBM1112..UTF8: New file.
* iconvdata/testdata/IBM1123: New file.
* iconvdata/testdata/IBM1123..UTF8: New file.
* iconvdata/testdata/IBM1130: New file.
* iconvdata/testdata/IBM1130..UTF8: New file.
* iconvdata/testdata/IBM1140: New file.
* iconvdata/testdata/IBM1140..UTF8: New file.
* iconvdata/testdata/IBM1141: New file.
* iconvdata/testdata/IBM1141..UTF8: New file.
* iconvdata/testdata/IBM1142: New file.
* iconvdata/testdata/IBM1142..UTF8: New file.
* iconvdata/testdata/IBM1143: New file.
* iconvdata/testdata/IBM1143..UTF8: New file.
* iconvdata/testdata/IBM1144: New file.
* iconvdata/testdata/IBM1144..UTF8: New file.
* iconvdata/testdata/IBM1145: New file.
* iconvdata/testdata/IBM1145..UTF8: New file.
* iconvdata/testdata/IBM1146: New file.
* iconvdata/testdata/IBM1146..UTF8: New file.
* iconvdata/testdata/IBM1147: New file.
* iconvdata/testdata/IBM1147..UTF8: New file.
* iconvdata/testdata/IBM1148: New file.
* iconvdata/testdata/IBM1148..UTF8: New file.
* iconvdata/testdata/IBM1149: New file.
* iconvdata/testdata/IBM1149..UTF8: New file.
* iconvdata/testdata/IBM1166: New file.
* iconvdata/testdata/IBM1166..UTF8: New file.
* iconvdata/testdata/IBM1167: New file.
* iconvdata/testdata/IBM1167..UTF8: New file.
* iconvdata/testdata/IBM4517: New file.
* iconvdata/testdata/IBM4517..UTF8: New file.
* iconvdata/testdata/IBM4899: New file.
* iconvdata/testdata/IBM4899..UTF8: New file.
* iconvdata/testdata/IBM4909: New file.
* iconvdata/testdata/IBM4909..UTF8: New file.
* iconvdata/testdata/IBM4971: New file.
* iconvdata/testdata/IBM4971..UTF8: New file.
* iconvdata/testdata/IBM5347: New file.
* iconvdata/testdata/IBM5347..UTF8: New file.
* iconvdata/testdata/IBM9030: New file.
* iconvdata/testdata/IBM9030..UTF8: New file.
* iconvdata/testdata/IBM9066: New file.
* iconvdata/testdata/IBM9066..UTF8: New file.
* iconvdata/testdata/IBM9448: New file.
* iconvdata/testdata/IBM9448..UTF8: New file.
* iconvdata/testdata/IBM12712: New file.
* iconvdata/testdata/IBM12712..UTF8: New file.
* iconvdata/testdata/IBM16804: New file.
* iconvdata/testdata/IBM16804..UTF8: New file.
* iconvdata/run-iconv-test.sh: Run ASCII->encoding->ASCII suntzus
test only if $subset is N.
