mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
0292b0dd6c
invalid length [Coverity CID 106]. * nss/nss_files/files-key.c (search): Close stream before successful return [Coverity CID 107]. * io/fts.c (fts_open): Don't allocate parent if *argv==NULL [Coverity CID 108]. * sunrpc/rpc_cout.c (inline_struct): Free sizestr after use [Coverity CID 110, 109]. * sunrpc/rpc_scan.c (docppline): Free file string if it is not going to be used [Coverity CID 111]. * sysdeps/unix/sysv/linux/getsourcefilter.c (getsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 112]. * nis/nis_clone_dir.c (nis_clone_directory): Free all memory in error case [Coverity CID 114]. * nis/nis_clone_res.c (nis_clone_result): Free all memory in the error cases [Coverity CID 115]. * sunrpc/rpc_parse.c (get_definition): Free defp if tok == TOK_EOF [Coverity CID 116]. * sysdeps/unix/sysv/linux/setsourcefilter.c (setsourcefilter): Free memory if socket level value cannot be retrieved [Coverity CID 117]. * elf/cache.c (save_cache): Initialize pad to avoid writing uninitialized data to disk. * elf/cache.c (save_cache): Free file_entries_new [Coverity CID 118]. * intl/finddomain.c (_nl_find_domain): Avoid strdup of expand locale name, use strdupa. Remove free call [Coverity CID 119]. * sunrpc/rpc_main.c (generate_guard): Avoid extra allocation and the resulting leak [Coverity CID 121]. * sunrpc/rpc_main.c (mkfile_output): Free all allocated memory [Coverity CID 122]. * sunrpc/rpc_main.c (h_output): Free guard after we are done [Coverity CID 123]. * sunrpc/svc_udp.c (cache_set): Free victim if newbuf allocation fails [Coverity CID 126]. * sunrpc/svc_udp.c (svcudp_enablecache): Free memory in error cases [Coverity CID 127]. * nis/nis_table.c (__create_ib_request): Free ibreq in case strdup fails [Coverity CID 128]. * nis/nis_getservlist.c (nis_getservlist): Free all memory in case of an error [Coverity CID 130, 129]. * nis/nis_print_group_entry.c (nis_print_group_entry): If nis_lookup call failed, return. Free lookup result in error cases [Coverity CID 131]. * nis/nis_removemember.c (nis_removemember): Free all memory in error cases [Coverity CID 132]. * nis/nss_nisplus/nisplus-alias.c (_nss_nisplus_getaliasbyname_r): Always free lookup result [Coverity CID 134]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_gethostton_r): Always free lookup result [Coverity CID 135]. * nis/nss_nisplus/nisplus-ethers.c (_nss_nisplus_getntohost_r): Always free lookup result [Coverity CID 136]. * nis/nss_nisplus/nisplus-network.c (_nss_nisplus_getnetbyaddr_r): Before retrying, free old result [Coverity CID 137]. * nis/nss_nisplus/nisplus-publickey.c (_nss_nisplus_netname2user): Free res in case UID is zero [Coverity CID 138]. * nis/ypclnt.c (yp_update): Always free master string [Coverity CID 140]. * nis/nis_creategroup.c (nis_creategroup): Free all memory in error cases [Coverity CID 143, 142, 141]. * nis/nss_nis/nis-publickey.c (_nss_nis_getpublickey): Free result if yp_match call succeeded [Coverity CID 155]. * nis/nss_nis/nis-publickey.c (_nss_nis_getsecretkey): Free string allocated in yp_match at all times [Coverity CID 157, 156]. * nscd/nscd.c (write_pid): Close stream also if writing failed [Coverity CID 165]. * nis/nis_table.c (nis_add_entry): Move test for NULL parameter ahead of first use [Coverity CID 167]. * nis/nss_nis/nis-alias.c (_nss_nis_getaliasbyname_r): Move test for NULL parameter ahead of first use [Coverity CID 168]. * intl/finddomain.c (_nl_find_domain): We never return NULL if we found the locale [Coverity CID 169]. * inet/getnameinfo.c (getnameinfo): __getservbyport_r does not set herrno [Coverity CID 178]. * nis/nis_checkpoint.c (nis_checkpoint): Don't access and returned freed object [Coverity CID 182].
241 lines
5.5 KiB
C
241 lines
5.5 KiB
C
/* Copyright (C) 1996-1999,2001,2002,2005,2006 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Thorsten Kukuk <kukuk@suse.de>, 1996.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, write to the Free
|
|
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
|
|
02111-1307 USA. */
|
|
|
|
#include <nss.h>
|
|
#include <ctype.h>
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
#include <syslog.h>
|
|
#include <rpc/rpc.h>
|
|
#include <rpcsvc/yp.h>
|
|
#include <rpcsvc/ypclnt.h>
|
|
#include <rpc/key_prot.h>
|
|
extern int xdecrypt (char *, char *);
|
|
|
|
#include "nss-nis.h"
|
|
|
|
/* If we haven't found the entry, we give a SUCCESS and an empty key back.
|
|
Solaris docu says: sizeof (pkey) == HEXKEYBYTES + 1.
|
|
*/
|
|
enum nss_status
|
|
_nss_nis_getpublickey (const char *netname, char *pkey, int *errnop)
|
|
{
|
|
enum nss_status retval;
|
|
char *domain, *result;
|
|
int len;
|
|
|
|
pkey[0] = 0;
|
|
|
|
if (netname == NULL)
|
|
{
|
|
*errnop = EINVAL;
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
|
|
domain = strchr (netname, '@');
|
|
if (!domain)
|
|
{
|
|
*errnop = EINVAL;
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
++domain;
|
|
|
|
retval = yperr2nss (yp_match (domain, "publickey.byname", netname,
|
|
strlen (netname), &result, &len));
|
|
|
|
if (retval != NSS_STATUS_SUCCESS)
|
|
{
|
|
if (retval == NSS_STATUS_TRYAGAIN)
|
|
*errnop = errno;
|
|
return retval;
|
|
}
|
|
|
|
if (result != NULL)
|
|
{
|
|
char *p = strchr (result, ':');
|
|
if (p != NULL)
|
|
*p = 0;
|
|
strncpy (pkey, result, HEXKEYBYTES + 1);
|
|
pkey[HEXKEYBYTES] = '\0';
|
|
free (result);
|
|
}
|
|
return NSS_STATUS_SUCCESS;
|
|
}
|
|
|
|
enum nss_status
|
|
_nss_nis_getsecretkey (const char *netname, char *skey, char *passwd,
|
|
int *errnop)
|
|
{
|
|
enum nss_status retval;
|
|
char buf[2 * (HEXKEYBYTES + 1)];
|
|
char *domain, *result;
|
|
int len;
|
|
|
|
skey[0] = 0;
|
|
|
|
if (netname == NULL || passwd == NULL)
|
|
{
|
|
*errnop = EINVAL;
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
|
|
domain = strchr (netname, '@');
|
|
if (!domain)
|
|
{
|
|
*errnop = EINVAL;
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
++domain;
|
|
|
|
retval = yperr2nss (yp_match (domain, "publickey.byname", netname,
|
|
strlen (netname), &result, &len));
|
|
|
|
if (retval != NSS_STATUS_SUCCESS)
|
|
{
|
|
if (retval == NSS_STATUS_TRYAGAIN)
|
|
*errnop = errno;
|
|
return retval;
|
|
}
|
|
|
|
if (result != NULL)
|
|
{
|
|
char *p = strchr (result, ':');
|
|
if (p != NULL)
|
|
{
|
|
++p;
|
|
strncpy (buf, p, 2 * (HEXKEYBYTES + 1));
|
|
buf[2 * HEXKEYBYTES + 1] = '\0';
|
|
if (xdecrypt (buf, passwd)
|
|
&& memcmp (buf, &(buf[HEXKEYBYTES]), KEYCHECKSUMSIZE) == 0)
|
|
{
|
|
buf[HEXKEYBYTES] = '\0';
|
|
strcpy (skey, buf);
|
|
}
|
|
}
|
|
|
|
free (result);
|
|
}
|
|
return NSS_STATUS_SUCCESS;
|
|
}
|
|
|
|
/* Parse uid and group information from the passed string.
|
|
The format of the string passed is uid:gid,grp,grp, ... */
|
|
static enum nss_status
|
|
parse_netid_str (const char *s, uid_t *uidp, gid_t *gidp, int *gidlenp,
|
|
gid_t *gidlist)
|
|
{
|
|
char *p, *ep;
|
|
int gidlen;
|
|
|
|
if (!s || !isdigit (*s))
|
|
{
|
|
syslog (LOG_ERR, "netname2user: expecting uid '%s'", s);
|
|
return NSS_STATUS_NOTFOUND; /* XXX need a better error */
|
|
}
|
|
|
|
/* Fetch the uid */
|
|
*uidp = strtoul (s, NULL, 10);
|
|
|
|
if (*uidp == 0)
|
|
{
|
|
syslog (LOG_ERR, "netname2user: should not have uid 0");
|
|
return NSS_STATUS_NOTFOUND;
|
|
}
|
|
|
|
/* Now get the group list */
|
|
p = strchr (s, ':');
|
|
if (!p)
|
|
{
|
|
syslog (LOG_ERR, "netname2user: missing group id list in '%s'", s);
|
|
return NSS_STATUS_NOTFOUND;
|
|
}
|
|
++p; /* skip ':' */
|
|
if (!p || (!isdigit (*p)))
|
|
{
|
|
syslog (LOG_ERR, "netname2user: missing group id list in '%s'.", p);
|
|
return NSS_STATUS_NOTFOUND;
|
|
}
|
|
|
|
*gidp = strtoul (p, &ep, 10);
|
|
|
|
gidlen = 0;
|
|
|
|
/* After strtoul() ep should point to the first invalid character.
|
|
This is the marker "," we search for the next value. */
|
|
while (ep != NULL && *ep == ',')
|
|
{
|
|
ep++;
|
|
p = ep;
|
|
gidlist[gidlen++] = strtoul (p, &ep, 10);
|
|
}
|
|
|
|
*gidlenp = gidlen;
|
|
|
|
return NSS_STATUS_SUCCESS;
|
|
}
|
|
|
|
|
|
enum nss_status
|
|
_nss_nis_netname2user (char netname[MAXNETNAMELEN + 1], uid_t *uidp,
|
|
gid_t *gidp, int *gidlenp, gid_t *gidlist, int *errnop)
|
|
{
|
|
char *domain;
|
|
int yperr;
|
|
char *lookup;
|
|
int len;
|
|
|
|
domain = strchr (netname, '@');
|
|
if (!domain)
|
|
{
|
|
*errnop = EINVAL;
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
|
|
/* Point past the '@' character */
|
|
++domain;
|
|
lookup = NULL;
|
|
yperr = yp_match (domain, "netid.byname", netname, strlen (netname),
|
|
&lookup, &len);
|
|
switch (yperr)
|
|
{
|
|
case YPERR_SUCCESS:
|
|
break; /* the successful case */
|
|
case YPERR_DOMAIN:
|
|
case YPERR_KEY:
|
|
return NSS_STATUS_NOTFOUND;
|
|
case YPERR_MAP:
|
|
default:
|
|
return NSS_STATUS_UNAVAIL;
|
|
}
|
|
|
|
if (lookup)
|
|
{
|
|
enum nss_status err;
|
|
|
|
lookup[len] = '\0';
|
|
err = parse_netid_str (lookup, uidp, gidp, gidlenp, gidlist);
|
|
free (lookup);
|
|
return err;
|
|
}
|
|
else
|
|
return NSS_STATUS_NOTFOUND;
|
|
|
|
return NSS_STATUS_SUCCESS;
|
|
}
|