mirror of
https://sourceware.org/git/glibc.git
synced 2025-01-04 00:31:09 +00:00
050f29c188
The existing implementations of lgamma functions (except for the ia64 versions) use the reflection formula for negative arguments. This suffers large inaccuracy from cancellation near zeros of lgamma (near where the gamma function is +/- 1). This patch fixes this inaccuracy. For arguments above -2, there are no zeros and no large cancellation, while for sufficiently large negative arguments the zeros are so close to integers that even for integers +/- 1ulp the log(gamma(1-x)) term dominates and cancellation is not significant. Thus, it is only necessary to take special care about cancellation for arguments around a limited number of zeros. Accordingly, this patch uses precomputed tables of relevant zeros, expressed as the sum of two floating-point values. The log of the ratio of two sines can be computed accurately using log1p in cases where log would lose accuracy. The log of the ratio of two gamma(1-x) values can be computed using Stirling's approximation (the difference between two values of that approximation to lgamma being computable without computing the two values and then subtracting), with appropriate adjustments (which don't reduce accuracy too much) in cases where 1-x is too small to use Stirling's approximation directly. In the interval from -3 to -2, using the ratios of sines and of gamma(1-x) can still produce too much cancellation between those two parts of the computation (and that interval is also the worst interval for computing the ratio between gamma(1-x) values, which computation becomes more accurate, while being less critical for the final result, for larger 1-x). Because this can result in errors slightly above those accepted in glibc, this interval is instead dealt with by polynomial approximations. Separate polynomial approximations to (|gamma(x)|-1)(x-n)/(x-x0) are used for each interval of length 1/8 from -3 to -2, where n (-3 or -2) is the nearest integer to the 1/8-interval and x0 is the zero of lgamma in the relevant half-integer interval (-3 to -2.5 or -2.5 to -2). Together, the two approaches are intended to give sufficient accuracy for all negative arguments in the problem range. Outside that range, the previous implementation continues to be used. Tested for x86_64, x86, mips64 and powerpc. The mips64 and powerpc testing shows up pre-existing problems for ldbl-128 and ldbl-128ibm with large negative arguments giving spurious "invalid" exceptions (exposed by newly added tests for cases this patch doesn't affect the logic for); I'll address those problems separately. [BZ #2542] [BZ #2543] [BZ #2558] * sysdeps/ieee754/dbl-64/e_lgamma_r.c (__ieee754_lgamma_r): Call __lgamma_neg for arguments from -28.0 to -2.0. * sysdeps/ieee754/flt-32/e_lgammaf_r.c (__ieee754_lgammaf_r): Call __lgamma_negf for arguments from -15.0 to -2.0. * sysdeps/ieee754/ldbl-128/e_lgammal_r.c (__ieee754_lgammal_r): Call __lgamma_negl for arguments from -48.0 or -50.0 to -2.0. * sysdeps/ieee754/ldbl-96/e_lgammal_r.c (__ieee754_lgammal_r): Call __lgamma_negl for arguments from -33.0 to -2.0. * sysdeps/ieee754/dbl-64/lgamma_neg.c: New file. * sysdeps/ieee754/dbl-64/lgamma_product.c: Likewise. * sysdeps/ieee754/flt-32/lgamma_negf.c: Likewise. * sysdeps/ieee754/flt-32/lgamma_productf.c: Likewise. * sysdeps/ieee754/ldbl-128/lgamma_negl.c: Likewise. * sysdeps/ieee754/ldbl-128/lgamma_productl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/lgamma_negl.c: Likewise. * sysdeps/ieee754/ldbl-128ibm/lgamma_productl.c: Likewise. * sysdeps/ieee754/ldbl-96/lgamma_negl.c: Likewise. * sysdeps/ieee754/ldbl-96/lgamma_product.c: Likewise. * sysdeps/ieee754/ldbl-96/lgamma_productl.c: Likewise. * sysdeps/generic/math_private.h (__lgamma_negf): New prototype. (__lgamma_neg): Likewise. (__lgamma_negl): Likewise. (__lgamma_product): Likewise. (__lgamma_productl): Likewise. * math/Makefile (libm-calls): Add lgamma_neg and lgamma_product. * math/auto-libm-test-in: Add more tests of lgamma. * math/auto-libm-test-out: Regenerated. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps: Likewise. |
||
|---|---|---|
| .. | ||
| multiarch | ||
| dla.h | ||
| e_acosl.c | ||
| e_atan2l.c | ||
| e_exp2l.S | ||
| e_exp10l.S | ||
| e_expf.S | ||
| e_expl.S | ||
| e_fmodl.S | ||
| e_ilogbl.S | ||
| e_log2l.S | ||
| e_log10l.S | ||
| e_logl.S | ||
| e_powl.S | ||
| e_remainderl.S | ||
| e_scalbl.S | ||
| e_sqrt.c | ||
| e_sqrtf.c | ||
| e_sqrtl.c | ||
| fclrexcpt.c | ||
| fedisblxcpt.c | ||
| feenablxcpt.c | ||
| fegetenv.c | ||
| fegetexcept.c | ||
| fegetround.c | ||
| feholdexcpt.c | ||
| fesetenv.c | ||
| fesetround.c | ||
| feupdateenv.c | ||
| fgetexcptflg.c | ||
| fraiseexcpt.c | ||
| fsetexcptflg.c | ||
| ftestexcept.c | ||
| Implies | ||
| k_rem_pio2l.c | ||
| libm-test-ulps | ||
| Makefile | ||
| math_ldbl.h | ||
| math_private.h | ||
| math-tests-arch.h | ||
| printf_fphex.c | ||
| s_atanl.c | ||
| s_ceill.S | ||
| s_copysign.S | ||
| s_copysignf.S | ||
| s_copysignl.S | ||
| s_cosf.S | ||
| s_expm1l.S | ||
| s_fabs.c | ||
| s_fabsf.c | ||
| s_fabsl.S | ||
| s_fdiml.S | ||
| s_finitel.S | ||
| s_floorl.S | ||
| s_fmax.S | ||
| s_fmaxf.S | ||
| s_fmaxl.S | ||
| s_fmin.S | ||
| s_fminf.S | ||
| s_fminl.S | ||
| s_fpclassifyl.c | ||
| s_isinfl.c | ||
| s_isnanl.c | ||
| s_llrint.S | ||
| s_llrintf.S | ||
| s_llrintl.S | ||
| s_log1pl.S | ||
| s_logbl.c | ||
| s_lrint.S | ||
| s_lrintf.S | ||
| s_lrintl.S | ||
| s_nearbyintl.S | ||
| s_nextafterl.c | ||
| s_nexttoward.c | ||
| s_nexttowardf.c | ||
| s_rintl.c | ||
| s_scalbnl.S | ||
| s_signbit.S | ||
| s_signbitf.S | ||
| s_significandl.c | ||
| s_sincosf.S | ||
| s_sinf.S | ||
| s_truncl.S | ||
| svml_d_cos2_core.S | ||
| svml_d_cos4_core_avx.S | ||
| svml_d_cos4_core.S | ||
| svml_d_cos8_core.S | ||
| svml_d_exp2_core.S | ||
| svml_d_exp4_core_avx.S | ||
| svml_d_exp4_core.S | ||
| svml_d_exp8_core.S | ||
| svml_d_exp_data.h | ||
| svml_d_exp_data.S | ||
| svml_d_log2_core.S | ||
| svml_d_log4_core_avx.S | ||
| svml_d_log4_core.S | ||
| svml_d_log8_core.S | ||
| svml_d_log_data.h | ||
| svml_d_log_data.S | ||
| svml_d_pow2_core.S | ||
| svml_d_pow4_core_avx.S | ||
| svml_d_pow4_core.S | ||
| svml_d_pow8_core.S | ||
| svml_d_pow_data.h | ||
| svml_d_pow_data.S | ||
| svml_d_sin2_core.S | ||
| svml_d_sin4_core_avx.S | ||
| svml_d_sin4_core.S | ||
| svml_d_sin8_core.S | ||
| svml_d_sincos2_core.S | ||
| svml_d_sincos4_core_avx.S | ||
| svml_d_sincos4_core.S | ||
| svml_d_sincos8_core.S | ||
| svml_d_trig_data.h | ||
| svml_d_trig_data.S | ||
| svml_d_wrapper_impl.h | ||
| svml_s_cosf4_core.S | ||
| svml_s_cosf8_core_avx.S | ||
| svml_s_cosf8_core.S | ||
| svml_s_cosf16_core.S | ||
| svml_s_expf4_core.S | ||
| svml_s_expf8_core_avx.S | ||
| svml_s_expf8_core.S | ||
| svml_s_expf16_core.S | ||
| svml_s_expf_data.h | ||
| svml_s_expf_data.S | ||
| svml_s_logf4_core.S | ||
| svml_s_logf8_core_avx.S | ||
| svml_s_logf8_core.S | ||
| svml_s_logf16_core.S | ||
| svml_s_logf_data.h | ||
| svml_s_logf_data.S | ||
| svml_s_powf4_core.S | ||
| svml_s_powf8_core_avx.S | ||
| svml_s_powf8_core.S | ||
| svml_s_powf16_core.S | ||
| svml_s_powf_data.h | ||
| svml_s_powf_data.S | ||
| svml_s_sincosf4_core.S | ||
| svml_s_sincosf8_core_avx.S | ||
| svml_s_sincosf8_core.S | ||
| svml_s_sincosf16_core.S | ||
| svml_s_sinf4_core.S | ||
| svml_s_sinf8_core_avx.S | ||
| svml_s_sinf8_core.S | ||
| svml_s_sinf16_core.S | ||
| svml_s_trig_data.h | ||
| svml_s_trig_data.S | ||
| svml_s_wrapper_impl.h | ||
| test-double-vlen2-wrappers.c | ||
| test-double-vlen2.c | ||
| test-double-vlen4-avx2-wrappers.c | ||
| test-double-vlen4-avx2.c | ||
| test-double-vlen4-wrappers.c | ||
| test-double-vlen4.c | ||
| test-double-vlen8-wrappers.c | ||
| test-double-vlen8.c | ||
| test-float-vlen4-wrappers.c | ||
| test-float-vlen4.c | ||
| test-float-vlen8-avx2-wrappers.c | ||
| test-float-vlen8-avx2.c | ||
| test-float-vlen8-wrappers.c | ||
| test-float-vlen8.c | ||
| test-float-vlen16-wrappers.c | ||
| test-float-vlen16.c | ||
| Versions | ||