glibc/malloc/tst-safe-linking.c
Siddhesh Poyarekar 191e406826 tst-safe-linking: make false positives even more improbable
There is a 1 in 16 chance of a corruption escaping safe-linking and to
guard against spurious failures, tst-safe-linking runs each subtest 10
times to ensure that the chance is reduced to 1 in 2^40.  However, in
the 1 in 16 chance that a corruption does escape safe linking, it
could well be caught by other sanity checks we do in malloc, which
then results in spurious test failures like below:

test test_fastbin_consolidate failed with a different error
  expected: malloc_consolidate(): unaligned fastbin chunk detected

  actual:   malloc_consolidate(): invalid chunk size

This failure is seen more frequently on i686; I was able to reproduce
it in about 5 min of running it in a loop.

Guard against such failures by recording them and retrying the test.
Also, do not fail the test if we happened to get defeated by the 1 in
2^40 odds if in at least one of the instances it was detected by other
checks.

Finally, bolster the odds to 2^64 by running 16 times instead of 10.
The test still has a chance of failure so it is still flaky in theory.
However in practice if we see a failure here then it's more likely
that there's a bug than it being an issue with the test.  Add more
printfs and also dump them to stdout so that in the event the test
actually fails, we will have some data to try and understand why it
may have failed.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2021-07-19 08:29:25 +05:30

199 lines
5.9 KiB
C

/* Test reporting of Safe-Linking caught errors.
Copyright (C) 2020-2021 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <signal.h>
#include <stdint.h>
#include <stdlib.h>
#include <memory.h>
#include <string.h>
#include <time.h>
#include <stdbool.h>
#include <support/capture_subprocess.h>
#include <support/check.h>
/* Run CALLBACK and check that the data on standard error equals
EXPECTED. */
static void
check (const char *test, void (*callback) (void *),
const char *expected)
{
int i, rand_mask;
int success = 0; /* 0 == fail, 1 == other check 2 == safe linking */
/* There is a chance of 1/16 that a corrupted pointer will be aligned.
Try multiple times so that statistical failure will be improbable. */
for (i = 0; i < 16; ++i)
{
rand_mask = rand () & 0xFF;
struct support_capture_subprocess result
= support_capture_subprocess (callback, &rand_mask);
printf ("%s\n", result.out.buffer);
/* Did not crash, could happen. Try again. */
if (strlen (result.err.buffer) == 0)
continue;
/* Crashed, it may either be safe linking or some other check. If it's
not safe linking then try again. */
if (strcmp (result.err.buffer, expected) != 0)
{
printf ("test %s failed with a different error\n"
" expected: %s\n"
" actual: %s\n",
test, expected, result.err.buffer);
success = 1;
continue;
}
TEST_VERIFY (WIFSIGNALED (result.status));
if (WIFSIGNALED (result.status))
TEST_VERIFY (WTERMSIG (result.status) == SIGABRT);
support_capture_subprocess_free (&result);
success = 2;
break;
}
/* The test fails only if the corruption was not caught by any of the malloc
mechanisms in all those iterations. This has a lower than 1 in 2^64
chance of a false positive. */
TEST_VERIFY (success);
}
/* Implementation details must be kept in sync with malloc. */
#define TCACHE_FILL_COUNT 7
#define TCACHE_ALLOC_SIZE 0x20
#define MALLOC_CONSOLIDATE_SIZE 256*1024
/* Try corrupting the tcache list. */
static void
test_tcache (void *closure)
{
int mask = ((int *)closure)[0];
size_t size = TCACHE_ALLOC_SIZE;
printf ("++ tcache ++\n");
/* Populate the tcache list. */
void * volatile a = malloc (size);
void * volatile b = malloc (size);
void * volatile c = malloc (size);
printf ("a=%p, b=%p, c=%p\n", a, b, c);
free (a);
free (b);
free (c);
/* Corrupt the pointer with a random value, and avoid optimizations. */
printf ("Before: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
memset (c, mask & 0xFF, size);
printf ("After: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
c = malloc (size);
printf ("Allocated: c=%p\n", c);
/* This line will trigger the Safe-Linking check. */
b = malloc (size);
printf ("b=%p\n", b);
}
/* Try corrupting the fastbin list. */
static void
test_fastbin (void *closure)
{
int i;
int mask = ((int *)closure)[0];
size_t size = TCACHE_ALLOC_SIZE;
printf ("++ fastbin ++\n");
/* Take the tcache out of the game. */
for (i = 0; i < TCACHE_FILL_COUNT; ++i)
{
void * volatile p = calloc (1, size);
printf ("p=%p\n", p);
free (p);
}
/* Populate the fastbin list. */
void * volatile a = calloc (1, size);
void * volatile b = calloc (1, size);
void * volatile c = calloc (1, size);
printf ("a=%p, b=%p, c=%p\n", a, b, c);
free (a);
free (b);
free (c);
/* Corrupt the pointer with a random value, and avoid optimizations. */
printf ("Before: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
memset (c, mask & 0xFF, size);
printf ("After: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
c = calloc (1, size);
printf ("Allocated: c=%p\n", c);
/* This line will trigger the Safe-Linking check. */
b = calloc (1, size);
printf ("b=%p\n", b);
}
/* Try corrupting the fastbin list and trigger a consolidate. */
static void
test_fastbin_consolidate (void *closure)
{
int i;
int mask = ((int*)closure)[0];
size_t size = TCACHE_ALLOC_SIZE;
printf ("++ fastbin consolidate ++\n");
/* Take the tcache out of the game. */
for (i = 0; i < TCACHE_FILL_COUNT; ++i)
{
void * volatile p = calloc (1, size);
free (p);
}
/* Populate the fastbin list. */
void * volatile a = calloc (1, size);
void * volatile b = calloc (1, size);
void * volatile c = calloc (1, size);
printf ("a=%p, b=%p, c=%p\n", a, b, c);
free (a);
free (b);
free (c);
/* Corrupt the pointer with a random value, and avoid optimizations. */
printf ("Before: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
memset (c, mask & 0xFF, size);
printf ("After: c=%p, c[0]=%p\n", c, ((void **)c)[0]);
/* This line will trigger the Safe-Linking check. */
b = malloc (MALLOC_CONSOLIDATE_SIZE);
printf ("b=%p\n", b);
}
static int
do_test (void)
{
/* Seed the random for the test. */
srand (time (NULL));
check ("test_tcache", test_tcache,
"malloc(): unaligned tcache chunk detected\n");
check ("test_fastbin", test_fastbin,
"malloc(): unaligned fastbin chunk detected 2\n");
check ("test_fastbin_consolidate", test_fastbin_consolidate,
"malloc_consolidate(): unaligned fastbin chunk detected\n");
return 0;
}
#include <support/test-driver.c>