mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-25 22:40:05 +00:00
06d97e5e61
For 32-bit MIPS and some other systems, various of the lrint, llrint, lround, llround functions can be missing exceptions on overflow because casts do not (in current GCC) result in the proper exceptions. In the MIPS case there are two problems here: MIPS I code generation uses an assembler macro that doesn't raise exceptions, while the libgcc conversions of floating-point values to long long also do not raise "invalid" on all overflow cases (and can raise spurious "inexact"). This patch adds support in the generic code (only the functions for which this problem has actually been seen) for forcing the "invalid" exception in the problem cases, and enables that support for the affected MIPS cases. Tested for MIPS; also tested for x86_64 and x86 that installed stripped shared libraries are unchanged by this patch. [BZ #16399] * sysdeps/generic/fix-fp-int-convert-overflow.h: New file. * sysdeps/ieee754/dbl-64/s_llrint.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__llrint) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_llround.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__llround) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_lrint.c: Include <fix-fp-int-convert-overflow.h>. (__lrint) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_lround.c: Include <fix-fp-int-convert-overflow.h>. (__lround) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_llrintf.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__llrintf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_llroundf.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__llroundf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_lrintf.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__lrintf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_lroundf.c: Include <fenv.h>, <limits.h> and <fix-fp-int-convert-overflow.h>. (__lroundf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h: New file.
87 lines
2.1 KiB
C
87 lines
2.1 KiB
C
/* Round argument to nearest integral value according to current rounding
|
|
direction.
|
|
Copyright (C) 1997-2015 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <fenv.h>
|
|
#include <limits.h>
|
|
#include <math.h>
|
|
|
|
#include <math_private.h>
|
|
#include <fix-fp-int-convert-overflow.h>
|
|
|
|
static const float two23[2] =
|
|
{
|
|
8.3886080000e+06, /* 0x4B000000 */
|
|
-8.3886080000e+06, /* 0xCB000000 */
|
|
};
|
|
|
|
|
|
long long int
|
|
__llrintf (float x)
|
|
{
|
|
int32_t j0;
|
|
u_int32_t i0;
|
|
float w;
|
|
float t;
|
|
long long int result;
|
|
int sx;
|
|
|
|
GET_FLOAT_WORD (i0, x);
|
|
|
|
sx = i0 >> 31;
|
|
j0 = ((i0 >> 23) & 0xff) - 0x7f;
|
|
i0 &= 0x7fffff;
|
|
i0 |= 0x800000;
|
|
|
|
if (j0 < (int32_t) (sizeof (long long int) * 8) - 1)
|
|
{
|
|
if (j0 >= 23)
|
|
result = (long long int) i0 << (j0 - 23);
|
|
else
|
|
{
|
|
w = math_narrow_eval (two23[sx] + x);
|
|
t = w - two23[sx];
|
|
GET_FLOAT_WORD (i0, t);
|
|
j0 = ((i0 >> 23) & 0xff) - 0x7f;
|
|
i0 &= 0x7fffff;
|
|
i0 |= 0x800000;
|
|
|
|
result = (j0 < 0 ? 0 : i0 >> (23 - j0));
|
|
}
|
|
}
|
|
else
|
|
{
|
|
#ifdef FE_INVALID
|
|
/* The number is too large. Unless it rounds to LLONG_MIN,
|
|
FE_INVALID must be raised and the return value is
|
|
unspecified. */
|
|
if (FIX_FLT_LLONG_CONVERT_OVERFLOW && x != (float) LLONG_MIN)
|
|
{
|
|
feraiseexcept (FE_INVALID);
|
|
return sx == 0 ? LLONG_MAX : LLONG_MIN;
|
|
}
|
|
#endif
|
|
return (long long int) x;
|
|
}
|
|
|
|
return sx ? -result : result;
|
|
}
|
|
|
|
weak_alias (__llrintf, llrintf)
|