mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-24 03:31:07 +00:00
0bf061d3e3
Bug 16516 reports spurious underflows from erf (for all floating-point types), when the result is close to underflowing but does not actually underflow. erf (x) is about (2/sqrt(pi))*x for x close to 0, so there are subnormal arguments for which it does not underflow. The various implementations do (x + efx*x) (for efx = 2/sqrt(pi) - 1), for greater accuracy than if just using a single multiplication by an approximation to 2/sqrt(pi) (effectively, this way there are a few more bits in the approximation to 2/sqrt(pi)). This can introduce underflows when efx*x underflows even though the final result does not, so a scaled calculation with 8*efx is done in these cases - but 8 is not a big enough scale factor to avoid all such underflows. 16 is (any underflows with a scale factor of 16 would only occur when the final result underflows), so this patch changes the code to use that factor. Rather than recomputing all the values of the efx8 variable, it is removed, leaving it to the compiler's constant folding to compute 16*efx. As such scaling can also lose underflows when the final scaling down happens to be exact, appropriate checks are added to ensure underflow exceptions occur when required in such cases. Tested x86_64 and x86; no ulps updates needed. Also spot-checked for powerpc32 and mips64 to verify the changes to the ldbl-128ibm and ldbl-128 implementations. [BZ #16516] * sysdeps/ieee754/dbl-64/s_erf.c (efx8): Remove variable. (__erf): Scale by 16 instead of 8 in potentially underflowing case. Ensure exception if result actually underflows. * sysdeps/ieee754/flt-32/s_erff.c (efx8): Remove variable. (__erff): Scale by 16 instead of 8 in potentially underflowing case. Ensure exception if result actually underflows. * sysdeps/ieee754/ldbl-128/s_erfl.c: Include <float.h>. (efx8): Remove variable. (__erfl): Scale by 16 instead of 8 in potentially underflowing case. Ensure exception if result actually underflows. * sysdeps/ieee754/ldbl-128ibm/s_erfl.c: Include <float.h>. (efx8): Remove variable. (__erfl): Scale by 16 instead of 8 in potentially underflowing case. Ensure exception if result actually underflows. * sysdeps/ieee754/ldbl-96/s_erfl.c: Include <float.h>. (efx8): Remove variable. (__erfl): Scale by 16 instead of 8 in potentially underflowing case. Ensure exception if result actually underflows. * math/auto-libm-test-in: Add more tests of erf. * math/auto-libm-test-out: Regenerated. |
||
|---|---|---|
| .. | ||
| e_acosf.c | ||
| e_acoshf.c | ||
| e_asinf.c | ||
| e_atan2f.c | ||
| e_atanhf.c | ||
| e_coshf.c | ||
| e_exp2f.c | ||
| e_expf.c | ||
| e_fmodf.c | ||
| e_gammaf_r.c | ||
| e_hypotf.c | ||
| e_ilogbf.c | ||
| e_j0f.c | ||
| e_j1f.c | ||
| e_jnf.c | ||
| e_lgammaf_r.c | ||
| e_log2f.c | ||
| e_log10f.c | ||
| e_logf.c | ||
| e_powf.c | ||
| e_rem_pio2f.c | ||
| e_remainderf.c | ||
| e_sinhf.c | ||
| e_sqrtf.c | ||
| k_cosf.c | ||
| k_rem_pio2f.c | ||
| k_sinf.c | ||
| k_tanf.c | ||
| math_private.h | ||
| mpn2flt.c | ||
| s_asinhf.c | ||
| s_atanf.c | ||
| s_cbrtf.c | ||
| s_ceilf.c | ||
| s_copysignf.c | ||
| s_cosf.c | ||
| s_erff.c | ||
| s_expm1f.c | ||
| s_fabsf.c | ||
| s_finitef.c | ||
| s_floorf.c | ||
| s_fpclassifyf.c | ||
| s_frexpf.c | ||
| s_isinf_nsf.c | ||
| s_isinff.c | ||
| s_isnanf.c | ||
| s_issignalingf.c | ||
| s_llrintf.c | ||
| s_llroundf.c | ||
| s_log1pf.c | ||
| s_logbf.c | ||
| s_lrintf.c | ||
| s_lroundf.c | ||
| s_modff.c | ||
| s_nearbyintf.c | ||
| s_nextafterf.c | ||
| s_remquof.c | ||
| s_rintf.c | ||
| s_roundf.c | ||
| s_scalblnf.c | ||
| s_scalbnf.c | ||
| s_signbitf.c | ||
| s_sincosf.c | ||
| s_sinf.c | ||
| s_tanf.c | ||
| s_tanhf.c | ||
| s_truncf.c | ||
| t_exp2f.h | ||
| w_expf.c | ||