mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-26 23:10:06 +00:00
9173e3c0b4
Removing the use of -Wno-uninitialized for math/ shows errors for
ldbl-128ibm:
../sysdeps/ieee754/ldbl-128ibm/s_nearbyintl.c: In function '__nearbyintl':
../sysdeps/ieee754/ldbl-128ibm/s_nearbyintl.c:119:34: error: 'low' may be used uninitialized in this function [-Werror=maybe-uninitialized]
u.d[1].d = high - u.d[0].d + low;
^
../sysdeps/ieee754/ldbl-128ibm/s_nearbyintl.c:119:23: error: 'high' may be used uninitialized in this function [-Werror=maybe-uninitialized]
u.d[1].d = high - u.d[0].d + low;
^
These errors are correct: if the high part of the argument is a NaN,
and the low part is nonzero but has absolute value less than 2^52,
those variables can be used uninitialized. This patch rearranges the
code so that the variables are always initialized with the natural
values, and then possibly modified later, to avoid this uninitialized
use. (Note that there are still other issues with this code and NaNs
that are not fixed by this patch.) No bug filed in Bugzilla or
testcase added for the uninitialized use since it wasn't user-visible
with the compiler I tried (that is, I still got a NaN result).
Tested for powerpc.
* sysdeps/ieee754/ldbl-128ibm/s_nearbyintl.c: Always initialize
variables for high and low parts before possibly modifying them.
|
||
|---|---|---|
| .. | ||
| bits | ||
| dbl-64 | ||
| flt-32 | ||
| ldbl-64-128 | ||
| ldbl-96 | ||
| ldbl-128 | ||
| ldbl-128ibm | ||
| ldbl-opt | ||
| ieee754.h | ||
| k_standard.c | ||
| k_standardf.c | ||
| k_standardl.c | ||
| Makefile | ||
| s_lib_version.c | ||
| s_matherr.c | ||
| s_signgam.c | ||