Go to file
Letu Ren 0cc0033ef1 stdlib/strfrom: Add copysign to fix NAN issue on riscv (BZ #29501)
According to the specification of ISO/IEC TS 18661-1:2014,

The strfromd, strfromf, and strfroml functions are equivalent to
snprintf(s, n, format, fp) (7.21.6.5), except the format string contains only
the character %, an optional precision that does not contain an asterisk *, and
one of the conversion specifiers a, A, e, E, f, F, g, or G, which applies to
the type (double, float, or long double) indicated by the function suffix
(rather than  by a length modifier). Use of these functions with any other 20
format string results in undefined behavior.

strfromf will convert the arguement with type float to double first.

According to the latest version of IEEE754 which is published in 2019,

Conversion of a quiet NaN from a narrower format to a wider format in the same
radix, and then back to the same narrower format, should not change the quiet
NaN payload in any way except to make it canonical.

When either an input or result is a NaN, this standard does not interpret the
sign of a NaN. However, operations on bit strings—copy, negate, abs,
copySign—specify the sign bit of a NaN result, sometimes based upon the sign
bit of a NaN operand. The logical predicates totalOrder and isSignMinus are
also affected by the sign bit of a NaN operand. For all other operations, this
standard does not specify the sign bit of a NaN result, even when there is only
one input NaN, or when the NaN is produced from an invalid operation.

converting NAN or -NAN with type float to double doesn't need to keep
the signbit. As a result, this test case isn't mandatory.

The problem is that according to RISC-V ISA manual in chapter 11.3 of
riscv-isa-20191213,

Except when otherwise stated, if the result of a floating-point operation is
NaN, it is the canonical NaN. The canonical NaN has a positive sign and all
significand bits clear except the MSB, a.k.a. the quiet bit. For
single-precision floating-point, this corresponds to the pattern 0x7fc00000.

which means that conversion -NAN from float to double won't keep the signbit.

Since glibc ought to be consistent here between types and architectures, this
patch adds copysign to fix this problem if the string is NAN. This patch
adds two different functions under sysdeps directory to work around the
issue.

This patch has been tested on x86_64 and riscv64.

Resolves: BZ #29501

v2: Change from macros to different inline functions.
v3: Add unlikely check to isnan.
v4: Fix wrong commit message header.
v5: Fix style: add space before parentheses.
v6: Add copyright.
Signed-off-by: Letu Ren <fantasquex@gmail.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
2022-10-28 11:35:20 -03:00
argp argp: Remove old includes in !_LIBC case 2022-07-04 15:25:18 +02:00
assert Use atomic_exchange_release/acquire 2022-09-26 16:58:08 +01:00
benchtests Bench: Improve benchtests for memchr, strchr, strnlen, strrchr 2022-10-19 17:31:03 -07:00
bits Expose all MAP_ constants in <sys/mman.h> unconditionally (bug 29375) 2022-10-10 09:30:24 +02:00
catgets Use '%z' instead of '%Z' on printf functions 2022-09-22 08:48:04 -03:00
ChangeLog.old Create ChangeLog.old/ChangeLog.25. 2022-07-29 18:03:09 -04:00
conform hurd: drop SA_SIGINFO availability xfail 2022-01-15 17:43:07 +01:00
crypt crypt: Remove unused variable on cert test 2022-03-31 09:00:54 -03:00
csu csu: Disable stack protector for static-reloc for static-pie 2022-10-06 12:52:46 -03:00
ctype Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
debug Fix invalid pointer dereference in wcpcpy_chk 2022-10-28 11:15:28 +01:00
dirent associate a deallocation for opendir 2022-03-14 20:02:46 +05:30
dlfcn dlfcn: Pass caller pointer to static dlopen implementation (bug 29446) 2022-08-04 17:54:48 +02:00
elf Fix off-by-one OOB read in elf/tst-tls20 2022-10-28 11:16:51 +01:00
gmon Use '%z' instead of '%Z' on printf functions 2022-09-22 08:48:04 -03:00
gnulib Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
grp Add access function attributes to grp and shadow headers 2022-03-14 20:02:30 +05:30
gshadow Add access function attributes to grp and shadow headers 2022-03-14 20:02:30 +05:30
hesiod Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
htl Use C11 atomics instead of atomic_decrement_and_test 2022-09-23 15:59:56 +01:00
hurd Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
iconv Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
iconvdata gconv: Correct Big5-HKSCS conversion to preserve all state bits. [BZ #25744] 2022-07-06 09:27:13 -03:00
include malloc: Use uintptr_t in alloc_buffer 2022-10-28 11:16:09 +01:00
inet Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
intl intl: Avoid -Wuse-after-free [BZ #26779] 2022-01-25 17:38:31 -07:00
io grep: egrep -> grep -E, fgrep -> grep -F 2022-06-05 12:09:02 -07:00
libio Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
locale locale: prevent maybe-uninitialized errors with -Os [BZ #19444] 2022-10-05 18:04:13 -03:00
localedata Update to Unicode 15.0.0 [BZ #29604] 2022-10-06 08:58:33 +02:00
login Update copyright dates not handled by scripts/update-copyrights. 2022-01-01 11:42:26 -08:00
mach Use atomic_exchange_release/acquire 2022-09-26 16:58:08 +01:00
malloc malloc: Use uintptr_t in alloc_buffer 2022-10-28 11:16:09 +01:00
manual manual: Add missing % in int conversion list 2022-10-25 09:12:30 +02:00
math Fix iseqsig for _FloatN and _FloatNx in C++ with GCC 13 2022-09-30 19:36:41 +00:00
mathvec Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
misc Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
nis nis: Fix nis_print_directory 2022-10-20 10:54:27 -03:00
nptl linux: Avoid shifting a negative signed on POSIX timer interface 2022-10-20 10:19:08 -03:00
nptl_db nptl_db: disable DT_RELR on libthread_db.so 2022-06-08 11:17:47 -05:00
nscd nscd: Drop local address tuple variable [BZ #29607] 2022-10-04 18:40:25 -04:00
nss Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
po Update libc.pot for 2.36 release. 2022-07-29 16:41:57 -04:00
posix posix: Suppress -Os may be used uninitialized warnings on regexec 2022-10-05 18:04:13 -03:00
pwd Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
resolv resolv: Fix building tst-resolv-invalid-cname for earlier C standards 2022-08-30 14:04:12 +02:00
resource Fix resource/bug-ulimit1 test 2022-10-28 11:17:18 +01:00
rt rt: Initialize mq_send input on tst-mqueue{5,6} 2022-10-05 18:04:13 -03:00
scripts scripts: Use bool in tunables initializer 2022-10-28 11:14:54 +01:00
setjmp Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
shadow Add access function attributes to grp and shadow headers 2022-03-14 20:02:30 +05:30
signal Refactor internal-signals.h 2022-06-30 14:56:21 -03:00
socket socket: Use offsetof in SUN_LEN (bug 29578) 2022-10-10 09:30:26 +02:00
soft-fp soft-fp: Add fixhf[uns][di|si] and float[uns][di|si]hf 2022-08-08 11:28:40 -03:00
stdio-common Fix missing NUL terminator in stdio-common/scanf13 test 2022-10-28 11:16:51 +01:00
stdlib stdlib/strfrom: Add copysign to fix NAN issue on riscv (BZ #29501) 2022-10-28 11:35:20 -03:00
string String: Improve test coverage for memchr 2022-10-18 09:10:33 -07:00
sunrpc sunrpc: Suppress GCC -Os warning on user2netname 2022-10-05 18:04:13 -03:00
support support: Add xpthread_cond_signal wrapper 2022-10-03 11:19:36 -03:00
sysdeps stdlib/strfrom: Add copysign to fix NAN issue on riscv (BZ #29501) 2022-10-28 11:35:20 -03:00
sysvipc Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
termios posix: Add terminal control setting support for posix_spawn 2022-01-25 14:07:53 -03:00
time Use '%z' instead of '%Z' on printf functions 2022-09-22 08:48:04 -03:00
timezone timezone: Fix tst-bz28707 Makefile rule 2022-01-12 10:30:10 -03:00
wcsmbs Use PTR_MANGLE and PTR_DEMANGLE unconditionally in C sources 2022-10-18 17:04:10 +02:00
wctype Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
.clang-format Add .clang-format style file 2022-04-11 10:51:03 -05:00
.gitattributes Assume __NR_openat is always defined 2016-03-23 23:35:08 +01:00
.gitignore Add *.pyc to .gitignore 2015-05-18 15:26:26 +05:30
abi-tags Remove the bulk of the NaCl port. 2017-05-20 08:09:10 -04:00
aclocal.m4 grep: egrep -> grep -E, fgrep -> grep -F 2022-06-05 12:09:02 -07:00
config.h.in LoongArch: Add LoongArch entries to config.h.in 2022-07-26 12:35:12 -03:00
config.make.in Revert "Detect ld.so and libc.so version inconsistency during startup" 2022-08-25 18:46:43 +02:00
configure Revert "Detect ld.so and libc.so version inconsistency during startup" 2022-08-25 18:46:43 +02:00
configure.ac Revert "Detect ld.so and libc.so version inconsistency during startup" 2022-08-25 18:46:43 +02:00
CONTRIBUTED-BY Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
COPYING Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
COPYING.LIB Update to latest versions of GPL-2.0 and LGPL-2.1 2013-09-09 12:52:48 +10:00
extra-lib.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
gen-locales.mk Improve gen-locales.mk and gen-locale.sh to make test files with @ options work 2018-02-27 17:01:57 +01:00
INSTALL Revert "Detect ld.so and libc.so version inconsistency during startup" 2022-08-25 18:46:43 +02:00
libc-abis riscv: support GNU indirect function 2021-01-10 21:25:13 -05:00
libof-iterator.mk Rename cppflags-iterator.mk to libof-iterator.mk, remove extra-modules.mk. 2017-05-09 07:06:29 -04:00
LICENSES arc4random: simplify design for better safety 2022-07-27 08:58:27 -03:00
MAINTAINERS Add MAINTAINERS 2017-05-11 13:38:30 -04:00
Makeconfig Remove lingering libSegfault Makefile entries 2022-10-26 15:55:43 -03:00
Makefile grep: egrep -> grep -E, fgrep -> grep -F 2022-06-05 12:09:02 -07:00
Makefile.help Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
Makefile.in New make target to only build benchmark binaries 2016-04-20 10:23:28 +05:30
Makerules Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564] 2022-09-13 13:45:32 -04:00
NEWS NEWS: Fix grammar 2022-10-06 13:19:33 +02:00
o-iterator.mk Fri Mar 17 12:58:37 1995 Roland McGrath <roland@churchy.gnu.ai.mit.edu> 1995-03-17 18:42:51 +00:00
README LoongArch: Update NEWS and README for the LoongArch port. 2022-07-26 12:35:12 -03:00
Rules Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
SHARED-FILES Mention today's regex merge in SHARED-FILES 2021-09-21 18:00:10 -07:00
shlib-versions nss: Do not mention NSS test modules in <gnu/lib-names.h> 2022-03-11 08:24:04 +01:00
test-skeleton.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
version.h Open master branch for glibc 2.37 development 2022-07-30 15:34:51 -04:00

This directory contains the sources of the GNU C Library.
See the file "version.h" for what release version you have.

The GNU C Library is the standard system C library for all GNU systems,
and is an important part of what makes up a GNU system.  It provides the
system API for all programs written in C and C-compatible languages such
as C++ and Objective C; the runtime facilities of other programming
languages use the C library to access the underlying operating system.

In GNU/Linux systems, the C library works with the Linux kernel to
implement the operating system behavior seen by user applications.
In GNU/Hurd systems, it works with a microkernel and Hurd servers.

The GNU C Library implements much of the POSIX.1 functionality in the
GNU/Hurd system, using configurations i[4567]86-*-gnu.

When working with Linux kernels, this version of the GNU C Library
requires Linux kernel version 3.2 or later.

Also note that the shared version of the libgcc_s library must be
installed for the pthread library to work correctly.

The GNU C Library supports these configurations for using Linux kernels:

	aarch64*-*-linux-gnu
	alpha*-*-linux-gnu
	arc*-*-linux-gnu
	arm-*-linux-gnueabi
	csky-*-linux-gnuabiv2
	hppa-*-linux-gnu
	i[4567]86-*-linux-gnu
	x86_64-*-linux-gnu	Can build either x86_64 or x32
	ia64-*-linux-gnu
	loongarch64-*-linux-gnu Hardware floating point, LE only.
	m68k-*-linux-gnu
	microblaze*-*-linux-gnu
	mips-*-linux-gnu
	mips64-*-linux-gnu
	or1k-*-linux-gnu
	powerpc-*-linux-gnu	Hardware or software floating point, BE only.
	powerpc64*-*-linux-gnu	Big-endian and little-endian.
	s390-*-linux-gnu
	s390x-*-linux-gnu
	riscv32-*-linux-gnu
	riscv64-*-linux-gnu
	sh[34]-*-linux-gnu
	sparc*-*-linux-gnu
	sparc64*-*-linux-gnu

If you are interested in doing a port, please contact the glibc
maintainers; see https://www.gnu.org/software/libc/ for more
information.

See the file INSTALL to find out how to configure, build, and install
the GNU C Library.  You might also consider reading the WWW pages for
the C library at https://www.gnu.org/software/libc/.

The GNU C Library is (almost) completely documented by the Texinfo manual
found in the `manual/' subdirectory.  The manual is still being updated
and contains some known errors and omissions; we regret that we do not
have the resources to work on the manual as much as we would like.  For
corrections to the manual, please file a bug in the `manual' component,
following the bug-reporting instructions below.  Please be sure to check
the manual in the current development sources to see if your problem has
already been corrected.

Please see https://www.gnu.org/software/libc/bugs.html for bug reporting
information.  We are now using the Bugzilla system to track all bug reports.
This web page gives detailed information on how to report bugs properly.

The GNU C Library is free software.  See the file COPYING.LIB for copying
conditions, and LICENSES for notices about a few contributions that require
these additional notices to be distributed.  License copyright years may be
listed using range notation, e.g., 1996-2015, indicating that every year in
the range, inclusive, is a copyrightable year that would otherwise be listed
individually.