AuroraMiddleware/glibc
1
0
Fork 0
mirror of https://sourceware.org/git/glibc.git synced 2024-12-12 06:10:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
0e6ebf06e4
glibc/wcsmbs
History
Siddhesh Poyarekar 0e6ebf06e4 Make sure that the fortified function conditionals are constant 
In _FORTIFY_SOURCE=3, the size expression may be non-constant,
resulting in branches in the inline functions remaining intact and
causing a tiny overhead.  Clang (and in future, gcc) make sure that
the -1 case is always safe, i.e. any comparison of the generated
expression with (size_t)-1 is always false so that bit is taken care
of.  The rest is avoidable since we want the _chk variant whenever we
have a size expression and it's not -1.

Rework the conditionals in a uniform way to clearly indicate two
conditions at compile time:

- Either the size is unknown (-1) or we know at compile time that the
  operation length is less than the object size.  We can call the
  original function in this case.  It could be that either the length,
  object size or both are non-constant, but the compiler, through
  range analysis, is able to fold the *comparison* to a constant.

- The size and length are known and the compiler can see at compile
  time that operation length > object size.  This is valid grounds for
  a warning at compile time, followed by emitting the _chk variant.

For everything else, emit the _chk variant.

This simplifies most of the fortified function implementations and at
the same time, ensures that only one call from _chk or the regular
function is emitted.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
(cherry picked from commit a643f60c53)
2022-03-11 20:36:24 +05:30
..
bits Make sure that the fortified function conditionals are constant 2022-03-11 20:36:24 +05:30
btowc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
c16rtomb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
c32rtomb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Depend
isoc99_fwscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_swscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vfwscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vswscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_vwscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
isoc99_wscanf.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Makefile Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbrlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbrtoc16.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbrtoc32.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbrtowc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbsinit.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbsnrtowcs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbsrtowcs_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
mbsrtowcs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-char-types.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcpcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcpncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcscat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcschr.c Add wcschr test cases 2011-10-23 14:14:26 -04:00
test-wcschrnul.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcscmp.c Move wide char tests to wcsmbs directory 2011-09-08 18:01:07 -04:00
test-wcscpy.c Add tests for wcsrchr and wcscpy 2011-12-17 14:14:58 -05:00
test-wcscspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcslen.c Add wcslen test cases 2011-10-23 14:11:50 -04:00
test-wcsncat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcsncmp.c Use correct signedness in wcsncmp 2015-04-13 21:25:04 +02:00
test-wcsncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcsnlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcspbrk.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wcsrchr.c Add tests for wcsrchr and wcscpy 2011-12-17 14:14:58 -05:00
test-wcsspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wmemchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
test-wmemcmp.c Move wide char tests to wcsmbs directory 2011-09-08 18:01:07 -04:00
test-wmemset.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-btowc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-c16-surrogate.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-c16c32-1.c Add #include <stdint.h> for uint[32|64]_t usage (except installed headers). 2013-05-16 11:32:54 -05:00
tst-c32-state.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-fgetwc-after-eof.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
tst-mbrtowc2.c Prefer https for Sourceware links 2017-11-16 11:49:26 +05:30
tst-mbrtowc.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-mbsrtowcs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-mbstowcs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wchar-h.c Update wcsmbs tests to use the support test driver 2017-04-04 18:05:20 -03:00
tst-wcpncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcrtomb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcsnlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcstod-nan-locale.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcstod-nan-sign.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcstod-round.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
tst-wcstof.c Update wcsmbs tests to use the support test driver 2017-04-04 18:05:20 -03:00
tst-wcstol-locale.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
uchar.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
Versions Add _Float32 function aliases. 2017-12-07 00:48:31 +00:00
wchar.h Enable support for GCC 11 -Wmismatched-dealloc. 2021-05-16 15:21:18 -06:00
wcpcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcpncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcrtomb.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsatcliff.c Fix handling of tail bytes of buffer in SSE2/SSSE3 x86-64 version strn{,case}cmp 2010-10-03 22:10:30 -04:00
wcscasecmp_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscasecmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcschr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcschrnul.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscoll_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscoll.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcscspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsdup.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcslen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsmbs-tst1.c Add dependencies on needed locales in each subdir tests (bug 18969) 2015-10-12 15:18:08 +02:00
wcsmbsload.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsmbsload.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsncase_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsncase.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsncat.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsncmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsncpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsnlen.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsnrtombs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcspbrk.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsrchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsrtombs.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsspn.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsstr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstod_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstod_nan.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstod.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstof_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstof_nan.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstof.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstok.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstol_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstol.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstold_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstold_nan.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstold.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoll_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoll.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoul_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoul.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoull_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcstoull.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcswidth.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsxfrm_l.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcsxfrm.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wctob.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcwidth.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wcwidth.h Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmemchr.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmemcmp.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmemcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmemmove.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmempcpy.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00
wmemset.c Update copyright dates with scripts/update-copyrights 2021-01-02 12:17:34 -08:00