mirror of
https://sourceware.org/git/glibc.git
synced 2024-12-23 19:30:10 +00:00
c4eae75271
__get_nprocs is called from malloc code, but calls fgets_unlocked, which is not an ISO C or POSIX function. This patch fixes it to call a new __fgets_unlocked name instead. Note: there are various other uses of fgets_unlocked in glibc's libraries, and I haven't yet investigated which others might also be problematic (called directly or indirectly from standard functions) and so need to change to use __fgets_unlocked. Tested for x86_64 (testsuite, and that disassembly of installed shared libraries is unchanged by the patch). [BZ #17582] * libio/iofgets.c [weak_alias && !_IO_MTSAFE_IO] (__fgets_unlocked): Add alias of _IO_fgets. Use libc_hidden_def. * libio/iofgets_u.c (fgets_unlocked): Rename to __fgets_unlocked and define as weak alias of __fgets_unlocked. Use libc_hidden_weak. (__fgets_unlocked): Use libc_hidden_def. * include/stdio.h (__fgets_unlocked): Declare. Use libc_hidden_proto. * sysdeps/unix/sysv/linux/getsysstats.c (phys_pages_info): Use __fgets_unlocked instead of fgets_unlocked. * sysdeps/unix/sysv/linux/alpha/getsysstats.c (GET_NPROCS_CONF_PARSER): Likewise. * sysdeps/unix/sysv/linux/sparc/getsysstats.c (GET_NPROCS_CONF_PARSER): Likewise.
82 lines
2.6 KiB
C
82 lines
2.6 KiB
C
/* Copyright (C) 1993-2014 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>.
|
|
|
|
As a special exception, if you link the code in this file with
|
|
files compiled with a GNU compiler to produce an executable,
|
|
that does not cause the resulting executable to be covered by
|
|
the GNU Lesser General Public License. This exception does not
|
|
however invalidate any other reasons why the executable file
|
|
might be covered by the GNU Lesser General Public License.
|
|
This exception applies to code released by its copyright holders
|
|
in files containing the exception. */
|
|
|
|
#include "libioP.h"
|
|
#include <stdio.h>
|
|
|
|
char *
|
|
_IO_fgets (buf, n, fp)
|
|
char *buf;
|
|
int n;
|
|
_IO_FILE *fp;
|
|
{
|
|
_IO_size_t count;
|
|
char *result;
|
|
int old_error;
|
|
CHECK_FILE (fp, NULL);
|
|
if (n <= 0)
|
|
return NULL;
|
|
if (__glibc_unlikely (n == 1))
|
|
{
|
|
/* Another irregular case: since we have to store a NUL byte and
|
|
there is only room for exactly one byte, we don't have to
|
|
read anything. */
|
|
buf[0] = '\0';
|
|
return buf;
|
|
}
|
|
_IO_acquire_lock (fp);
|
|
/* This is very tricky since a file descriptor may be in the
|
|
non-blocking mode. The error flag doesn't mean much in this
|
|
case. We return an error only when there is a new error. */
|
|
old_error = fp->_IO_file_flags & _IO_ERR_SEEN;
|
|
fp->_IO_file_flags &= ~_IO_ERR_SEEN;
|
|
count = _IO_getline (fp, buf, n - 1, '\n', 1);
|
|
/* If we read in some bytes and errno is EAGAIN, that error will
|
|
be reported for next read. */
|
|
if (count == 0 || ((fp->_IO_file_flags & _IO_ERR_SEEN)
|
|
&& errno != EAGAIN))
|
|
result = NULL;
|
|
else
|
|
{
|
|
buf[count] = '\0';
|
|
result = buf;
|
|
}
|
|
fp->_IO_file_flags |= old_error;
|
|
_IO_release_lock (fp);
|
|
return result;
|
|
}
|
|
|
|
#ifdef weak_alias
|
|
weak_alias (_IO_fgets, fgets)
|
|
|
|
# ifndef _IO_MTSAFE_IO
|
|
strong_alias (_IO_fgets, __fgets_unlocked)
|
|
libc_hidden_def (__fgets_unlocked)
|
|
weak_alias (_IO_fgets, fgets_unlocked)
|
|
libc_hidden_weak (fgets_unlocked)
|
|
# endif
|
|
#endif
|