mirror of
https://sourceware.org/git/glibc.git
synced 2024-11-30 00:31:08 +00:00
eb76e5b465
Patch ce7eb0e903
("nptl: Cleanup cancellation macros") changed the
join sequence for internal common __pthread_timedjoin_ex to use the
new macro lll_wait_tid. The idea was this macro would issue the
cancellable futex operation depending whether the timeout is used or
not. However if a timeout is used, __lll_timedwait_tid is called and
it is not a cancellable entrypoint.
This patch fixes it by simplifying the code in various ways:
- Instead of adding the cancellation handling on __lll_timedwait_tid,
it moves the generic implementation to pthread_join_common.c (called
now timedwait_tid with some fixes to use the correct type for pid).
- The llvm_wait_tid macro is removed, along with its replication on
x86_64, i686, and sparc arch-specific lowlevellock.h.
- sparc32 __lll_timedwait_tid is also removed, since the code is similar
to generic one.
- x86_64 and i386 provides arch-specific __lll_timedwait_tid which is
also removed since they are similar in functionality to generic C code
and there is no indication it is better than compiler generated code.
New tests, tst-join8 and tst-join9, are provided to check if
pthread_timedjoin_np acts as a cancellation point.
Checked on x86_64-linux-gnu, i686-linux-gnu, sparcv9-linux-gnu, and
aarch64-linux-gnu.
[BZ #24215]
* nptl/Makefile (lpthread-routines): Remove lll_timedwait_tid.
(tests): Add tst-join8 tst-join9.
* nptl/lll_timedwait_tid.c: Remove file.
* sysdeps/sparc/sparc32/lll_timedwait_tid.c: Likewise.
* sysdeps/unix/sysv/linux/i386/lll_timedwait_tid.c: Likewise.
* sysdeps/sysv/linux/x86_64/lll_timedwait_tid.c: Likewise.
* nptl/pthread_join_common.c (timedwait_tid): New function.
(__pthread_timedjoin_ex): Act as cancellation entrypoint is block
is set.
* nptl/tst-join5.c (thread_join): New function.
(tf1, tf2, do_test): Use libsupport and add pthread_timedjoin_np
check.
* nptl/tst-join8.c: New file.
* nptl/tst-join9.c: Likewise.
* sysdeps/nptl/lowlevellock-futex.h (lll_futex_wait_cancel,
lll_futex_timed_wait_cancel): Add generic macros.
* sysdeps/nptl/lowlevellock.h (__lll_timedwait_tid, lll_wait_tid):
Remove definitions.
* sysdeps/unix/sysv/linux/i386/lowlevellock.h: Likewise.
* sysdeps/unix/sysv/linux/sparc/lowlevellock.h: Likewise.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Likewise.
* sysdeps/sparc/sparc32/lowlevellock.c (__lll_timedwait_tid):
Remove function.
* sysdeps/unix/sysv/linux/i386/lowlevellock.S (__lll_timedwait_tid):
Likewise.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise.
* sysdeps/unix/sysv/linux/lowlevellock-futex.h
(lll_futex_timed_wait_cancel): New macro.
184 lines
3.6 KiB
C
184 lines
3.6 KiB
C
/* Copyright (C) 2003-2019 Free Software Foundation, Inc.
|
|
This file is part of the GNU C Library.
|
|
Contributed by Ulrich Drepper <drepper@redhat.com>, 2003.
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with the GNU C Library; if not, see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#include <errno.h>
|
|
#include <pthread.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <time.h>
|
|
#include <unistd.h>
|
|
|
|
#include <support/check.h>
|
|
#include <support/xthread.h>
|
|
|
|
static void
|
|
wait_code (void)
|
|
{
|
|
struct timespec ts = { .tv_sec = 0, .tv_nsec = 200000000 };
|
|
while (nanosleep (&ts, &ts) < 0)
|
|
;
|
|
}
|
|
|
|
|
|
#ifdef WAIT_IN_CHILD
|
|
static pthread_barrier_t b;
|
|
#endif
|
|
|
|
static int
|
|
thread_join (pthread_t thread, void **retval)
|
|
{
|
|
#ifdef USE_PTHREAD_TIMEDJOIN_NP
|
|
struct timespec tv;
|
|
TEST_COMPARE (clock_gettime (CLOCK_REALTIME, &tv), 0);
|
|
/* Arbitrary large timeout to make it act as pthread_join. */
|
|
tv.tv_sec += 1000;
|
|
return pthread_timedjoin_np ((pthread_t) thread, retval, &tv);
|
|
#else
|
|
return pthread_join ((pthread_t) thread, retval);
|
|
#endif
|
|
}
|
|
|
|
|
|
static void *
|
|
tf1 (void *arg)
|
|
{
|
|
#ifdef WAIT_IN_CHILD
|
|
xpthread_barrier_wait (&b);
|
|
|
|
wait_code ();
|
|
#endif
|
|
|
|
thread_join ((pthread_t) arg, NULL);
|
|
|
|
exit (42);
|
|
}
|
|
|
|
|
|
static void *
|
|
tf2 (void *arg)
|
|
{
|
|
#ifdef WAIT_IN_CHILD
|
|
xpthread_barrier_wait (&b);
|
|
|
|
wait_code ();
|
|
#endif
|
|
|
|
thread_join ((pthread_t) arg, NULL);
|
|
|
|
exit (43);
|
|
}
|
|
|
|
|
|
static int
|
|
do_test (void)
|
|
{
|
|
#ifdef WAIT_IN_CHILD
|
|
xpthread_barrier_init (&b, NULL, 2);
|
|
#endif
|
|
|
|
pthread_t th;
|
|
|
|
int err = thread_join (pthread_self (), NULL);
|
|
if (err == 0)
|
|
{
|
|
puts ("1st circular join succeeded");
|
|
return 1;
|
|
}
|
|
if (err != EDEADLK)
|
|
{
|
|
printf ("1st circular join %d, not EDEADLK\n", err);
|
|
return 1;
|
|
}
|
|
|
|
th = xpthread_create (NULL, tf1, (void *) pthread_self ());
|
|
|
|
#ifndef WAIT_IN_CHILD
|
|
wait_code ();
|
|
#endif
|
|
|
|
xpthread_cancel (th);
|
|
|
|
#ifdef WAIT_IN_CHILD
|
|
xpthread_barrier_wait (&b);
|
|
#endif
|
|
|
|
void *r;
|
|
err = thread_join (th, &r);
|
|
if (err != 0)
|
|
{
|
|
printf ("cannot join 1st thread: %d\n", err);
|
|
return 1;
|
|
}
|
|
if (r != PTHREAD_CANCELED)
|
|
{
|
|
puts ("1st thread not canceled");
|
|
return 1;
|
|
}
|
|
|
|
err = thread_join (pthread_self (), NULL);
|
|
if (err == 0)
|
|
{
|
|
puts ("2nd circular join succeeded");
|
|
return 1;
|
|
}
|
|
if (err != EDEADLK)
|
|
{
|
|
printf ("2nd circular join %d, not EDEADLK\n", err);
|
|
return 1;
|
|
}
|
|
|
|
th = xpthread_create (NULL, tf2, (void *) pthread_self ());
|
|
|
|
#ifndef WAIT_IN_CHILD
|
|
wait_code ();
|
|
#endif
|
|
|
|
xpthread_cancel (th);
|
|
|
|
#ifdef WAIT_IN_CHILD
|
|
xpthread_barrier_wait (&b);
|
|
#endif
|
|
|
|
if (thread_join (th, &r) != 0)
|
|
{
|
|
puts ("cannot join 2nd thread");
|
|
return 1;
|
|
}
|
|
if (r != PTHREAD_CANCELED)
|
|
{
|
|
puts ("2nd thread not canceled");
|
|
return 1;
|
|
}
|
|
|
|
err = thread_join (pthread_self (), NULL);
|
|
if (err == 0)
|
|
{
|
|
puts ("3rd circular join succeeded");
|
|
return 1;
|
|
}
|
|
if (err != EDEADLK)
|
|
{
|
|
printf ("3rd circular join %d, not EDEADLK\n", err);
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#include <support/test-driver.c>
|